From nobody Fri Oct 24 20:22:34 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1518748507474621.3885125024641; Thu, 15 Feb 2018 18:35:07 -0800 (PST) Received: from localhost ([::1]:57323 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emVre-0001Ji-Mq for importer@patchew.org; Thu, 15 Feb 2018 21:35:06 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60327) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emVmc-0005LZ-SY for qemu-devel@nongnu.org; Thu, 15 Feb 2018 21:29:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1emVmb-0002TD-Qz for qemu-devel@nongnu.org; Thu, 15 Feb 2018 21:29:54 -0500 Received: from mail-ua0-x241.google.com ([2607:f8b0:400c:c08::241]:37008) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1emVmb-0002T4-N2 for qemu-devel@nongnu.org; Thu, 15 Feb 2018 21:29:53 -0500 Received: by mail-ua0-x241.google.com with SMTP id q8so1107454uae.4 for ; Thu, 15 Feb 2018 18:29:53 -0800 (PST) Received: from x1.lan ([138.117.48.219]) by smtp.gmail.com with ESMTPSA id q5sm6295200uaj.17.2018.02.15.18.29.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Feb 2018 18:29:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lozniz2bfYUXWtMvsNH9xAbCoclQlr7hAtTQFkfd8hY=; b=N0m8/ffezeL8ZwOcnsPW4uTY0d+cRwfST7HwyJkH2o145NWzbpWFR8Nsth3rHtSbiv Zth9Z7a0EaYA0rHCtq3f+WZImeabXSV7iCmGkbiGsWXgNiaMF8+dp5isk41sn+nMQrjT mHuk7sOYNTF0HIGCTEExKeqnQM8OvHnmRzvlMladp3mo4Ymflh5LahowVjB3rcSNt7X6 +oL4pyM2gJe/6JxT2Drh3W8VeDte3s7IfV9OxLXwcmjVEzyaY1iBWYXSJASSZxHLAg6F 2i/J4bBcm5d8n3zNhRhCSUT0tVsB1iXetd6ikN4sMcOxDx0+tBak9BIJpsVlcJ0lKoSx Zf7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=lozniz2bfYUXWtMvsNH9xAbCoclQlr7hAtTQFkfd8hY=; b=TnD5Hd7gSdXgu8LLUqAqA3Vc4G8WluIMDQHJFi/jRBo2J1VP8OVm/hmZ7eOZbvz9De ct+HnI738Nt0NAPhYCt/I+9Ft+vv/Nmj5cUKtcHydSHimiiGVjqmkg0S27658QvOwdGc tStcXYSkR3m0nzzSYoII+IZB5tMV80uAMmf3siQEsobJnf5rJ7KkBJxaAlFeh2rs8zXv q0PQ5JkZ+IswJz1XKLisTgJNGX1WkLQBrzASHuOZWSqNl6T5P6fztbjmHuUvI0wYWFwf 2kJ3nBwxGpFKKFjA5Sz9Lt8GCPoJLdNLQITW9xJUmmZqfnnnvtjesmzTvY4B4B//SNqm AIvw== X-Gm-Message-State: APf1xPCOhTj+vPLgj0+mHmK10as4vo7kIk4qZ9d/ck78Xf4BnZcJPFEi 0riSiBAszLe4eX7QIiXAD84= X-Google-Smtp-Source: AH8x226Flg29/kyOUhmzudlLqujgvqrcw8VbMZiDJSHMDNPoofxZb9EJeVv2aOIURScN0YqurlRi0g== X-Received: by 10.176.28.14 with SMTP id a14mr3737018uaj.146.1518748193139; Thu, 15 Feb 2018 18:29:53 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Alistair Francis , Peter Maydell Date: Thu, 15 Feb 2018 23:29:26 -0300 Message-Id: <20180216022933.10945-2-f4bug@amsat.org> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180216022933.10945-1-f4bug@amsat.org> References: <20180216022933.10945-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400c:c08::241 Subject: [Qemu-devel] [PATCH v3 1/7] hw/sd/milkymist-memcard: use qemu_log_mask() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Edgar E . Iglesias" , Stefan Weil , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org, Michael Walle Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis Acked-by: Michael Walle --- hw/sd/milkymist-memcard.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/hw/sd/milkymist-memcard.c b/hw/sd/milkymist-memcard.c index 341da88552..1292c0c099 100644 --- a/hw/sd/milkymist-memcard.c +++ b/hw/sd/milkymist-memcard.c @@ -22,11 +22,12 @@ */ =20 #include "qemu/osdep.h" +#include "qemu/log.h" #include "hw/hw.h" #include "hw/sysbus.h" #include "sysemu/sysemu.h" #include "trace.h" -#include "qemu/error-report.h" +#include "include/qapi/error.h" #include "sysemu/block-backend.h" #include "sysemu/blockdev.h" #include "hw/sd/sd.h" @@ -138,8 +139,8 @@ static uint64_t memcard_read(void *opaque, hwaddr addr, } else { r =3D s->response[s->response_read_ptr++]; if (s->response_read_ptr > s->response_len) { - error_report("milkymist_memcard: " - "read more cmd bytes than available. Clipping."); + qemu_log_mask(LOG_GUEST_ERROR, "milkymist_memcard: " + "read more cmd bytes than available. Clippin= g."); s->response_read_ptr =3D 0; } } @@ -163,8 +164,9 @@ static uint64_t memcard_read(void *opaque, hwaddr addr, break; =20 default: - error_report("milkymist_memcard: read access to unknown register 0= x" - TARGET_FMT_plx, addr << 2); + qemu_log_mask(LOG_UNIMP, "milkymist_memcard: " + "read access to unknown register 0x%" HWADDR_PRIx "\= n", + addr << 2); break; } =20 @@ -220,8 +222,9 @@ static void memcard_write(void *opaque, hwaddr addr, ui= nt64_t value, break; =20 default: - error_report("milkymist_memcard: write access to unknown register = 0x" - TARGET_FMT_plx, addr << 2); + qemu_log_mask(LOG_UNIMP, "milkymist_memcard: " + "write access to unknown register 0x%" HWADDR_PRIx "= " + "(value 0x%" PRIx64 ")\n", addr << 2, value); break; } } --=20 2.16.1