From nobody Fri Oct 24 20:16:11 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of _spf.google.com designates 209.85.216.196 as permitted sender) client-ip=209.85.216.196; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-qt0-f196.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of _spf.google.com designates 209.85.216.196 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-qt0-f196.google.com (mail-qt0-f196.google.com [209.85.216.196]) by mx.zohomail.com with SMTPS id 151866902253299.11370934413071; Wed, 14 Feb 2018 20:30:22 -0800 (PST) Received: by mail-qt0-f196.google.com with SMTP id u6so10464887qtg.13 for ; Wed, 14 Feb 2018 20:30:22 -0800 (PST) Return-Path: Return-Path: Received: from x1.local ([138.117.48.219]) by smtp.gmail.com with ESMTPSA id t33sm10680312qtc.14.2018.02.14.20.30.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Feb 2018 20:30:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2BBBQqvI47UfmqKxAS0LHU2cAb/9FQUdWxwwlKHXCfk=; b=IigZGMKZ+eVzncV5N0jrt/47DRn9WrRBC6mEzUJtZZwwK6Q3Ar9d5CruGmo0IUrzaY /nKiVf8BjRGT7fVvIeWJyZW2qheqm7fwRH1/LMURQuFUXr+LenEj3JW5mJKHskSOiJ3m nYGc9slHzXoPxzO1B3HjvauXD7XBJd1IZ91/1HwFCeiaZ9pJifc0si7ZRggWSsq0rqhx 8SvyjBNmbSc3W21vTNserR+rfkc+9VD+RXM0No+tKG3dAFFPurvWleQntnESZkpMTUdi mYL0AlOxr106hfYt5pV9QWxaEZ50rSJyxrNaNHJJvNtsMkmKzuWMdPHkq2VkzintagFK 0DvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=2BBBQqvI47UfmqKxAS0LHU2cAb/9FQUdWxwwlKHXCfk=; b=rHxIflZsBA3LZYbkFbbWuoCFYucPilEY8MByI1eKH9CB9+xLtlgw5IPXHoUxpWrc9f kPRkgOIvJ2p4eP082e4kRxfIYAGPk+lGUv9KslzYNuZ6eLx9U0ALL3Une6XJ30mck7Hc CRlwREMVe1+/1ohuqmohJ2VoExoQckT6KI/aHQNnqMhd4l6S+lP6+oMCWOSGNs8URh/G nnbSXiv8zIAcrdmguUhpmyCmAYbCwWhtzsW7mCXAWPx4IsKwboSJ6mZ1Prm5Z2nZ7+hD yRNwqgyqXzeRbP2GsoFJMjMLyUyPFln7nVm9dM2h7iZ4IYE4VDt3cWokmRNCIyS8Fxpu OhbA== X-Gm-Message-State: APf1xPCjcHbM2hGHFApZHO6H+IHdJWFgNuQwFPJ/9zdz0Oubuh4RB/+/ RdfirYu7PIBAeHneKkGlBK8= X-Google-Smtp-Source: AH8x2263FzAhaBhrKkKwn8YJrIHNQwFriZyYIMzpZefEgsJTT3+OabmR/dk0mXtPGqRpivER1Jc3AQ== X-Received: by 10.200.40.73 with SMTP id 9mr2348102qtr.285.1518669021530; Wed, 14 Feb 2018 20:30:21 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , Fam Zheng Subject: [PATCH 25/30] hw/scsi: use the BYTE-based definitions Date: Thu, 15 Feb 2018 01:28:55 -0300 Message-Id: <20180215042900.16078-26-f4bug@amsat.org> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180215042900.16078-1-f4bug@amsat.org> References: <20180215042900.16078-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZohoMail: RDKM_0 RSF_0 Z_629925259 SPT_0 It ease code review, unit is explicit. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/scsi/scsi-disk.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index 49d2559d93..bfdb34a71c 100644 --- a/hw/scsi/scsi-disk.c +++ b/hw/scsi/scsi-disk.c @@ -44,13 +44,13 @@ do { printf("scsi-disk: " fmt , ## __VA_ARGS__); } whil= e (0) #include #endif =20 -#define SCSI_WRITE_SAME_MAX 524288 -#define SCSI_DMA_BUF_SIZE 131072 +#define SCSI_WRITE_SAME_MAX (512 * K_BYTE) +#define SCSI_DMA_BUF_SIZE (128 * K_BYTE) #define SCSI_MAX_INQUIRY_LEN 256 #define SCSI_MAX_MODE_LEN 256 =20 -#define DEFAULT_DISCARD_GRANULARITY 4096 -#define DEFAULT_MAX_UNMAP_SIZE (1 << 30) /* 1 GB */ +#define DEFAULT_DISCARD_GRANULARITY (4 * K_BYTE) +#define DEFAULT_MAX_UNMAP_SIZE (1 * G_BYTE) #define DEFAULT_MAX_IO_SIZE INT_MAX /* 2 GB - 1 block */ =20 #define TYPE_SCSI_DISK_BASE "scsi-disk-base" --=20 2.16.1