From nobody Tue Feb 10 02:28:10 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of _spf.google.com designates 209.85.220.194 as permitted sender) client-ip=209.85.220.194; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-qk0-f194.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of _spf.google.com designates 209.85.220.194 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-qk0-f194.google.com (mail-qk0-f194.google.com [209.85.220.194]) by mx.zohomail.com with SMTPS id 1518494972831783.7249154099961; Mon, 12 Feb 2018 20:09:32 -0800 (PST) Received: by mail-qk0-f194.google.com with SMTP id c128so21066269qkb.4 for ; Mon, 12 Feb 2018 20:09:32 -0800 (PST) Return-Path: Return-Path: Received: from x1.local ([138.117.48.219]) by smtp.gmail.com with ESMTPSA id q2sm7350435qki.10.2018.02.12.20.09.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Feb 2018 20:09:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KFpgQEhaZBgnPE0U5fVE+w0zSSdDn/i3ICfYlKUYVZU=; b=q2IgqJdgK7ZluQp/Ab9XSJ32J3TTHTj/K3oWvVeZtFMgkY2bvLwfdVS0+VbwI9yVDd R9b36hCQaghjjd5Ny1cUIRCG8ivnqqYDZDbCl8Ao65lTApZxTKB1sp2WcGR0/cNM0uQ1 GXamXMmIp8T31GfuiAuQzD6Oq5tbidKuCorD/NVmUZ6p90N8AAXP0bdsCaeuQLMNAI2C jVbadu2aJ9/QgY9eYb2oYRc4ACuv3q4lCYm0zY4W0dYrx4j65RXZjdQsn1MdAfrbHhZP XCzFcH1RCodPAwXCkDNZyeefTtkny7F9Fk5So1jlbK83ux9aa7uSRh3HvoXeHjs+4JdN flWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=KFpgQEhaZBgnPE0U5fVE+w0zSSdDn/i3ICfYlKUYVZU=; b=IkK4jaZvKA67G0HqsTAduZN/37ZBfj39oHR+VEZib7UB9Ihdk/ySD42rT/BbLFHutL J6w25UKm5QMEtJW+y6vM0bIqE5d4FQK0ggSPGs1nf3Uvzb7Qp3jYa2nwXYY7OWK/fKLo K8FmSgFF0ce721yivuaqHVJh9jih2iVjG13h+TZMSEiEpPhlQvXqCG2eREVY+/hJK76x 5szjjYndNjCWfqrkLfTWg0A9SG2YZ/5r136MMRryQYGYas8GTvdZZEWPe4nRjmVlsplt 2KQSniR7llVX00eYD1KTC13WCWKKQ738GOdCKEO9UX43ITXjmCexgORUEwH5ViFnlEhR WJng== X-Gm-Message-State: APf1xPCUWLFeE/8k01gGUx4n9QnXMMuPbGn73w2J0VkREyUoElicEEpH 8WMDEJ72XhM6lPi3CfbYPIUCHpZ0 X-Google-Smtp-Source: AH8x2277QRc8ByEFOEc9RT2uTOPJyTBQm+FvLIU+jHbH7+tBd3Coyfxg0lPLpzdUWPsackHRCUHRCw== X-Received: by 10.55.112.132 with SMTP id l126mr20889336qkc.296.1518494972006; Mon, 12 Feb 2018 20:09:32 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Paolo Bonzini Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org, Peter Maydell , Alistair Francis , "Edgar E . Iglesias" , Fam Zheng , qemu-arm@nongnu.org (open list:ARM) Subject: [PATCH v13 23/30] hw/arm/bcm2835_peripherals: implement SDHCI Spec v3 Date: Tue, 13 Feb 2018 01:08:02 -0300 Message-Id: <20180213040809.26021-24-f4bug@amsat.org> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180213040809.26021-1-f4bug@amsat.org> References: <20180213040809.26021-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZohoMail: RDKM_0 RSF_0 Z_629925259 SPT_0 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis --- hw/arm/bcm2835_peripherals.c | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/hw/arm/bcm2835_peripherals.c b/hw/arm/bcm2835_peripherals.c index 12e0dd11af..ca971e83e0 100644 --- a/hw/arm/bcm2835_peripherals.c +++ b/hw/arm/bcm2835_peripherals.c @@ -254,14 +254,19 @@ static void bcm2835_peripherals_realize(DeviceState *= dev, Error **errp) memory_region_add_subregion(&s->peri_mr, RNG_OFFSET, sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->rng), 0)); =20 - /* Extended Mass Media Controller */ - object_property_set_int(OBJECT(&s->sdhci), BCM2835_SDHC_CAPAREG, "capa= reg", - &err); - if (err) { - error_propagate(errp, err); - return; - } - + /* Extended Mass Media Controller + * + * Compatible with: + * - SD Host Controller Specification Version 3.0 Draft 1.0 + * - SDIO Specification Version 3.0 + * - MMC Specification Version 4.4 + * + * For the exact details please refer to the Arasan documentation: + * SD3.0_Host_AHB_eMMC4.4_Usersguide_ver5.9_jan11_10.pdf + */ + object_property_set_uint(OBJECT(&s->sdhci), 3, "sd-spec-version", &err= ); + object_property_set_uint(OBJECT(&s->sdhci), BCM2835_SDHC_CAPAREG, "cap= areg", + &err); object_property_set_bool(OBJECT(&s->sdhci), true, "pending-insert-quir= k", &err); if (err) { --=20 2.16.1