From nobody Wed Feb 11 04:06:09 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of _spf.google.com designates 209.85.220.194 as permitted sender) client-ip=209.85.220.194; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-qk0-f194.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of _spf.google.com designates 209.85.220.194 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-qk0-f194.google.com (mail-qk0-f194.google.com [209.85.220.194]) by mx.zohomail.com with SMTPS id 1518494963428662.7470852602146; Mon, 12 Feb 2018 20:09:23 -0800 (PST) Received: by mail-qk0-f194.google.com with SMTP id g129so6525479qkb.13 for ; Mon, 12 Feb 2018 20:09:23 -0800 (PST) Return-Path: Return-Path: Received: from x1.local ([138.117.48.219]) by smtp.gmail.com with ESMTPSA id q2sm7350435qki.10.2018.02.12.20.09.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Feb 2018 20:09:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PRVVrWr1dkuT1tVe6teh0w/edU9ae96q3kRiLd5UG5I=; b=Z+5rRn5L8TP6ZG1ojbUt308C9yG/GGAqhidPxNsF3Z7apNiblwaxzLfgYfwppD2CEK fdJspeT7Yd7jxfx+7a58xizOYaJ7XklQc1NyfWi8ILWkGMYuawuj1Uv+Bi3sw8aRsfG+ Hp3lTCSW9kV1gROKvtWJIYWdbYvRC88/V0Yh/JL9iSIOBOZmNwXrqPZjpkWHqS+1h4gQ 6yH2yHN3og81APabex7jdTrEMVrZfG5y45Hg4XvhwfDj6qj4ckX5wcbxcmCyDh18NuKl zzfLaru3tfnmtSbeJmnQ8NgZO4GFJ6Rm6HZTCdhN95zAw9nAlDk8A1zakvqELULJqlfU wgjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=PRVVrWr1dkuT1tVe6teh0w/edU9ae96q3kRiLd5UG5I=; b=IRB6hRaAz3Khofn3TMKPqc08J7t4KCg5kaWgwdTDCcHVzFj1H5kJhjGo2mhFEomhYm YdJe4+spenbfNKsjipOiVN6yl+T4XxtND3dq/+LFkAwcyhL7ts/QKpWwPINm3UfIZxBo xKbl85qM66Iph+hbzCGN8mdS7w+TFnrRrLiCnPQYXFSCpa9d0fDGqW354biw990ijcEH na4w5Lep5dCu8vnkzMTGXZrkZNcnjOhLkRehhj4/8999p9wOV/yOH2TOwIkVF8QPmY4w hlZH1ezOw6ineGTTXRBKzdJ2vVXageanEUYCej+slVWZEDU3Q2Qi1hWRdAL8RUlV5pIF /E5A== X-Gm-Message-State: APf1xPDKLsnRq2MsbRiSibsMELA3AzoZvDSqo+H9LarnA0dEWXPqB79c BtnxaHogPwKYjIFlGKwET58= X-Google-Smtp-Source: AH8x227Y6jY77hHBrInll6owTmdpMJkJTaQaiqbstw++NYidNdVmDCNOv8P2x3Y2d8hWBdGtbnAPqA== X-Received: by 10.55.74.2 with SMTP id x2mr3733175qka.314.1518494962567; Mon, 12 Feb 2018 20:09:22 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Paolo Bonzini Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org, Peter Maydell , Alistair Francis , "Edgar E . Iglesias" , Fam Zheng Subject: [PATCH v13 20/30] sdbus: add trace events Date: Tue, 13 Feb 2018 01:07:59 -0300 Message-Id: <20180213040809.26021-21-f4bug@amsat.org> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180213040809.26021-1-f4bug@amsat.org> References: <20180213040809.26021-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZohoMail: RDKM_0 RSF_0 Z_629925259 SPT_0 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis --- hw/sd/core.c | 14 ++++++++++++-- hw/sd/trace-events | 5 +++++ 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/hw/sd/core.c b/hw/sd/core.c index 295dc44ab7..498284f109 100644 --- a/hw/sd/core.c +++ b/hw/sd/core.c @@ -23,6 +23,12 @@ #include "hw/qdev-core.h" #include "sysemu/block-backend.h" #include "hw/sd/sd.h" +#include "trace.h" + +static inline const char *sdbus_name(SDBus *sdbus) +{ + return sdbus->qbus.name; +} =20 static SDState *get_card(SDBus *sdbus) { @@ -39,6 +45,7 @@ int sdbus_do_command(SDBus *sdbus, SDRequest *req, uint8_= t *response) { SDState *card =3D get_card(sdbus); =20 + trace_sdbus_command(sdbus_name(sdbus), req->cmd, req->arg, req->crc); if (card) { SDCardClass *sc =3D SD_CARD_GET_CLASS(card); =20 @@ -52,6 +59,7 @@ void sdbus_write_data(SDBus *sdbus, uint8_t value) { SDState *card =3D get_card(sdbus); =20 + trace_sdbus_write(sdbus_name(sdbus), value); if (card) { SDCardClass *sc =3D SD_CARD_GET_CLASS(card); =20 @@ -62,14 +70,16 @@ void sdbus_write_data(SDBus *sdbus, uint8_t value) uint8_t sdbus_read_data(SDBus *sdbus) { SDState *card =3D get_card(sdbus); + uint8_t value =3D 0; =20 if (card) { SDCardClass *sc =3D SD_CARD_GET_CLASS(card); =20 - return sc->read_data(card); + value =3D sc->read_data(card); } + trace_sdbus_read(sdbus_name(sdbus), value); =20 - return 0; + return value; } =20 bool sdbus_data_ready(SDBus *sdbus) diff --git a/hw/sd/trace-events b/hw/sd/trace-events index 78d8707669..ea2746c8b7 100644 --- a/hw/sd/trace-events +++ b/hw/sd/trace-events @@ -1,5 +1,10 @@ # See docs/devel/tracing.txt for syntax documentation. =20 +# hw/sd/core.c +sdbus_command(const char *bus_name, uint8_t cmd, uint32_t arg, uint8_t crc= ) "@%s CMD%02d arg 0x%08x crc 0x%02x" +sdbus_read(const char *bus_name, uint8_t value) "@%s value 0x%02x" +sdbus_write(const char *bus_name, uint8_t value) "@%s value 0x%02x" + # hw/sd/sdhci.c sdhci_set_inserted(const char *level) "card state changed: %s" sdhci_send_command(uint8_t cmd, uint32_t arg) "CMD%02u ARG[0x%08x]" --=20 2.16.1