From nobody Mon Feb 9 23:59:40 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of _spf.google.com designates 209.85.216.195 as permitted sender) client-ip=209.85.216.195; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-qt0-f195.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of _spf.google.com designates 209.85.216.195 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-qt0-f195.google.com (mail-qt0-f195.google.com [209.85.216.195]) by mx.zohomail.com with SMTPS id 1518494903573382.36786250164164; Mon, 12 Feb 2018 20:08:23 -0800 (PST) Received: by mail-qt0-f195.google.com with SMTP id u6so2205734qtg.13 for ; Mon, 12 Feb 2018 20:08:23 -0800 (PST) Return-Path: Return-Path: Received: from x1.local ([138.117.48.219]) by smtp.gmail.com with ESMTPSA id q2sm7350435qki.10.2018.02.12.20.08.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Feb 2018 20:08:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=G+Gj0c1bHU3235KQlhOJsjI7crhWaUKbayXI0IA3zKE=; b=NSuoJGEBtFA6bqkyLj83wgt6YahcanX4yUXXcqBrDntVVVnNgMZN4GgpFgkFUNSWYE ndGG2goPH7kXs6oW70rIpGVo51AK6n/zAidC2jpEUvVloxoiYE2PzKo9+Ge4r0t23YgO 7FwoF1I0S2/TJdjyNXQmLX34osjhAXf2BxeOxAbvmdyqRbjTZIiyCu4/vjigRUyb+u9m Z4QwBM3ev3yzgL3zrbAd4kourUfa0YwQ8JSEDUsXucEB6dQDnk+KsVvG4jopx0+tZz0u RqSmGCbXyHqSgJbr5TiCawFW6dq63mjmszGyK5tB6gmotc+7LJ3u+vX5suoXx02mEorL ny9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=G+Gj0c1bHU3235KQlhOJsjI7crhWaUKbayXI0IA3zKE=; b=aDYeRr02y9+J7GdhjmqI1e9/6gNMMw7/pok2z359NqZnQC11gnbB3eh6TSU5vjzxzP x39PJvflXNNypDV8Hc0CXxrqzDfe/amZgPrc90AknrTPOWLAiUTS1uOkW+UjbY2Pkffo iZHKKmt1VaOswpSXKioHbS0X/7RqFSIdppJsNPe543bgKXFCT6nvhs5HLVG313JWJt0t 9nd+B0JOrQxmEHhxPb7f7V12ggDPBO8K4x02npE/HOvI5bs8ueOzD8LPuzBImprplNRD m0fP5DWkMFoQRhZ8DEC5lJ4t4BrsQwV3pwKgvDzRhO3sizxGMS8DzvXFUGoqgE9tODld bBAA== X-Gm-Message-State: APf1xPDcyHvo/AUY3oaq2g9eD7Rhy08Kaz7ihnaqCBdbdHykOVV3CfFg CPrDz7uVIS8MGxo0ZuJW6+I= X-Google-Smtp-Source: AH8x225k3EpvXdpER10MSkXUJ4LHAeZ9I6aSOrZLI+/tgyk0cojcNWo3cCaUeYynn9kl/ggO63agtQ== X-Received: by 10.237.63.28 with SMTP id p28mr20808781qtf.104.1518494902581; Mon, 12 Feb 2018 20:08:22 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Paolo Bonzini Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org, Peter Maydell , Alistair Francis , "Edgar E . Iglesias" , Fam Zheng Subject: [PATCH v13 01/30] sdhci: use error_propagate(local_err) in realize() Date: Tue, 13 Feb 2018 01:07:40 -0300 Message-Id: <20180213040809.26021-2-f4bug@amsat.org> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180213040809.26021-1-f4bug@amsat.org> References: <20180213040809.26021-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZohoMail: RDKM_0 RSF_0 Z_629925259 SPT_0 avoid the "errp && *errp" pattern (not recommended in "qapi/error.h" commen= ts). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis --- hw/sd/sdhci.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c index ee95e78aeb..3602286f46 100644 --- a/hw/sd/sdhci.c +++ b/hw/sd/sdhci.c @@ -1302,10 +1302,12 @@ static Property sdhci_pci_properties[] =3D { static void sdhci_pci_realize(PCIDevice *dev, Error **errp) { SDHCIState *s =3D PCI_SDHCI(dev); + Error *local_err =3D NULL; =20 sdhci_initfn(s); sdhci_common_realize(s, errp); - if (errp && *errp) { + if (local_err) { + error_propagate(errp, local_err); return; } =20 @@ -1383,9 +1385,11 @@ static void sdhci_sysbus_realize(DeviceState *dev, E= rror ** errp) { SDHCIState *s =3D SYSBUS_SDHCI(dev); SysBusDevice *sbd =3D SYS_BUS_DEVICE(dev); + Error *local_err =3D NULL; =20 sdhci_common_realize(s, errp); - if (errp && *errp) { + if (local_err) { + error_propagate(errp, local_err); return; } =20 --=20 2.16.1