From nobody Tue Feb 10 07:22:34 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of _spf.google.com designates 209.85.220.195 as permitted sender) client-ip=209.85.220.195; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-qk0-f195.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of _spf.google.com designates 209.85.220.195 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-qk0-f195.google.com (mail-qk0-f195.google.com [209.85.220.195]) by mx.zohomail.com with SMTPS id 1518494937434808.0150561204465; Mon, 12 Feb 2018 20:08:57 -0800 (PST) Received: by mail-qk0-f195.google.com with SMTP id g2so30099qkd.12 for ; Mon, 12 Feb 2018 20:08:57 -0800 (PST) Return-Path: Return-Path: Received: from x1.local ([138.117.48.219]) by smtp.gmail.com with ESMTPSA id q2sm7350435qki.10.2018.02.12.20.08.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Feb 2018 20:08:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=F3DsUrUkNz1+Uljbpcv+JWr3tF9Rh1qgAvwGmJqEQRU=; b=PNYGDj9qlQ/go2Khc7ShJFUaA/xZJTroXr0RymehnFpSnsyhCOoa5DyJ7SdRcrriFC p/zObi9h3piC6yS4VVn5fF6uu1uQisL6LF87wbeDYdPnX4Ep3NmRy0H72QuxOhrLuo8g q1xdaqSliALZVxm6KyLwU+NaZbQeG6aUkeWLoe/1qlzhf9Ac4j9f05F5JaGmjT13xRKr 7Dz/PK04pgYpYOWkdrG2BZL4NyVghrhwGa05il461pGBfx5TDss/rXbGqeD4nR7QfUlN lw6Cy/j1Mrj4n6IpIXhIAVmfhjJXCgRDk5n66zw0Y5HL7wlgkyIsd+Pmg+nnDZDacmNW beYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=F3DsUrUkNz1+Uljbpcv+JWr3tF9Rh1qgAvwGmJqEQRU=; b=PN4lqG9Dg/vf9iXZaDsyy72wrtwe8S86ZALxXig40sW6y7lp4zzoJbM2m/tHCqBjP8 JlMT+7skGtGHPfQy6b5lwaSdf/H6RpeiMN33Lf249p89Z+HMP0saWqTScprWmXwWQUoU A7QQRuGsJiVD5dgQszeCgpNsis7e5Xp1T5Hw61LxlvrvEoKF7iqwwdUgbXKMsVoOrQWg WPdqeW+pdrTqWcFFTATsJ21L/CyXkS5pt9IJymhnoEMYSKiNmdCSmy1eXKNYoKraTN1w /OE4tfy+yxfQ3UVxtP8z9HFOZT4+L9bGW6piy3fa6xgkmp8j8hKZmGWUtdH14kRQ/zd2 ONvA== X-Gm-Message-State: APf1xPBMltcp2TaLCoeEU/BurRBPiYZSaL6BLlMuGbIJXdrjo8EmtFtV dnZpKAMcXZeqANMW23sxNBy0vFnF X-Google-Smtp-Source: AH8x227M4uxiyUGuvzg3k+9mj8yo1zhRisUkuTiuNcrWApX1HOGuzdmiXtnowUIrHuuNoDffpREB9Q== X-Received: by 10.55.21.158 with SMTP id 30mr11370470qkv.1.1518494936605; Mon, 12 Feb 2018 20:08:56 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Paolo Bonzini Cc: Sai Pavan Boddu , qemu-devel@nongnu.org, Peter Maydell , Alistair Francis , "Edgar E . Iglesias" , Fam Zheng Subject: [PATCH v13 12/30] sdhci: Fix 64-bit ADMA2 Date: Tue, 13 Feb 2018 01:07:51 -0300 Message-Id: <20180213040809.26021-13-f4bug@amsat.org> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180213040809.26021-1-f4bug@amsat.org> References: <20180213040809.26021-1-f4bug@amsat.org> X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZohoMail: RDKM_0 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Sai Pavan Boddu The 64-bit ADMA address is not converted to the cpu endianes correctly. This patch fixes the issue and uses a valid mask for the attribute data. Signed-off-by: Sai Pavan Boddu [AF: Re-write commit message] Reviewed-by: Alistair Francis --- hw/sd/sdhci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c index 650265a472..4bd35078a9 100644 --- a/hw/sd/sdhci.c +++ b/hw/sd/sdhci.c @@ -667,8 +667,8 @@ static void get_adma_description(SDHCIState *s, ADMADes= cr *dscr) dscr->length =3D le16_to_cpu(dscr->length); dma_memory_read(s->dma_as, entry_addr + 4, (uint8_t *)(&dscr->addr), 8); - dscr->attr =3D le64_to_cpu(dscr->attr); - dscr->attr &=3D 0xfffffff8; + dscr->addr =3D le64_to_cpu(dscr->addr); + dscr->attr &=3D (uint8_t) ~0xC0; dscr->incr =3D 12; break; } --=20 2.16.1