From nobody Mon Feb 9 15:10:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1518450240966357.09606330010115; Mon, 12 Feb 2018 07:44:00 -0800 (PST) Received: from localhost ([::1]:45564 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1elGGt-0007gt-Vu for importer@patchew.org; Mon, 12 Feb 2018 10:44:00 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55513) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1elGBF-0003B7-8g for qemu-devel@nongnu.org; Mon, 12 Feb 2018 10:38:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1elGBD-0003gK-0A for qemu-devel@nongnu.org; Mon, 12 Feb 2018 10:38:09 -0500 Received: from mail-by2nam01on0040.outbound.protection.outlook.com ([104.47.34.40]:4832 helo=NAM01-BY2-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1elGBC-0003cq-M9 for qemu-devel@nongnu.org; Mon, 12 Feb 2018 10:38:06 -0500 Received: from wsp141597wss.amd.com (165.204.78.1) by BY2PR12MB0146.namprd12.prod.outlook.com (10.162.82.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.485.10; Mon, 12 Feb 2018 15:38:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=5iw+hA4kg+6nyEafPzCeaA4idfI5Pv5BrHdcCDI+njw=; b=SDazyOIPae33O8k7IEigJXSOAt9+Jq7I9+3h3UetznrjXw48g1kF9wQKw/Gr8HbMaItOPOEWI71wgGhqMfZMR+Ilvr7u/ZKcl+vqJxMm/coWMFiy8fDLVEPxQuM472bKnKxHVMFYYAFGOVzdfLIVpfAPS1+5TP8YfGWuTcSHGXw= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; From: Brijesh Singh To: qemu-devel@nongnu.org Date: Mon, 12 Feb 2018 09:36:49 -0600 Message-Id: <20180212153715.87555-3-brijesh.singh@amd.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180212153715.87555-1-brijesh.singh@amd.com> References: <20180212153715.87555-1-brijesh.singh@amd.com> MIME-Version: 1.0 X-Originating-IP: [165.204.78.1] X-ClientProxiedBy: SN4PR0801CA0004.namprd08.prod.outlook.com (10.161.215.142) To BY2PR12MB0146.namprd12.prod.outlook.com (10.162.82.19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 30395b61-88fd-4add-bfc0-08d5722e9af1 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:BY2PR12MB0146; X-Microsoft-Exchange-Diagnostics: 1; BY2PR12MB0146; 3:Y//EKXLfmjvQZbL+ATJOF3IzwqrC8h3W6KDvAUqqTavDe01SnlunzTrDEyzzLQk5zoVSw/k6KxyU3MMl6DnAoXzZ69Q8tFc6yL1JzIUqDWKWceIzMJHbzOsvvsdBCvdONYvovTPwCse7Z00q9+Ww6BxZ/V6NVarMpBgbBcie1SmP/vovl3JaTz5uSDgv3+/chQkQw606gX7FVUdgV3L14m8kBWiInMWV5zYtbeLzrORKW052BkFIkUnE67UszQx0; 25:Wh7DgGoWiQuTRDpgkb5xKALEHmyt+GLN7nm01tvnlQReRUA8NJmJ5exqOWBzeLhT+lqfv/bTfeFAL1YUK1qTcRV4IragToCZzsbdWcaK5EWsVaK57SmkJTDmuUmQ9h6hOiRy2mm5h9CU3C8jgbMjFcYL9oxCnrkMRcIU91LpiBlR0NwtvYW9cFOt57EHHgvbnB00qFB4zm+SH2qEAe2QDlNvfewne9nrsnb7LGyn1CW8guRr3p7L71u8AhdLYROSxU3vUwfn74CaBySINA6zKQpmQqISqAy+fU6iaqqXh+ZiwQYR75KhIdaqNg8DmW5RoUUDZkI4IqD82tqMg7u1iQ==; 31:3A7hiWT+02RYeINUz0yKi1ZKhuokfzwE4XxjsOks83J/oXIrw+jQPAN429iZG9KsJY6V5R84FUU3jRzTPVo5tlfyzefEerCmweMBTJbiWVxlM11BKQJeSkMk8Ika1Bf+6bUjtPvlOnDICQCsBA9/O+CTlN8esnCGI0Iqa2CREBLxdykKJ//JzGrMxgf1zRG+kNKA7ZYb+qvoiupVF+u04I7wm/7bjpXvEMnbJjKMJp4= X-MS-TrafficTypeDiagnostic: BY2PR12MB0146: X-Microsoft-Exchange-Diagnostics: 1; BY2PR12MB0146; 20:YVh6Kv8LBtKbmDWmaRk2tZNERJKj3empTcrGBdUi5Im03ILBVmul4xDDmvvUlc4Mhy1g5TMmRtaDeJ8dsgcMQ0H0+dIrwcjzfvATk9NHVdPfASzmpMV0x4ChwDPa3TT6Iw9NTq35Th4jHfyB2WDMy7PRT12ajjSIxP1P+pDEg3AUocTXCAw0zkofr0Lys0jPGGSH2olDtLch5jIsOB0e+5SEd9JdJYTxgEtrLd48CDup0dUJmlkLc9XGimiNUG7RpDjMCBVsrqC/bwliRFVCSdhVzHvky4y51jDOsarzGhCIPnONDnV4KNGOvLO29ipNgSgKdebSYKWODBtL4eteb8/1pH+pkSNRM/Etlq0Y/ZNwCRfL26BT+oEJ6jGkN5SP2KpWTdCWNFmt3qZQkalpD7CpM82J/Q/bSvD9NklDGPM2TjKAtKc5U95RpshRc1XXrZOzeJgTpKiNqONCRtichxJWF08SoXmAty2DgKmTzRsH06eSwzm0YPrSVE44Yish; 4:y+SA381HRO2ia896Cb6TmAkA9G9lN2INLDHZ5mOAOzsRVVDuJPDAVo/qoQBZSXTHINf+bzfeOKua0fmb4vC5R46x3uypvq2u6SMAaRzIMzRHG5eJCtf7j7hb/Y5Z6OCL1wR4uWx0dU1SMfjWwLlxvzlw3EgfmyvRy312k56UN+IpkWCjqrZd99StWmH5xObCjkxo93NjsT2NNhSgKkLvEBpZ1plTEvmw+BvWqspsCzJMRbBn4Oqdn7hkkXefRu8gq4UXpyu20U7qazui22lbXsz0PrimWPtimet8UJox6GOh64pUNlEHeIUAOLHViPYII4BfE5UsSjW0vz+64z8J8Q== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(85827821059158)(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3002001)(3231101)(2400082)(944501161)(6055026)(6041288)(20161123564045)(20161123558120)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(6072148)(201708071742011); SRVR:BY2PR12MB0146; BCL:0; PCL:0; RULEID:; SRVR:BY2PR12MB0146; X-Forefront-PRVS: 0581B5AB35 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39380400002)(39860400002)(346002)(396003)(366004)(376002)(199004)(189003)(25786009)(53416004)(66066001)(8676002)(7416002)(105586002)(59450400001)(81156014)(76176011)(81166006)(5660300001)(97736004)(186003)(16526019)(8936002)(106356001)(50226002)(2361001)(6116002)(3846002)(47776003)(305945005)(1076002)(86362001)(26005)(2351001)(7736002)(478600001)(51416003)(36756003)(4326008)(2906002)(53936002)(6666003)(2950100002)(8656006)(52116002)(6486002)(48376002)(39060400002)(68736007)(54906003)(16586007)(7696005)(386003)(316002)(6916009)(50466002)(8666007); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR12MB0146; H:wsp141597wss.amd.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BY2PR12MB0146; 23:nQkFXiQlDnXElmn1g13q/jvpnnmbqwArEiJbIm5rS?= =?us-ascii?Q?oH4DJNxg+Bz8iqRBUVR3fV/drR1eKwiEVQa4BmlScay5xfqVm+qfUs1Zf2a6?= =?us-ascii?Q?6LLa0bdssEVdjZVHnmPGccob6QDJ/09wf6jiTvr9J7GrK7FH7a9SA38GHd6I?= =?us-ascii?Q?zc4yaZ29p1RJDiwQuAwiG4O+JlICSTA5E9RN44Da3i6XeXTRpEGRQcevc76d?= =?us-ascii?Q?ES57PfhQjRKbYJsihC7AS2S5OV6V3dIKq5j/hvJ5onoF1vHMWK3amRC5Uaza?= =?us-ascii?Q?tc5GgkAQ69USEk+aurjuEoyV1b40f4sdea7Qz0mbKfl21wL3GN5Rww/qfhpV?= =?us-ascii?Q?TniZEEoFNcdISMYsOfeaWIzHItZdhoiLfsieyIzTIUKNnMk9z76YvOVhJ72J?= =?us-ascii?Q?4ylBRuLkT5nI+EKL/8rURCW5tmazZb0QDrWyivZLM1QXuBqw8Xh8I31gcP4a?= =?us-ascii?Q?B9JHEFoaSnmd+vpzkBm6d+5mhoFBefT3xfNNdLTrINthpGx0Ude7ba9lDZBb?= =?us-ascii?Q?VTODJtFAiEIBIljgrKrc+iuR0JGY2XNMcoNhb4H3jlofQF/J+hfqIHzzze0T?= =?us-ascii?Q?FnqfdexrXuugWSvcoc3ncWF9J/r8flTa0Y++fFOJ5lv9UW4dqMvVvLIZL7Ne?= =?us-ascii?Q?LfWemZFirPpFYuBnI963GwKxoDwRLb/4/ggNLvu9sBYKC7HfMh4xpvKqqU99?= =?us-ascii?Q?SjLerpafjPTDmvFanWHAvGyQX1QzkVFltB9gaLte58esntwLb9SGuLd/gfRE?= =?us-ascii?Q?XJ/FkmicfjW8x9aHZBHS5m2TjodaEcduMkoeAqWg0a4zNNJl6XT96AN85Zrk?= =?us-ascii?Q?0YhRiFQTQDUy+fdI0zdPQ3QUCMMReuEVBbmxgIRSXmUbLzVMrT1DnAy0IZyu?= =?us-ascii?Q?gz7w9zqVBMm5sjrOdDJxZCj6BoQqGr3+9lA6VyElWc+VldNc/dcndQwFCHdM?= =?us-ascii?Q?oSUnMI9T+a3jSDKYzdzB+eTsDEq9ouHWOKR930l8yTBze0pxKMVwv69WcPVj?= =?us-ascii?Q?0HB8zFoo3IoPMq/WCWGtF+SKSBnQx+FTl70qSxd+7x81MazSUoiRapvDy7bk?= =?us-ascii?Q?pIxLLKGvgOLphVXLH2vw/taOaxjz8qBgiXm540GvVI1urytCot/OipEBcWwX?= =?us-ascii?Q?FNPLYanRxtDydTJGk7jh53xTb01Q44wjPJ9v6jfx2taS75mcQH26ckvL/ZtN?= =?us-ascii?Q?QVuyn+wZufL2dXs18xro/LA3OEx2IUfX82KNrxL5Mv2UdRsxhTfC+2gaSQzz?= =?us-ascii?Q?mRpo/C/70qhtKW012Iy7NMvWfVEEcuYsW4LxH6ynWHWwAGPWy2KYo06juEW2?= =?us-ascii?B?dz09?= X-Microsoft-Exchange-Diagnostics: 1; BY2PR12MB0146; 6:Jl/VMyga3Y5Pivg0FvQdYHQs34JoHpPtxbCMeMGHhoGGCXfLsA31GGxOUTT3mS1TtaC3JVgkPqHDr/7wTHKLVSG4Vy09DFLiM76UV+L/qXc+qmPik2f2lgF6A0vQJqSbd6grP47suNPkm0jlp9g4p2NjQirtqWUYoeQKHl9yc9J9KqkgWXAYes8bkw+/wpoPw7tUkN1N35bWA2Mk4rauMesDHUXRSnbIj2wfVWTVRf6zCXmKTuJxJaE/mbvpW0jbwFIc3wsy2pwVK2LR1FTUaFvu8wba0X3JMCi+JRrLIC9t1FX3vbzf7pokStcP09jk/4Y81BWu6909VECU7CycjryJWaon0BMppw9R6XNlnQ4=; 5:+/NKzZQx6FIsZw4/OEnSF9BAKz41uo3gY7YjyPfmhUMc+1PJXBsVsLq3g5SNm9np8mEfQtSL2QCYeEDQfaZ4jc/kXD6QIu9UtKlhjLOcjs6IT8SEu5pM7LbbFrkaRiOgIpeLM6W5sEITDb55laW6fAj3tb/9CPieag8xLALTeZ8=; 24:X+OjoeAdN4vRvU9CZQSiwwREJvT4eJaQ9WUm4UyuDpD65GJzL+50gHUjazY0E33kDPREbeb7W40vbblXLtysd428AWtDWw2x6nI8uWQKqgA=; 7:Orf6+Y+tNjJAqVyLL5WurFW3pWCyehGDcj0oXZjeADSmufNZ3FHzhUsjB6v8+I9zB/zFf2RM7z3wNf/Xev7wayMCauc+7rSKFQ/CCvHUZpuvLKQAhOJUedXltqz67a0w2t8g5jXAE9ofBLWVvqSsETOYCmCIrbnOusaxyICRJ74DmaPc+0o/pLBxMojGzX/VR50I9g5/pX09F4/1FDfHU9++T2jtZ2CKXBDE5Y0x3RpFWKsRzMDXEZdeUmHOwB9T SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BY2PR12MB0146; 20:R5iXlXl7G5TNVdGgYDQRhlI54ARYWMHALQqyDf5LLhbi8KhbmJ+12kAeVZLh5UEHv5KebjVduKR3EHdvQ1HkZVSNcWrm2StE8cObf9VuGfcpma1PQ3vIRgqBbZ/Z5mfenmRk3ayD2hiaSLSUFMUKzhniDDILqI8xAu3OTUM3GGZMLX9+7yEm52kb2Bfz4Ippdbz7P2H1lX2prJI4/J8S69jIvUzyvXc+3rYQ2shouD+8qgTEgD/wjOOPL26d3amA X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Feb 2018 15:38:02.2016 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 30395b61-88fd-4add-bfc0-08d5722e9af1 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR12MB0146 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 104.47.34.40 Subject: [Qemu-devel] [PATCH v8 02/28] exec: add ram_debug_ops support X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Brijesh Singh , kvm@vger.kernel.org, "Michael S. Tsirkin" , Stefan Hajnoczi , Alexander Graf , "Edgar E. Iglesias" , Markus Armbruster , Bruce Rogers , Christian Borntraeger , Marcel Apfelbaum , Borislav Petkov , Thomas Lendacky , Eduardo Habkost , Richard Henderson , "Dr. David Alan Gilbert" , Alistair Francis , Cornelia Huck , Richard Henderson , Peter Crosthwaite , Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Currently, the guest memory access for the debug purpose is performed using the memcpy(). Lets extend the 'struct MemoryRegion' to include ram_debug_ops callbacks. The ram_debug_ops can be used to override memcpy() with something else. The feature can be used by encrypted guest -- which can register callbacks to override memcpy() with memory encryption/decryption APIs. a typical usage: mem_read(uint8_t *dst, uint8_t *src, uint32_t len, MemTxAttrs *attrs); mem_write(uint8_t *dst, uint8_t *src, uint32_t len, MemTxAttrs *attrs); MemoryRegionRAMReadWriteOps ops; ops.read =3D mem_read; ops.write =3D mem_write; memory_region_init_ram(mem, NULL, "memory", size, NULL); memory_region_set_ram_debug_ops(mem, ops); Cc: Paolo Bonzini Cc: Peter Crosthwaite Cc: Richard Henderson Signed-off-by: Brijesh Singh --- exec.c | 43 ++++++++++++++++++++++++++++++++----------- include/exec/memory.h | 30 +++++++++++++++++++++++++++++- 2 files changed, 61 insertions(+), 12 deletions(-) diff --git a/exec.c b/exec.c index e8d7b335b601..b1366f85b07b 100644 --- a/exec.c +++ b/exec.c @@ -3050,7 +3050,11 @@ static MemTxResult flatview_write_continue(FlatView = *fv, hwaddr addr, } else { /* RAM case */ ptr =3D qemu_ram_ptr_length(mr->ram_block, addr1, &l, false); - memcpy(ptr, buf, l); + if (attrs.debug && mr->ram_debug_ops) { + mr->ram_debug_ops->write(ptr, buf, l, attrs); + } else { + memcpy(ptr, buf, l); + } invalidate_and_set_dirty(mr, addr1, l); } =20 @@ -3148,7 +3152,11 @@ MemTxResult flatview_read_continue(FlatView *fv, hwa= ddr addr, } else { /* RAM case */ ptr =3D qemu_ram_ptr_length(mr->ram_block, addr1, &l, false); - memcpy(buf, ptr, l); + if (attrs.debug && mr->ram_debug_ops) { + mr->ram_debug_ops->read(buf, ptr, l, attrs); + } else { + memcpy(buf, ptr, l); + } } =20 if (release_lock) { @@ -3222,7 +3230,8 @@ enum write_rom_type { }; =20 static inline void cpu_physical_memory_write_rom_internal(AddressSpace *as, - hwaddr addr, const uint8_t *buf, int len, enum write_rom_type type) + hwaddr addr, const uint8_t *buf, int len, MemTxAttrs attrs, + enum write_rom_type type) { hwaddr l; uint8_t *ptr; @@ -3242,7 +3251,11 @@ static inline void cpu_physical_memory_write_rom_int= ernal(AddressSpace *as, ptr =3D qemu_map_ram_ptr(mr->ram_block, addr1); switch (type) { case WRITE_DATA: - memcpy(ptr, buf, l); + if (mr->ram_debug_ops) { + mr->ram_debug_ops->write(ptr, buf, l, attrs); + } else { + memcpy(ptr, buf, l); + } invalidate_and_set_dirty(mr, addr1, l); break; case FLUSH_CACHE: @@ -3261,7 +3274,9 @@ static inline void cpu_physical_memory_write_rom_inte= rnal(AddressSpace *as, void cpu_physical_memory_write_rom(AddressSpace *as, hwaddr addr, const uint8_t *buf, int len) { - cpu_physical_memory_write_rom_internal(as, addr, buf, len, WRITE_DATA); + cpu_physical_memory_write_rom_internal(as, addr, buf, len, + MEMTXATTRS_UNSPECIFIED, + WRITE_DATA); } =20 void cpu_flush_icache_range(hwaddr start, int len) @@ -3276,8 +3291,9 @@ void cpu_flush_icache_range(hwaddr start, int len) return; } =20 - cpu_physical_memory_write_rom_internal(&address_space_memory, - start, NULL, len, FLUSH_CACHE); + cpu_physical_memory_write_rom_internal(&address_space_memory, start, N= ULL, + len, MEMTXATTRS_UNSPECIFIED, + FLUSH_CACHE); } =20 typedef struct { @@ -3592,6 +3608,10 @@ int cpu_memory_rw_debug(CPUState *cpu, target_ulong = addr, page =3D addr & TARGET_PAGE_MASK; phys_addr =3D cpu_get_phys_page_attrs_debug(cpu, page, &attrs); asidx =3D cpu_asidx_from_attrs(cpu, attrs); + + /* set debug attrs to indicate memory access is from the debugger = */ + attrs.debug =3D 1; + /* if no physical page mapped, return an error */ if (phys_addr =3D=3D -1) return -1; @@ -3600,13 +3620,14 @@ int cpu_memory_rw_debug(CPUState *cpu, target_ulong= addr, l =3D len; phys_addr +=3D (addr & ~TARGET_PAGE_MASK); if (is_write) { - cpu_physical_memory_write_rom(cpu->cpu_ases[asidx].as, - phys_addr, buf, l); + cpu_physical_memory_write_rom_internal(cpu->cpu_ases[asidx].as, + phys_addr, buf, l, attr= s, + WRITE_DATA); } else { address_space_rw(cpu->cpu_ases[asidx].as, phys_addr, - MEMTXATTRS_UNSPECIFIED, - buf, l, 0); + attrs, buf, l, 0); } + len -=3D l; buf +=3D l; addr +=3D l; diff --git a/include/exec/memory.h b/include/exec/memory.h index 783ef6457003..da96bee723bf 100644 --- a/include/exec/memory.h +++ b/include/exec/memory.h @@ -223,6 +223,18 @@ typedef struct IOMMUMemoryRegionClass { typedef struct CoalescedMemoryRange CoalescedMemoryRange; typedef struct MemoryRegionIoeventfd MemoryRegionIoeventfd; =20 +/* Memory Region RAM debug callback */ +typedef struct MemoryRegionRAMReadWriteOps MemoryRegionRAMReadWriteOps; + +struct MemoryRegionRAMReadWriteOps { + /* Write data into guest memory */ + int (*write) (uint8_t *dest, const uint8_t *src, + uint32_t len, MemTxAttrs attrs); + /* Read data from guest memory */ + int (*read) (uint8_t *dest, const uint8_t *src, + uint32_t len, MemTxAttrs attrs); +}; + struct MemoryRegion { Object parent_obj; =20 @@ -262,6 +274,7 @@ struct MemoryRegion { const char *name; unsigned ioeventfd_nb; MemoryRegionIoeventfd *ioeventfds; + const MemoryRegionRAMReadWriteOps *ram_debug_ops; }; =20 struct IOMMUMemoryRegion { @@ -632,6 +645,21 @@ void memory_region_init_rom_device_nomigrate(MemoryReg= ion *mr, uint64_t size, Error **errp); =20 +/** + * memory_region_set_ram_debug_ops: Set debug access ops for a given memory + * region. + * + * @mr: the #MemoryRegion to be initialized + * @ops: a function that will be used for when accessing @target region du= ring + * debug + */ +static inline void +memory_region_set_ram_debug_ops(MemoryRegion *mr, + const MemoryRegionRAMReadWriteOps *ops) +{ + mr->ram_debug_ops =3D ops; +} + /** * memory_region_init_reservation: Initialize a memory region that reserves * I/O space. @@ -1944,7 +1972,7 @@ MemTxResult flatview_read(FlatView *fv, hwaddr addr, = MemTxAttrs attrs, void *ptr; MemoryRegion *mr; =20 - if (__builtin_constant_p(len)) { + if (__builtin_constant_p(len) && !attrs.debug) { if (len) { rcu_read_lock(); l =3D len; --=20 2.14.3