From nobody Tue Feb 10 15:29:16 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1518188684197518.5319340887153; Fri, 9 Feb 2018 07:04:44 -0800 (PST) Received: from localhost ([::1]:60272 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ekAEB-0000xr-QO for importer@patchew.org; Fri, 09 Feb 2018 10:04:39 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34171) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ekA5P-0002Pu-U8 for qemu-devel@nongnu.org; Fri, 09 Feb 2018 09:55:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ekA5P-0005fX-2W for qemu-devel@nongnu.org; Fri, 09 Feb 2018 09:55:35 -0500 Received: from mail-qt0-x243.google.com ([2607:f8b0:400d:c0d::243]:35349) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ekA5O-0005fG-Uc for qemu-devel@nongnu.org; Fri, 09 Feb 2018 09:55:35 -0500 Received: by mail-qt0-x243.google.com with SMTP id g14so10841717qti.2 for ; Fri, 09 Feb 2018 06:55:34 -0800 (PST) Received: from x1.local ([138.117.48.219]) by smtp.gmail.com with ESMTPSA id b29sm747841qkb.28.2018.02.09.06.55.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 09 Feb 2018 06:55:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PRVVrWr1dkuT1tVe6teh0w/edU9ae96q3kRiLd5UG5I=; b=bLlj6hOoxCQ7LznnmMUU4hsBl/yLuekC0s8khpxKGSChgaUCWeJwwsgOMszrho9Yad g2U30GQ1cbB0yLpbPpMEqp++FUCaGLd7f1wixg6kWM+f7RywHOWOBlV72m6eZuzU0t6X P+otuQZT6y17Kcz/4lOBUjkgMOL75FutAQ0asLoJ9WpRx6HTWwJ6Yk5AmLu0ZFXdERX9 bakhRjcv8H66xUe0kC1lOm3lEwO4O33/Q1HvL2H5M0sfFHSua44cKdP2UaC4LfExvMH/ NyXnu7qZb2Jpl2zjW4ovFUNa68+RWKkcsqiZTEnGZoG1iH0f+hsFk6T1B5l+ZUiVONhM MvLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=PRVVrWr1dkuT1tVe6teh0w/edU9ae96q3kRiLd5UG5I=; b=gSKN5Vbhm3EakjS6ung+OzVMYSRszMS2bmBDrvDWEatCIzyOdG98fmnbp6IwqC6VCj kiO+YJPmHvT+iVpUJAbKnzCWyEUKMTg0Je3KCu7ANVVSeI1ah389THsxE4kd3BvM5hln Ij+/Qs9Ztst+uxzqIP/EP1HGdD3rPrAOJdywsUwAOaEREhcquGpQPTX3YdKu/4yXv8yn tJu6jMlg+wQ7WARP56npbtG3qQZUDoTsU+GHjv1ZMZ9pWhSTeEYwyIOqWRLJ6DOInOMw 1JmyAhNqfSYe0Er+6CtECUSVn4jBrugQFV2Z8jpJWYD87ZiSFX508S5rGlddWzDtohyD 0Pbw== X-Gm-Message-State: APf1xPDkVwH4pR98AsaIDkQb5VoWXqSmSbUWUSUxrijVseK2yxDuhVaY APXhwATKIQxHWjdu5Ns/T+M= X-Google-Smtp-Source: AH8x226os5ydsv+DPUmxwD9JL6qRbDguLPkxtYEMaGhRFVf3zDTH36gbJQ48sTKN0gFxAltwKAWMhw== X-Received: by 10.237.52.70 with SMTP id w64mr4901812qtd.152.1518188134419; Fri, 09 Feb 2018 06:55:34 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Paolo Bonzini Date: Fri, 9 Feb 2018 11:54:20 -0300 Message-Id: <20180209145430.26007-21-f4bug@amsat.org> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180209145430.26007-1-f4bug@amsat.org> References: <20180209145430.26007-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::243 Subject: [Qemu-devel] [PATCH v12 20/30] sdbus: add trace events X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Edgar E . Iglesias" , Peter Maydell , Alistair Francis , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis --- hw/sd/core.c | 14 ++++++++++++-- hw/sd/trace-events | 5 +++++ 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/hw/sd/core.c b/hw/sd/core.c index 295dc44ab7..498284f109 100644 --- a/hw/sd/core.c +++ b/hw/sd/core.c @@ -23,6 +23,12 @@ #include "hw/qdev-core.h" #include "sysemu/block-backend.h" #include "hw/sd/sd.h" +#include "trace.h" + +static inline const char *sdbus_name(SDBus *sdbus) +{ + return sdbus->qbus.name; +} =20 static SDState *get_card(SDBus *sdbus) { @@ -39,6 +45,7 @@ int sdbus_do_command(SDBus *sdbus, SDRequest *req, uint8_= t *response) { SDState *card =3D get_card(sdbus); =20 + trace_sdbus_command(sdbus_name(sdbus), req->cmd, req->arg, req->crc); if (card) { SDCardClass *sc =3D SD_CARD_GET_CLASS(card); =20 @@ -52,6 +59,7 @@ void sdbus_write_data(SDBus *sdbus, uint8_t value) { SDState *card =3D get_card(sdbus); =20 + trace_sdbus_write(sdbus_name(sdbus), value); if (card) { SDCardClass *sc =3D SD_CARD_GET_CLASS(card); =20 @@ -62,14 +70,16 @@ void sdbus_write_data(SDBus *sdbus, uint8_t value) uint8_t sdbus_read_data(SDBus *sdbus) { SDState *card =3D get_card(sdbus); + uint8_t value =3D 0; =20 if (card) { SDCardClass *sc =3D SD_CARD_GET_CLASS(card); =20 - return sc->read_data(card); + value =3D sc->read_data(card); } + trace_sdbus_read(sdbus_name(sdbus), value); =20 - return 0; + return value; } =20 bool sdbus_data_ready(SDBus *sdbus) diff --git a/hw/sd/trace-events b/hw/sd/trace-events index 78d8707669..ea2746c8b7 100644 --- a/hw/sd/trace-events +++ b/hw/sd/trace-events @@ -1,5 +1,10 @@ # See docs/devel/tracing.txt for syntax documentation. =20 +# hw/sd/core.c +sdbus_command(const char *bus_name, uint8_t cmd, uint32_t arg, uint8_t crc= ) "@%s CMD%02d arg 0x%08x crc 0x%02x" +sdbus_read(const char *bus_name, uint8_t value) "@%s value 0x%02x" +sdbus_write(const char *bus_name, uint8_t value) "@%s value 0x%02x" + # hw/sd/sdhci.c sdhci_set_inserted(const char *level) "card state changed: %s" sdhci_send_command(uint8_t cmd, uint32_t arg) "CMD%02u ARG[0x%08x]" --=20 2.16.1