From nobody Tue Feb 10 15:29:25 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1518189327484841.6100015553139; Fri, 9 Feb 2018 07:15:27 -0800 (PST) Received: from localhost ([::1]:60432 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ekAOc-0001ue-GN for importer@patchew.org; Fri, 09 Feb 2018 10:15:26 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34124) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ekA5L-0002LL-Qq for qemu-devel@nongnu.org; Fri, 09 Feb 2018 09:55:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ekA5H-0005ac-2c for qemu-devel@nongnu.org; Fri, 09 Feb 2018 09:55:31 -0500 Received: from mail-qt0-x243.google.com ([2607:f8b0:400d:c0d::243]:33867) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ekA5G-0005a4-TF for qemu-devel@nongnu.org; Fri, 09 Feb 2018 09:55:26 -0500 Received: by mail-qt0-x243.google.com with SMTP id d14so10836144qtg.1 for ; Fri, 09 Feb 2018 06:55:26 -0800 (PST) Received: from x1.local ([138.117.48.219]) by smtp.gmail.com with ESMTPSA id b29sm747841qkb.28.2018.02.09.06.55.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 09 Feb 2018 06:55:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=uL/ORiM0tTjbREeZZkyqnChgNMxDxFDsIUckKvLN1Qw=; b=p0gRfz7w5S3oojhQBQFGjWNwCp2hVkgcizIGSHwpDH6g3udusZzrdW6FpfPOR731LX JjtXWkNF4sh0kEthN8+3MWNmqqm1w2xTjYXnlWq2H5T4ceu4JyViiILH1BdGrwYDF+Uy i834Ql0gMJiCNwj/sHi1NIx5jnZSRxZ6xGyEgFQm7VsgVqsOqf37Ni7ahcHbnpHE54Cd 8a3xVqfgpVLq5x8uxuj/qQ9TuqU1vcm9kKQHhxEMmrIlLxMgUXQmGUGrovGZnQrs1KEf Jz5+DHXndVvBqzP9O1KChCJzrZUYhft5aqxdwi+Dpj98Xkcop58nXB5nDcIOzQTPtsKW s6GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=uL/ORiM0tTjbREeZZkyqnChgNMxDxFDsIUckKvLN1Qw=; b=svXj+o+7gz9vNaJitIB1v345rHRM+eFqMLdXHANXNeCxuVMZb8ZAlHiZb8QOjSlhp7 jjIgiskMGdtDwLYhTG2Q+Moksp8HnCZlwi1jClCapCO1G6L4Gd+JtWyGdFFjbwLNF/VM 9iqyIeDWY0VHTx5n9Uy+egdF48Z7yknUWzAPKGuUtXCE1p09fD2gJ/XZY0EWLswehwwg za+jJ2E7yxSVB6lVvgiQsoeM8acE2//ZEoN5kxG7jYoxiYkLAZ3SJApkm5m4y6btLHvT omy4h0a2QnfYhnNFMpHLONVr7nre2U77H6V3j6psi6hB+SNqI84MaiqkbBigOes4ht2G OE9Q== X-Gm-Message-State: APf1xPB6mz9Jb3vbvo8A7CyDMNUvQ12yAOn5g/3fBohRhKkiXGGawtWE IEKPIFO0hSnjl+RX/oJY/rGuTKM8 X-Google-Smtp-Source: AH8x224gZVgZG2XyrvL44zWIlPB0+0HIk//EQD5JgNyM8Ep88F+QSnLOmksa9fl73SrbBH2/NwW5ag== X-Received: by 10.237.48.2 with SMTP id 2mr4685129qte.232.1518188126328; Fri, 09 Feb 2018 06:55:26 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Paolo Bonzini Date: Fri, 9 Feb 2018 11:54:17 -0300 Message-Id: <20180209145430.26007-18-f4bug@amsat.org> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180209145430.26007-1-f4bug@amsat.org> References: <20180209145430.26007-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::243 Subject: [Qemu-devel] [PATCH v12 17/30] sdhci: add support for v3 capabilities X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Edgar E . Iglesias" , Peter Maydell , Alistair Francis , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis --- hw/sd/sdhci-internal.h | 13 ++++++++++++ hw/sd/sdhci.c | 54 ++++++++++++++++++++++++++++++++++++++++++++++= ++-- 2 files changed, 65 insertions(+), 2 deletions(-) diff --git a/hw/sd/sdhci-internal.h b/hw/sd/sdhci-internal.h index fe68b21e92..bfb39d614b 100644 --- a/hw/sd/sdhci-internal.h +++ b/hw/sd/sdhci-internal.h @@ -43,6 +43,7 @@ #define SDHC_TRNS_DMA 0x0001 #define SDHC_TRNS_BLK_CNT_EN 0x0002 #define SDHC_TRNS_ACMD12 0x0004 +#define SDHC_TRNS_ACMD23 0x0008 /* since v3 */ #define SDHC_TRNS_READ 0x0010 #define SDHC_TRNS_MULTI 0x0020 #define SDHC_TRNMOD_MASK 0x0037 @@ -194,6 +195,7 @@ FIELD(SDHC_CAPAB, TOCLKFREQ, 0, 6); FIELD(SDHC_CAPAB, TOUNIT, 7, 1); FIELD(SDHC_CAPAB, BASECLKFREQ, 8, 8); FIELD(SDHC_CAPAB, MAXBLOCKLENGTH, 16, 2); +FIELD(SDHC_CAPAB, EMBEDDED_8BIT, 18, 1); /* since v3 */ FIELD(SDHC_CAPAB, ADMA2, 19, 1); /* since v2 */ FIELD(SDHC_CAPAB, ADMA1, 20, 1); /* v1 only? */ FIELD(SDHC_CAPAB, HIGHSPEED, 21, 1); @@ -203,6 +205,17 @@ FIELD(SDHC_CAPAB, V33, 24, 1); FIELD(SDHC_CAPAB, V30, 25, 1); FIELD(SDHC_CAPAB, V18, 26, 1); FIELD(SDHC_CAPAB, BUS64BIT, 28, 1); /* since v2 */ +FIELD(SDHC_CAPAB, ASYNC_INT, 29, 1); /* since v3 */ +FIELD(SDHC_CAPAB, SLOT_TYPE, 30, 2); /* since v3 */ +FIELD(SDHC_CAPAB, BUS_SPEED, 32, 3); /* since v3 */ +FIELD(SDHC_CAPAB, DRIVER_STRENGTH, 36, 3); /* since v3 */ +FIELD(SDHC_CAPAB, DRIVER_TYPE_A, 36, 1); /* since v3 */ +FIELD(SDHC_CAPAB, DRIVER_TYPE_C, 37, 1); /* since v3 */ +FIELD(SDHC_CAPAB, DRIVER_TYPE_D, 38, 1); /* since v3 */ +FIELD(SDHC_CAPAB, TIMER_RETUNING, 40, 4); /* since v3 */ +FIELD(SDHC_CAPAB, SDR50_TUNING, 45, 1); /* since v3 */ +FIELD(SDHC_CAPAB, RETUNING_MODE, 46, 2); /* since v3 */ +FIELD(SDHC_CAPAB, CLOCK_MULT, 48, 8); /* since v3 */ =20 /* HWInit Maximum Current Capabilities Register 0x0 */ #define SDHC_MAXCURR 0x48 diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c index f0b9af4976..0fa58cea84 100644 --- a/hw/sd/sdhci.c +++ b/hw/sd/sdhci.c @@ -70,6 +70,9 @@ static inline unsigned int sdhci_get_fifolen(SDHCIState *= s) static bool sdhci_check_capab_freq_range(SDHCIState *s, const char *desc, uint8_t freq, Error **errp) { + if (s->sd_spec_version >=3D 3) { + return false; + } switch (freq) { case 0: case 10 ... 63: @@ -89,6 +92,50 @@ static void sdhci_check_capareg(SDHCIState *s, Error **e= rrp) bool unit_mhz; =20 switch (s->sd_spec_version) { + case 3: + val =3D FIELD_EX64(s->capareg, SDHC_CAPAB, ASYNC_INT); + trace_sdhci_capareg("async interrupt", val); + msk =3D FIELD_DP64(msk, SDHC_CAPAB, ASYNC_INT, 0); + + val =3D FIELD_EX64(s->capareg, SDHC_CAPAB, SLOT_TYPE); + if (val) { + error_setg(errp, "slot-type not supported"); + return; + } + trace_sdhci_capareg("slot type", val); + msk =3D FIELD_DP64(msk, SDHC_CAPAB, SLOT_TYPE, 0); + + if (val !=3D 0b10) { + val =3D FIELD_EX64(s->capareg, SDHC_CAPAB, EMBEDDED_8BIT); + trace_sdhci_capareg("8-bit bus", val); + } + msk =3D FIELD_DP64(msk, SDHC_CAPAB, EMBEDDED_8BIT, 0); + + val =3D FIELD_EX64(s->capareg, SDHC_CAPAB, BUS_SPEED); + trace_sdhci_capareg("bus speed mask", val); + msk =3D FIELD_DP64(msk, SDHC_CAPAB, BUS_SPEED, 0); + + val =3D FIELD_EX64(s->capareg, SDHC_CAPAB, DRIVER_STRENGTH); + trace_sdhci_capareg("driver strength mask", val); + msk =3D FIELD_DP64(msk, SDHC_CAPAB, DRIVER_STRENGTH, 0); + + val =3D FIELD_EX64(s->capareg, SDHC_CAPAB, TIMER_RETUNING); + trace_sdhci_capareg("timer re-tuning", val); + msk =3D FIELD_DP64(msk, SDHC_CAPAB, TIMER_RETUNING, 0); + + val =3D FIELD_EX64(s->capareg, SDHC_CAPAB, SDR50_TUNING); + trace_sdhci_capareg("use SDR50 tuning", val); + msk =3D FIELD_DP64(msk, SDHC_CAPAB, SDR50_TUNING, 0); + + val =3D FIELD_EX64(s->capareg, SDHC_CAPAB, RETUNING_MODE); + trace_sdhci_capareg("re-tuning mode", val); + msk =3D FIELD_DP64(msk, SDHC_CAPAB, RETUNING_MODE, 0); + + val =3D FIELD_EX64(s->capareg, SDHC_CAPAB, CLOCK_MULT); + trace_sdhci_capareg("clock multiplier", val); + msk =3D FIELD_DP64(msk, SDHC_CAPAB, CLOCK_MULT, 0); + + /* fallback */ case 2: /* default version */ val =3D FIELD_EX64(s->capareg, SDHC_CAPAB, ADMA2); msk =3D FIELD_DP64(msk, SDHC_CAPAB, ADMA2, 0); @@ -1228,8 +1275,11 @@ static void sdhci_init_readonly_registers(SDHCIState= *s, Error **errp) { Error *local_err =3D NULL; =20 - if (s->sd_spec_version !=3D 2) { - error_setg(errp, "Only Spec v2 is supported"); + switch (s->sd_spec_version) { + case 2 ... 3: + break; + default: + error_setg(errp, "Only Spec v2/v3 are supported"); return; } s->version =3D (SDHC_HCVER_VENDOR << 8) | (s->sd_spec_version - 1); --=20 2.16.1