From nobody Tue Feb 10 15:29:24 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1518188433549297.30297463954776; Fri, 9 Feb 2018 07:00:33 -0800 (PST) Received: from localhost ([::1]:60241 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ekAAC-00065A-Lo for importer@patchew.org; Fri, 09 Feb 2018 10:00:32 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33985) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ekA53-00024I-4u for qemu-devel@nongnu.org; Fri, 09 Feb 2018 09:55:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ekA52-0005Og-6L for qemu-devel@nongnu.org; Fri, 09 Feb 2018 09:55:13 -0500 Received: from mail-qk0-x241.google.com ([2607:f8b0:400d:c09::241]:43019) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ekA52-0005OS-22 for qemu-devel@nongnu.org; Fri, 09 Feb 2018 09:55:12 -0500 Received: by mail-qk0-x241.google.com with SMTP id d129so6979048qke.10 for ; Fri, 09 Feb 2018 06:55:11 -0800 (PST) Received: from x1.local ([138.117.48.219]) by smtp.gmail.com with ESMTPSA id b29sm747841qkb.28.2018.02.09.06.55.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 09 Feb 2018 06:55:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=kSxivJpOo+GjEiiXG4H2Phz9DgkkN/1ScOhxKDdWyLo=; b=aGTVW+N3A9YJoBaKk0OJ9G4MiBpSWvkDl3mGZgHM2AdpG0qMGPgjW1zCNARrCuc9LM ixj0T3XWM6lYSoW2a4h2lpMUFlmwivXvVKxOMtzlsDIqCh6iaPoVfjGubjX+RPzDiRn8 JumJtehii5HJtmYFFrtFNkdmFb/WE6nK2Oy/2evfPmcY3K2vNQ75y716MbH6wnF94NFG 4CzsCEKuaJ2fU7HYwEse/9BZ1Tlw6AJF50gBCwRVlcDfcH57/8ilB3oWlbRoussu0xqL vQQfK3Xq+eYQnbnEUeRUxoXJVBRJPO8ZL3CxrKgj0FodF1q3OlPr+3Bd0AF/rYBIhG5g 43sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=kSxivJpOo+GjEiiXG4H2Phz9DgkkN/1ScOhxKDdWyLo=; b=g5T8cU+edVPrUkMaREbUAVWrq52GLYyHo27SA2s8Hwj4leorrs+9Fn5grj0g3ro1Kp s15q0fM9bEdI4G8bMuVhyCaqHMbnev576XwWAcSCRY17GCjQAkgfum7/8zIlnjf+SQXk Q5NJD3+IeF5XzAIGYPBMdECsZzeMrDiM7WslxKOaRAqCxuV+/Up0mdvTBKXzIbEY1iU+ fDgexRa8wGXtkqZFcff9/fAubvjCwkIZrJXXPQaOnYpZW2NKm2n/94nS2kbc33cimD0W Mlf/0awc7WiJbWwb3//kG/Oy+pNE06ZfPk2W4uVOEjCApXEZ/ktoLc2pRBAuhz7vi0wi ScHQ== X-Gm-Message-State: APf1xPDmkmOgTxgIwo357JLXT76Ygs63AnxhbtA/m0O+ycaXYK/GqztD OPGKi84JTzS4YWSz+f3uoJE= X-Google-Smtp-Source: AH8x224CzYR3qrkpALMR+L8MrxD8fCBtzzLYIm/Hdg1ztk4YwmLIJ5M8n0XlurxroILyllOl8Cojcw== X-Received: by 10.55.209.12 with SMTP id s12mr4091246qki.219.1518188111545; Fri, 09 Feb 2018 06:55:11 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Paolo Bonzini Date: Fri, 9 Feb 2018 11:54:12 -0300 Message-Id: <20180209145430.26007-13-f4bug@amsat.org> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180209145430.26007-1-f4bug@amsat.org> References: <20180209145430.26007-1-f4bug@amsat.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::241 Subject: [Qemu-devel] [PATCH v12 12/30] sdhci: Fix 64-bit ADMA2 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sai Pavan Boddu , Peter Maydell , "Edgar E . Iglesias" , qemu-devel@nongnu.org, Alistair Francis Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Sai Pavan Boddu The 64-bit ADMA address is not converted to the cpu endianes correctly. This patch fixes the issue and uses a valid mask for the attribute data. Signed-off-by: Sai Pavan Boddu [AF: Re-write commit message] Reviewed-by: Alistair Francis --- hw/sd/sdhci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c index a563a7c88d..4c8a321942 100644 --- a/hw/sd/sdhci.c +++ b/hw/sd/sdhci.c @@ -668,8 +668,8 @@ static void get_adma_description(SDHCIState *s, ADMADes= cr *dscr) dscr->length =3D le16_to_cpu(dscr->length); dma_memory_read(s->dma_as, entry_addr + 4, (uint8_t *)(&dscr->addr), 8); - dscr->attr =3D le64_to_cpu(dscr->attr); - dscr->attr &=3D 0xfffffff8; + dscr->addr =3D le64_to_cpu(dscr->addr); + dscr->attr &=3D (uint8_t) ~0xC0; dscr->incr =3D 12; break; } --=20 2.16.1