From nobody Tue Feb 10 04:12:56 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1518027724316962.4760321123377; Wed, 7 Feb 2018 10:22:04 -0800 (PST) Received: from localhost ([::1]:42121 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ejULw-0003Aj-Qn for importer@patchew.org; Wed, 07 Feb 2018 13:21:52 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33751) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ejUJp-0001j0-Ko for qemu-devel@nongnu.org; Wed, 07 Feb 2018 13:19:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ejUJo-0004qM-Qe for qemu-devel@nongnu.org; Wed, 07 Feb 2018 13:19:41 -0500 Received: from mail-qk0-x242.google.com ([2607:f8b0:400d:c09::242]:40223) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ejUJo-0004q3-Ms for qemu-devel@nongnu.org; Wed, 07 Feb 2018 13:19:40 -0500 Received: by mail-qk0-x242.google.com with SMTP id e20so2316489qkm.7 for ; Wed, 07 Feb 2018 10:19:40 -0800 (PST) Received: from x1.local ([138.117.48.219]) by smtp.gmail.com with ESMTPSA id f7sm1426248qtm.21.2018.02.07.10.19.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Feb 2018 10:19:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pxzWQFhwWBCzjvVrhx+sd+KGw0B9UoGBPtq/CdVw0Mk=; b=INLmj0FDx9ygkzVg8y/Q5O7qBXR5rAJVCq4e7DNgFBu0lNJTJ4Ioz+tqU8p/4lOGbL hLRiZOCWj2DSREUf3H6dmzzEMc7CNNGC4/RW6pG2+ls/lXxdQZLDrKalIwSNK1EJN2tD p4fAGBcPoNJE8PJ9MXtEQ2kbKzNExbpIXrdoiKjtHEPEdqb1xfqVxyZeDLsp4MD9XvE9 wn7U4zV9xINAfAwYzPAEy+vS9b9hZ8sk3dLow6iap7VEHzkbnb0tlfGiA06nJAZ2oleA Uf7cmbjgxFWZbjEvtraqGOXLMzAdc/BwfVLPa6R+Raq+Kx6hDCDKBhJNL+I1/fQPfGqD x41g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=pxzWQFhwWBCzjvVrhx+sd+KGw0B9UoGBPtq/CdVw0Mk=; b=aixLl+aBM7aHNhPk2q462tUzTaUYo8GmX2fqKvpTkQvJg7xe/fWHauwsn+FGG6iYUo 1jkB8KEDMnVdEhAOhe3p7iUHw23GVD3ZkupNiNjl7oZiGrSJ0FCZps3PObWrkzdGh93F ++AE93KeydCz8orEZKnw5VqjQ7IUkfGGwpdwSDEErWwLlrtTze75VtKBcIANsbQjnvoR 2bCYD6hVgE0Hc26J83alYeeUt+Aj49/UpG/YoSWsiUWJnp1cU9vI/vp8NYIo8mEeD3n4 Wm+mhwc9QTKWFn/vm8pv37RDAEj0uv3pcoqV9f1tJEHeT6GBInWMpLytRKtgFymnz2Bt X47g== X-Gm-Message-State: APf1xPD+AHfp+2FdsnCzTjkuEUCOHEgIPJNUHmulne7qe4yxcpTbChpy NAPYfVhVI2iOUYuZlHzsE7c= X-Google-Smtp-Source: AH8x227Edn1F8TxP+43FFxHx2LFmbzeiJ4rtSJyBkFTnG7OEQ3PcpUMSOmFbP61DBFp2Wut0CTdYkg== X-Received: by 10.55.188.199 with SMTP id m190mr10439089qkf.92.1518027580260; Wed, 07 Feb 2018 10:19:40 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Paolo Bonzini , Stefan Hajnoczi , Peter Maydell Date: Wed, 7 Feb 2018 15:19:14 -0300 Message-Id: <20180207181929.8701-2-f4bug@amsat.org> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180207181929.8701-1-f4bug@amsat.org> References: <20180207181929.8701-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::242 Subject: [Qemu-devel] [PATCH v10 01/16] sdhci: use error_propagate(local_err) in realize() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Edgar E . Iglesias" , Alistair Francis , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 avoid the "errp && *errp" pattern (not recommended in "qapi/error.h" commen= ts). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis --- hw/sd/sdhci.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c index fac7fa5c72..817c2525e6 100644 --- a/hw/sd/sdhci.c +++ b/hw/sd/sdhci.c @@ -1300,10 +1300,12 @@ static Property sdhci_pci_properties[] =3D { static void sdhci_pci_realize(PCIDevice *dev, Error **errp) { SDHCIState *s =3D PCI_SDHCI(dev); + Error *local_err =3D NULL; =20 sdhci_initfn(s); sdhci_common_realize(s, errp); - if (errp && *errp) { + if (local_err) { + error_propagate(errp, local_err); return; } =20 @@ -1381,9 +1383,11 @@ static void sdhci_sysbus_realize(DeviceState *dev, E= rror ** errp) { SDHCIState *s =3D SYSBUS_SDHCI(dev); SysBusDevice *sbd =3D SYS_BUS_DEVICE(dev); + Error *local_err =3D NULL; =20 sdhci_common_realize(s, errp); - if (errp && *errp) { + if (local_err) { + error_propagate(errp, local_err); return; } =20 --=20 2.16.1