From nobody Tue Feb 10 20:28:07 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1516943310308184.62142294307978; Thu, 25 Jan 2018 21:08:30 -0800 (PST) Received: from localhost ([::1]:59226 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eewFZ-0006zP-He for importer@patchew.org; Fri, 26 Jan 2018 00:08:29 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51092) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eewBj-00044j-Ha for qemu-devel@nongnu.org; Fri, 26 Jan 2018 00:04:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eewBf-0000nD-Jg for qemu-devel@nongnu.org; Fri, 26 Jan 2018 00:04:31 -0500 Received: from mail-pf0-x241.google.com ([2607:f8b0:400e:c00::241]:33071) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eewBf-0000mT-Ek for qemu-devel@nongnu.org; Fri, 26 Jan 2018 00:04:27 -0500 Received: by mail-pf0-x241.google.com with SMTP id t5so7513142pfi.0 for ; Thu, 25 Jan 2018 21:04:27 -0800 (PST) Received: from cloudburst.twiddle.net (174-21-6-47.tukw.qwest.net. [174.21.6.47]) by smtp.gmail.com with ESMTPSA id q67sm20460313pfi.164.2018.01.25.20.58.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 25 Jan 2018 20:58:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=XjVnmIXYYCqWv5oZJzuP5GrsrQI8am9qFmO1DlUx/5Y=; b=GnbMeTtY9eOBR+Z56Q7yiaYKHRbvEjwodJ3A9dFeez4dt8VNubEzoVKfsDrN8L+9oq 9f9oLB/3bE+nwhKqkgWQ3RBk8vnVzzZ+ZfL9dLOzgG//D5wwhq9Fa248LpRg+cAiNwPo MkTOcpA1YY9iWb/iaUya9mmqmVw2FWciQyMvM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=XjVnmIXYYCqWv5oZJzuP5GrsrQI8am9qFmO1DlUx/5Y=; b=lrqEqaRl3p4xG9dGqpbtE/YSXJm/YEPE5xrLpVykTbYN4M4osvZI8twYuWF8CiYHbm n/b0QBsPmF3DRE62hejxGzlMIq5hbOE7l0N1Y8D/hhPVwtFFZowMDB0gkQSa32DWTGCG likZG02XwtYF65rKJzHppXgm3a2qS3LlzgHz0nQXHQOCl5QGag80Aca5PSGAg/EsUDkZ qoGIsoRUlUS/qAkrtnDLNLnsGHBg74QWoX9R3VVMggkbCcjtplMvSRj74g1UPeA4ikpW TlTxzgj/a5u7lCuuzk/4bOm3jtyinRLnSh9BY09zbbGRfkUZzQo7F+cOo5oJ65HuEyDI 6ZHA== X-Gm-Message-State: AKwxytf8toSv5lBQ3FN9Bg3nTO2qrO6H56dkJIK1HUokRh6T7LsxPI4e WeZB4Ukd7udDeJcsxdnqsP/jEkBkSKI= X-Google-Smtp-Source: AH8x224J9nYV7TMVsweJCCaYdv6/b3eYhzb1z+WDkyXwXzvoCYZWezxVzEvMIYunXuFD44miCO2vYQ== X-Received: by 10.99.152.10 with SMTP id q10mr6014374pgd.212.1516942703585; Thu, 25 Jan 2018 20:58:23 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Thu, 25 Jan 2018 20:57:40 -0800 Message-Id: <20180126045742.5487-19-richard.henderson@linaro.org> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180126045742.5487-1-richard.henderson@linaro.org> References: <20180126045742.5487-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::241 Subject: [Qemu-devel] [PATCH v11 18/20] target/arm: Use vector infrastructure for aa64 orr/bic immediate X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Reviewed-by: Alex Benn=C3=A9e --- target/arm/translate-a64.c | 28 +++++----------------------- 1 file changed, 5 insertions(+), 23 deletions(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 64a2c2df59..d688a699be 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -6180,7 +6180,6 @@ static void disas_simd_mod_imm(DisasContext *s, uint3= 2_t insn) bool is_neg =3D extract32(insn, 29, 1); bool is_q =3D extract32(insn, 30, 1); uint64_t imm =3D 0; - int i; =20 if (o2 !=3D 0 || ((cmode =3D=3D 0xf) && is_neg && !is_q)) { unallocated_encoding(s); @@ -6266,29 +6265,12 @@ static void disas_simd_mod_imm(DisasContext *s, uin= t32_t insn) tcg_gen_gvec_dup64i(vec_full_reg_offset(s, rd), is_q ? 16 : 8, vec_full_reg_size(s), imm); } else { - TCGv_i64 tcg_imm =3D tcg_const_i64(imm); - TCGv_i64 tcg_rd =3D new_tmp_a64(s); - - for (i =3D 0; i < 2; i++) { - int foffs =3D vec_reg_offset(s, rd, i, MO_64); - - if (i =3D=3D 1 && !is_q) { - /* non-quad ops clear high half of vector */ - tcg_gen_movi_i64(tcg_rd, 0); - } else { - tcg_gen_ld_i64(tcg_rd, cpu_env, foffs); - if (is_neg) { - /* AND (BIC) */ - tcg_gen_and_i64(tcg_rd, tcg_rd, tcg_imm); - } else { - /* ORR */ - tcg_gen_or_i64(tcg_rd, tcg_rd, tcg_imm); - } - } - tcg_gen_st_i64(tcg_rd, cpu_env, foffs); + /* ORR or BIC, with BIC negation to AND handled above. */ + if (is_neg) { + gen_gvec_fn2i(s, is_q, rd, rd, imm, tcg_gen_gvec_andi, MO_64); + } else { + gen_gvec_fn2i(s, is_q, rd, rd, imm, tcg_gen_gvec_ori, MO_64); } - - tcg_temp_free_i64(tcg_imm); } } =20 --=20 2.14.3