From nobody Tue Feb 10 16:22:11 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1516680183423418.48023439380813; Mon, 22 Jan 2018 20:03:03 -0800 (PST) Received: from localhost ([::1]:32794 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1edpnU-0000Zu-4a for importer@patchew.org; Mon, 22 Jan 2018 23:02:56 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44291) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1edpjZ-00067P-QC for qemu-devel@nongnu.org; Mon, 22 Jan 2018 22:58:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1edpjY-0002Mv-OB for qemu-devel@nongnu.org; Mon, 22 Jan 2018 22:58:53 -0500 Received: from mail-qt0-x243.google.com ([2607:f8b0:400d:c0d::243]:41462) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1edpjY-0002MY-Jo for qemu-devel@nongnu.org; Mon, 22 Jan 2018 22:58:52 -0500 Received: by mail-qt0-x243.google.com with SMTP id i1so26584761qtj.8 for ; Mon, 22 Jan 2018 19:58:52 -0800 (PST) Received: from x1.lan ([138.117.48.219]) by smtp.gmail.com with ESMTPSA id n24sm12447530qta.26.2018.01.22.19.58.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Jan 2018 19:58:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hLAFqzKGKy0PDBOWYVCyaGpwZdm+xO4rBJR0rwpMbUA=; b=lvpjHPlPwvsWVzhv6O/Ip26dXgG7LYKbk8LmxIXHm9GTfu5rm3gcFcwGuTZ+6jDKxe Y0sqYJLL178pn2apynG/HQbHxReF6QoNdd+c1ZlxgguJ6oI+gKK5tGw009IV3VbaHkTD n+rqCoBHpvSfqMrOsk8xT2av5wj4FyCNBgLdE1f4DrvvFrbN4/5G1NTYhNaPqMos3DgF Vt6uM83V+GT4uBX6E5WiOxXMf7FzMDU1BOeocXUwINpSUILpncXOUPXZFdlLKsrCEhEP KcwJ9DzIVF7I4BWSwpKJkG5IrC+k0W0gkkxMp+ctJXz/p8EtB/4HAEL4mEWXUszlVWJv Wk0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=hLAFqzKGKy0PDBOWYVCyaGpwZdm+xO4rBJR0rwpMbUA=; b=nElairRN7fLTUe44C6GKxVSOPF0poOyYkEIRH3vy5ylCUn/L5F4m/Z4iwBlGTvjv9f E8eITLkCQaBR2lBHgzstZt71EmHymvErmtARdQDO1i/ii1z1RMzWV7OeIDkDBUbyscJf jz1uKWG6/wnAzlHEGZWdmEDmW1a2qTyxF1Yj7a31ROgjhIpqkyalWSJRxWXe/Y236mmn PfJO7fAPzqDRbHd66QZiiOt8JafKt72t3vQ2dcsuCy1g4bljBJIYe6ZA0dg0bLjKkCSa XopXfOmyp8Yykp8jyFRiJmQhmsjZdo1PBucAtZfTdHSra2hDsmARsqr5ZWkBzLB9i7HW phlQ== X-Gm-Message-State: AKwxytevEajD0cD+6FO90b5M1nU+LoYsjvUEtsksCsglLcwLNjtUm1Zo 26D5vtVsSeEmWPrn/2TcNRk= X-Google-Smtp-Source: AH8x224JIp7UNfFZ2PUBwVO4xLY6DvwWhCYUEeTYTOUixPUaAR+FwqaPc5BUIqmK2qXWotMj8JoRvw== X-Received: by 10.237.61.33 with SMTP id g30mr1784578qtf.82.1516679932066; Mon, 22 Jan 2018 19:58:52 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Alistair Francis , Peter Maydell , Michael Walle Date: Tue, 23 Jan 2018 00:58:34 -0300 Message-Id: <20180123035837.16578-4-f4bug@amsat.org> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20180123035837.16578-1-f4bug@amsat.org> References: <20180123035837.16578-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::243 Subject: [Qemu-devel] [PATCH v2 3/6] hw/sd/milkymist-memcard: expose a SDBus and connect the SDCard to it X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Edgar E . Iglesias" , Stefan Weil , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 using the sdbus_*() API. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Acked-by: Michael Walle Reviewed-by: Alistair Francis --- hw/sd/milkymist-memcard.c | 38 +++++++++++++++++++++----------------- 1 file changed, 21 insertions(+), 17 deletions(-) diff --git a/hw/sd/milkymist-memcard.c b/hw/sd/milkymist-memcard.c index a8e65892c7..5570c1e9a0 100644 --- a/hw/sd/milkymist-memcard.c +++ b/hw/sd/milkymist-memcard.c @@ -69,7 +69,7 @@ struct MilkymistMemcardState { SysBusDevice parent_obj; =20 MemoryRegion regs_region; - SDState *card; + SDBus sdbus; =20 int command_write_ptr; int response_read_ptr; @@ -105,7 +105,7 @@ static void memcard_sd_command(MilkymistMemcardState *s) req.crc =3D s->command[5]; =20 s->response[0] =3D req.cmd; - s->response_len =3D sd_do_command(s->card, &req, s->response+1); + s->response_len =3D sdbus_do_command(&s->sdbus, &req, s->response + 1); s->response_read_ptr =3D 0; =20 if (s->response_len =3D=3D 16) { @@ -150,10 +150,10 @@ static uint64_t memcard_read(void *opaque, hwaddr add= r, r =3D 0xffffffff; } else { r =3D 0; - r |=3D sd_read_data(s->card) << 24; - r |=3D sd_read_data(s->card) << 16; - r |=3D sd_read_data(s->card) << 8; - r |=3D sd_read_data(s->card); + r |=3D sdbus_read_data(&s->sdbus) << 24; + r |=3D sdbus_read_data(&s->sdbus) << 16; + r |=3D sdbus_read_data(&s->sdbus) << 8; + r |=3D sdbus_read_data(&s->sdbus); } break; case R_CLK2XDIV: @@ -207,10 +207,10 @@ static void memcard_write(void *opaque, hwaddr addr, = uint64_t value, if (!s->enabled) { break; } - sd_write_data(s->card, (value >> 24) & 0xff); - sd_write_data(s->card, (value >> 16) & 0xff); - sd_write_data(s->card, (value >> 8) & 0xff); - sd_write_data(s->card, value & 0xff); + sdbus_write_data(&s->sdbus, (value >> 24) & 0xff); + sdbus_write_data(&s->sdbus, (value >> 16) & 0xff); + sdbus_write_data(&s->sdbus, (value >> 8) & 0xff); + sdbus_write_data(&s->sdbus, value & 0xff); break; case R_ENABLE: s->regs[addr] =3D value; @@ -251,10 +251,6 @@ static void milkymist_memcard_reset(DeviceState *d) for (i =3D 0; i < R_MAX; i++) { s->regs[i] =3D 0; } - /* Since we're still using the legacy SD API the card is not plugged - * into any bus, and we must reset it manually. - */ - device_reset(DEVICE(s->card)); } =20 static void milkymist_memcard_init(Object *obj) @@ -270,15 +266,23 @@ static void milkymist_memcard_init(Object *obj) static void milkymist_memcard_realize(DeviceState *dev, Error **errp) { MilkymistMemcardState *s =3D MILKYMIST_MEMCARD(dev); + DeviceState *carddev; BlockBackend *blk; DriveInfo *dinfo; + Error *err =3D NULL; =20 + qbus_create_inplace(&s->sdbus, sizeof(s->sdbus), TYPE_SD_BUS, + dev, "sd-bus"); + + /* Create and plug in the sd card */ /* FIXME use a qdev drive property instead of drive_get_next() */ dinfo =3D drive_get_next(IF_SD); blk =3D dinfo ? blk_by_legacy_dinfo(dinfo) : NULL; - s->card =3D sd_init(blk, false); - if (s->card =3D=3D NULL) { - error_setg(errp, "failed to init SD card"); + carddev =3D qdev_create(&s->sdbus.qbus, TYPE_SD_CARD); + qdev_prop_set_drive(carddev, "drive", blk, &err); + object_property_set_bool(OBJECT(carddev), true, "realized", &err); + if (err) { + error_setg(errp, "failed to init SD card: %s", error_get_pretty(er= r)); return; } s->enabled =3D blk && blk_is_inserted(blk); --=20 2.15.1