From nobody Tue Feb 10 16:22:18 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 151668002144463.801089202607386; Mon, 22 Jan 2018 20:00:21 -0800 (PST) Received: from localhost ([::1]:60973 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1edpky-00071j-Nz for importer@patchew.org; Mon, 22 Jan 2018 23:00:20 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44267) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1edpjU-00061u-DT for qemu-devel@nongnu.org; Mon, 22 Jan 2018 22:58:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1edpjT-0002D7-BK for qemu-devel@nongnu.org; Mon, 22 Jan 2018 22:58:48 -0500 Received: from mail-qt0-x241.google.com ([2607:f8b0:400d:c0d::241]:37145) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1edpjT-0002Cf-6l for qemu-devel@nongnu.org; Mon, 22 Jan 2018 22:58:47 -0500 Received: by mail-qt0-x241.google.com with SMTP id d54so26601839qtd.4 for ; Mon, 22 Jan 2018 19:58:47 -0800 (PST) Received: from x1.lan ([138.117.48.219]) by smtp.gmail.com with ESMTPSA id n24sm12447530qta.26.2018.01.22.19.58.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Jan 2018 19:58:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EhhJSTbQclh/+61+FVA/2iDf9+HEknpkfLt3dEtJRgU=; b=QQHzinbDE/VXbLvUkJTmOvNBAnu2wI1YCUQDc8l1HMTG2pTWWfb3MnJPK0yc22sxwx D+8sBK/vN/vrmhGWd2NJ/1j7qlGDz6Po5VLBfHi8Q/WQlj0ZRRL1xQ5+nK/vdKGU8Yk9 +uI7V//y5A69yhHbOprYhx+VAhJyUOs6ILnR71MnYLFdnlb2N02ijhE0R6Pc8xf/oBgb OeCqRFg7Lca5qlzzDpLyaaPwRUizktKPzo7gby+IbEYMOUwixBLtgE3e1S1ROg2hYT3V Sx0iL0xCEzPToWbJkpc6U19OoLpf2l2nckiQ8RyG1ydajNvIemK6rcNvj6iEzsLIZOa3 RF7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=EhhJSTbQclh/+61+FVA/2iDf9+HEknpkfLt3dEtJRgU=; b=hA3uJQX1bFgqg440LGAc5TeDcSCJKdBJTC7Xd8PTPeTjgirjnJrGu6TC9t6sDb0nLB c5anrYzFs3JqMr+MSkHVNTcK//ZZZpsNEkBIo7F3+YiB9JInUv+9yoZ7xd+7Xj1nOyHN Bkp4iX2SZ7ENRCb8NkJtdXvLh08t4zP99zGPm/4+/Ojf0GaGeeZQGZgFuZ4LZqO+s0ZQ etvjMKbP39ckZGR6IEB3iazZIf04ET4Ves6SIiasBHdQ8XMUcKmsi+Q8OtMvAYKz7dVu TAZSB8FdUjmTjwF9ETNFikhPtkswLm2J1HSF6u7sfm6cR4FhT8zZUds5Vad9nJIyf3Hc R4dw== X-Gm-Message-State: AKwxytcdM54OGP2ZAu+Rgz1Q96kj71z/fX5q8oVe4T5whESpejJZJreG MXCvJnlwl1EtXEkfpZ9ycJk= X-Google-Smtp-Source: AH8x2273mjK4UKRsaTZUAc6WGNlg6uLCr0mpWlTWaxQW0bgg3zVbbaQlurzEnAXtJILz0hhPK+dujg== X-Received: by 10.55.144.2 with SMTP id s2mr1563497qkd.257.1516679926607; Mon, 22 Jan 2018 19:58:46 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Alistair Francis , Peter Maydell , Michael Walle Date: Tue, 23 Jan 2018 00:58:32 -0300 Message-Id: <20180123035837.16578-2-f4bug@amsat.org> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20180123035837.16578-1-f4bug@amsat.org> References: <20180123035837.16578-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::241 Subject: [Qemu-devel] [PATCH v2 1/6] hw/sd/milkymist-memcard: use qemu_log_mask() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Edgar E . Iglesias" , Stefan Weil , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Acked-by: Michael Walle Reviewed-by: Alistair Francis --- hw/sd/milkymist-memcard.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/hw/sd/milkymist-memcard.c b/hw/sd/milkymist-memcard.c index 341da88552..1292c0c099 100644 --- a/hw/sd/milkymist-memcard.c +++ b/hw/sd/milkymist-memcard.c @@ -22,11 +22,12 @@ */ =20 #include "qemu/osdep.h" +#include "qemu/log.h" #include "hw/hw.h" #include "hw/sysbus.h" #include "sysemu/sysemu.h" #include "trace.h" -#include "qemu/error-report.h" +#include "include/qapi/error.h" #include "sysemu/block-backend.h" #include "sysemu/blockdev.h" #include "hw/sd/sd.h" @@ -138,8 +139,8 @@ static uint64_t memcard_read(void *opaque, hwaddr addr, } else { r =3D s->response[s->response_read_ptr++]; if (s->response_read_ptr > s->response_len) { - error_report("milkymist_memcard: " - "read more cmd bytes than available. Clipping."); + qemu_log_mask(LOG_GUEST_ERROR, "milkymist_memcard: " + "read more cmd bytes than available. Clippin= g."); s->response_read_ptr =3D 0; } } @@ -163,8 +164,9 @@ static uint64_t memcard_read(void *opaque, hwaddr addr, break; =20 default: - error_report("milkymist_memcard: read access to unknown register 0= x" - TARGET_FMT_plx, addr << 2); + qemu_log_mask(LOG_UNIMP, "milkymist_memcard: " + "read access to unknown register 0x%" HWADDR_PRIx "\= n", + addr << 2); break; } =20 @@ -220,8 +222,9 @@ static void memcard_write(void *opaque, hwaddr addr, ui= nt64_t value, break; =20 default: - error_report("milkymist_memcard: write access to unknown register = 0x" - TARGET_FMT_plx, addr << 2); + qemu_log_mask(LOG_UNIMP, "milkymist_memcard: " + "write access to unknown register 0x%" HWADDR_PRIx "= " + "(value 0x%" PRIx64 ")\n", addr << 2, value); break; } } --=20 2.15.1