From nobody Tue Feb 10 21:59:50 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1516677126309194.18095993962743; Mon, 22 Jan 2018 19:12:06 -0800 (PST) Received: from localhost ([::1]:58189 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1edp0H-0004Pi-FP for importer@patchew.org; Mon, 22 Jan 2018 22:12:05 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60098) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1edovI-0000jy-Hf for qemu-devel@nongnu.org; Mon, 22 Jan 2018 22:06:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1edovD-0004eT-K0 for qemu-devel@nongnu.org; Mon, 22 Jan 2018 22:06:56 -0500 Received: from mail-qt0-x242.google.com ([2607:f8b0:400d:c0d::242]:44191) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1edovD-0004ds-Fe for qemu-devel@nongnu.org; Mon, 22 Jan 2018 22:06:51 -0500 Received: by mail-qt0-x242.google.com with SMTP id l20so25031132qtj.11 for ; Mon, 22 Jan 2018 19:06:51 -0800 (PST) Received: from x1.lan ([138.117.48.219]) by smtp.gmail.com with ESMTPSA id v20sm4174785qtg.79.2018.01.22.19.06.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Jan 2018 19:06:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZjW66BzKtwtJIDpf2q2iNx8f4NZXwLjRgvckWXX1Xms=; b=mS0UOvMkBcEy2sRcj+MYkrfo9R7n3gaEqkWMYwz5XcDc28lbFNX9pGRANo23TqCEzk +yOihVWCTeNNCacn0CuFWYURTvKnwxzE0cyxxsG9S1BbYVA2G3Iice/DjredimSrQIN9 T40FE4wC/+mt2emX+mpW36hCiSA8gHgJzI/IdjUqBtxirXzBvCoD8xYZRrzkyuYzGCOL uqCk8eyYSmJ5y7Do+JUevfr2I0FmXKDWsfEWDTbtCYwpzGcDiSVSMjzHzXRxK/bSm9qQ nnw8sH65qGT+CZDUEMcf/OcEzpvmCR1kGiu8u90OIJalf9D3FEz0JuZgnm+ePe5U3+bQ t/nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=ZjW66BzKtwtJIDpf2q2iNx8f4NZXwLjRgvckWXX1Xms=; b=Ato9CN3UjzSDGbDP8riF0r8SDG4C86eUWEofSCo0UyEl+Jpq9qb4ElII06skm3hE91 5+L0NI/uu9+PU/TlHCTUDxMg2iPMfePdRiqqY3tHCQqiL2XjvDALzE0iQ/a9pP+qg3z4 5KGcJrc71gmw4vudms6FalA1/L9y9DkcGGex9TQrTOl/smibvP0Pe8r0HdycDsUuuWO7 wiOqeOEB0rJb7/HQz5GVQ7l/KM9Ey3QuGiqXjZlTo36gFakcubahAtBoqTr4ZXQjuwVb QhnjAW3E4Xa+hGIu+nLxbVRF7QWPr8G6c0qkac/jdvRIjGHWAfr0PtqdpB/G67XaOorv 3oPA== X-Gm-Message-State: AKwxytfdTXwiiD3kqYft+JveW2m7wZXEP8sgneJYcKUMBjLcl9e81Si8 4LPS4Wg6plDGRwbtGOBoHNU= X-Google-Smtp-Source: AH8x225DF7yPrFA5ioEOJDjm0lerqNk7M8t1Mo4/OGHhLHDi1aPh6TerYsHQGCPCFiV8cUGJsKuaMg== X-Received: by 10.55.185.198 with SMTP id j189mr1408321qkf.243.1516676811024; Mon, 22 Jan 2018 19:06:51 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Alistair Francis , Peter Maydell Date: Tue, 23 Jan 2018 00:06:20 -0300 Message-Id: <20180123030630.26613-5-f4bug@amsat.org> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20180123030630.26613-1-f4bug@amsat.org> References: <20180123030630.26613-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::242 Subject: [Qemu-devel] [PATCH v8 04/14] sdbus: add trace events X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Edgar E . Iglesias" , Prasad J Pandit , Peter Crosthwaite , Andrey Smirnov , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org, Sai Pavan Boddu Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis --- hw/sd/core.c | 14 ++++++++++++-- hw/sd/trace-events | 5 +++++ 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/hw/sd/core.c b/hw/sd/core.c index 295dc44ab7..498284f109 100644 --- a/hw/sd/core.c +++ b/hw/sd/core.c @@ -23,6 +23,12 @@ #include "hw/qdev-core.h" #include "sysemu/block-backend.h" #include "hw/sd/sd.h" +#include "trace.h" + +static inline const char *sdbus_name(SDBus *sdbus) +{ + return sdbus->qbus.name; +} =20 static SDState *get_card(SDBus *sdbus) { @@ -39,6 +45,7 @@ int sdbus_do_command(SDBus *sdbus, SDRequest *req, uint8_= t *response) { SDState *card =3D get_card(sdbus); =20 + trace_sdbus_command(sdbus_name(sdbus), req->cmd, req->arg, req->crc); if (card) { SDCardClass *sc =3D SD_CARD_GET_CLASS(card); =20 @@ -52,6 +59,7 @@ void sdbus_write_data(SDBus *sdbus, uint8_t value) { SDState *card =3D get_card(sdbus); =20 + trace_sdbus_write(sdbus_name(sdbus), value); if (card) { SDCardClass *sc =3D SD_CARD_GET_CLASS(card); =20 @@ -62,14 +70,16 @@ void sdbus_write_data(SDBus *sdbus, uint8_t value) uint8_t sdbus_read_data(SDBus *sdbus) { SDState *card =3D get_card(sdbus); + uint8_t value =3D 0; =20 if (card) { SDCardClass *sc =3D SD_CARD_GET_CLASS(card); =20 - return sc->read_data(card); + value =3D sc->read_data(card); } + trace_sdbus_read(sdbus_name(sdbus), value); =20 - return 0; + return value; } =20 bool sdbus_data_ready(SDBus *sdbus) diff --git a/hw/sd/trace-events b/hw/sd/trace-events index 78d8707669..ea2746c8b7 100644 --- a/hw/sd/trace-events +++ b/hw/sd/trace-events @@ -1,5 +1,10 @@ # See docs/devel/tracing.txt for syntax documentation. =20 +# hw/sd/core.c +sdbus_command(const char *bus_name, uint8_t cmd, uint32_t arg, uint8_t crc= ) "@%s CMD%02d arg 0x%08x crc 0x%02x" +sdbus_read(const char *bus_name, uint8_t value) "@%s value 0x%02x" +sdbus_write(const char *bus_name, uint8_t value) "@%s value 0x%02x" + # hw/sd/sdhci.c sdhci_set_inserted(const char *level) "card state changed: %s" sdhci_send_command(uint8_t cmd, uint32_t arg) "CMD%02u ARG[0x%08x]" --=20 2.15.1