From nobody Wed Feb 11 05:35:41 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1516674223378281.1613576151037; Mon, 22 Jan 2018 18:23:43 -0800 (PST) Received: from localhost ([::1]:55663 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1edoFS-0008Dm-Eo for importer@patchew.org; Mon, 22 Jan 2018 21:23:42 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48818) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1edo1V-0005eS-HD for qemu-devel@nongnu.org; Mon, 22 Jan 2018 21:09:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1edo1U-0003dq-ND for qemu-devel@nongnu.org; Mon, 22 Jan 2018 21:09:17 -0500 Received: from mail-qt0-x241.google.com ([2607:f8b0:400d:c0d::241]:42799) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1edo1U-0003de-IJ for qemu-devel@nongnu.org; Mon, 22 Jan 2018 21:09:16 -0500 Received: by mail-qt0-x241.google.com with SMTP id c2so26134849qtn.9 for ; Mon, 22 Jan 2018 18:09:16 -0800 (PST) Received: from x1.lan ([138.117.48.219]) by smtp.gmail.com with ESMTPSA id j19sm6514120qtc.1.2018.01.22.18.09.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Jan 2018 18:09:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=Ia8pHowuePS0FfAL4vzaFvCr6w+uIgICr9PGj3SaD/w=; b=X6g/dpBf1AkSFBUkltT74D+JXPGlhqJu5J1NbrARPp9jsu1v2Jc21Ik2zfpFuX3l3F dyhc8HlpxXSoCrt1V5n9S52cH8QqJ5AZ8ajXzjyF1UJtdWaHQDOy6EU0grxbzFuxGq5B fn8FhsoH3lqRfC1Gbym8w2aZu16ETEzGRQ3+naVLkjUR2zx6p8HIzGFxZWLHum46qRvC 5MZOeOxpv9J/bXDp+A3QPY2JXLWq3kCWstMOrU8ddw0VwDm8jIvV8VKD9r0HTf6fBqYE WT3P6hwGezU9U//yNdHGJk834rtzLW4vtMQuyYeZRMXcu32+lQDymouZwnop0X3UNBRa Scfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=Ia8pHowuePS0FfAL4vzaFvCr6w+uIgICr9PGj3SaD/w=; b=QviwNlvug9T/6cUj4QXs4P7tYlfXCO7R9oVlqNMBHKSrJKx/zUS4zrtIO0OCFfooPd 969IIWmBzPv/kNrH+qAbTTA7Rf643BEGu8vaasRAbAD/GqSDF6Oz8Ta3r+1NuyR2E4La K9Z1LPOG5lBhYRYjAc7EEfQ2EipsEolFtPre+tnI/aobQ2hbkNmS720pR9GosZY8HyqA 5vgsmEoI4KSVzlpLaIv9y5wvhDbGst5ICgSRcudq5fjwX7AWTlVEu5v21Edv/DaTpz1N k8cTOauguX+rgZw5Wpbexr++9QLTxWsijGV1ILv7EjQ6VN0uwyBaidrXpxR/U8ZQeBQC 4lyA== X-Gm-Message-State: AKwxytdCDqM6teXs7/gIffVOPmnKSk3pzAlSO1iRD15Aj0QFi8gMpkMf axlfGexcHk46YU477sFTAYg= X-Google-Smtp-Source: AH8x2269WvbtMb7RmjeeefGf70Mp78tSU6Zru1pC1uO56RM6qUpGZwtj82ihojRBrxTgfKxu6eqkKA== X-Received: by 10.200.44.251 with SMTP id 56mr1444028qtx.55.1516673356239; Mon, 22 Jan 2018 18:09:16 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Paolo Bonzini , Alistair Francis , Peter Maydell , Stefan Hajnoczi Date: Mon, 22 Jan 2018 23:08:16 -0300 Message-Id: <20180123020820.1288-13-f4bug@amsat.org> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20180123020820.1288-1-f4bug@amsat.org> References: <20180123020820.1288-1-f4bug@amsat.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::241 Subject: [Qemu-devel] [PATCH v9 12/16] sdhci: Fix 64-bit ADMA2 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Edgar E . Iglesias" , Andrey Smirnov , qemu-devel@nongnu.org, Sai Pavan Boddu , Kevin O'Connor , Marcel Apfelbaum Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Sai Pavan Boddu The 64-bit ADMA address is not converted to the cpu endianes correctly. This patch fixes the issue and uses a valid mask for the attribute data. Signed-off-by: Sai Pavan Boddu [AF: Re-write commit message] Reviewed-by: Alistair Francis --- hw/sd/sdhci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c index 9f9d6835c0..a6bba1939f 100644 --- a/hw/sd/sdhci.c +++ b/hw/sd/sdhci.c @@ -667,8 +667,8 @@ static void get_adma_description(SDHCIState *s, ADMADes= cr *dscr) dscr->length =3D le16_to_cpu(dscr->length); dma_memory_read(s->dma_as, entry_addr + 4, (uint8_t *)(&dscr->addr), 8); - dscr->attr =3D le64_to_cpu(dscr->attr); - dscr->attr &=3D 0xfffffff8; + dscr->addr =3D le64_to_cpu(dscr->addr); + dscr->attr &=3D (uint8_t) ~0xC0; dscr->incr =3D 12; break; } --=20 2.15.1