From nobody Mon May 6 12:28:47 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1516338836204743.5666552304988; Thu, 18 Jan 2018 21:13:56 -0800 (PST) Received: from localhost ([::1]:52978 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ecOzw-0001wg-Dq for importer@patchew.org; Fri, 19 Jan 2018 00:13:52 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34651) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ecOvx-00074w-3A for qemu-devel@nongnu.org; Fri, 19 Jan 2018 00:09:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ecOvt-0000yE-1K for qemu-devel@nongnu.org; Fri, 19 Jan 2018 00:09:45 -0500 Received: from ozlabs.ru ([107.173.13.209]:34660) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ecOvs-0000xz-PC for qemu-devel@nongnu.org; Fri, 19 Jan 2018 00:09:40 -0500 Received: from vpl1.ozlabs.ibm.com (localhost [IPv6:::1]) by ozlabs.ru (Postfix) with ESMTP id 40D153A60005; Fri, 19 Jan 2018 00:08:56 -0500 (EST) From: Alexey Kardashevskiy To: qemu-devel@nongnu.org Date: Fri, 19 Jan 2018 16:09:06 +1100 Message-Id: <20180119050906.18930-1-aik@ozlabs.ru> X-Mailer: git-send-email 2.11.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 107.173.13.209 Subject: [Qemu-devel] [RFC PATCH qemu] qmp: Add qom-list-properties to list QOM object properties X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexey Kardashevskiy , Andrea Bolognani , David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" There is already 'device-list-properties' which does most of the job, however it does not handle everything returned by qom-list-types such as machines as they inherit directly from TYPE_OBJECT and not TYPE_DEVICE. This adds a new qom-list-properties command which prints properties of a specific class and its instance. It is pretty much a simplified copy of the device-list-properties handler. Since it creates an object instance, device properties should appear in the output as they are copied to QOM properties at the instance_init hook. Signed-off-by: Alexey Kardashevskiy --- I am missing the point of make_device_property_info(). qmp_device_list_properties() creates the instance which copies everything to QOM properties hashtable and commenting out the do{}while() in make_device_property_info() does not seem to change a thing, what case am I missing here? --- qapi-schema.json | 29 +++++++++++++++++++++++++++++ qmp.c | 52 ++++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 81 insertions(+) diff --git a/qapi-schema.json b/qapi-schema.json index 5c06745..9d73501 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -1455,6 +1455,35 @@ 'returns': [ 'DevicePropertyInfo' ] } =20 ## +# @QOMPropertyInfo: +# +# Information about object properties. +# +# @name: the name of the property +# @type: the typename of the property +# @description: if specified, the description of the property. +# +# Since: 2.12 +## +{ 'struct': 'QOMPropertyInfo', + 'data': { 'name': 'str', 'type': 'str', '*description': 'str' } } + +## +# @qom-list-properties: +# +# List properties associated with a QOM object. +# +# @typename: the type name of an object +# +# Returns: a list of QOMPropertyInfo describing object properties +# +# Since: 2.12 +## +{ 'command': 'qom-list-properties', + 'data': { 'typename': 'str'}, + 'returns': [ 'QOMPropertyInfo' ] } + +## # @xen-set-global-dirty-log: # # Enable or disable the global dirty log mode. diff --git a/qmp.c b/qmp.c index 52cfd2d..20cb662 100644 --- a/qmp.c +++ b/qmp.c @@ -574,6 +574,58 @@ DevicePropertyInfoList *qmp_device_list_properties(con= st char *typename, return prop_list; } =20 +QOMPropertyInfoList *qmp_qom_list_properties(const char *typename, + Error **errp) +{ + ObjectClass *klass; + Object *obj; + ObjectProperty *prop; + ObjectPropertyIterator iter; + QOMPropertyInfoList *prop_list =3D NULL; + + klass =3D object_class_by_name(typename); + if (klass =3D=3D NULL) { + error_set(errp, ERROR_CLASS_DEVICE_NOT_FOUND, + "Class '%s' not found", typename); + return NULL; + } + + klass =3D object_class_dynamic_cast(klass, TYPE_OBJECT); + if (klass =3D=3D NULL) { + error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "typename", TYPE_OB= JECT); + return NULL; + } + + if (object_class_is_abstract(klass)) { + error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "typename", + "non-abstract class"); + return NULL; + } + + obj =3D object_new(typename); + + object_property_iter_init(&iter, obj); + while ((prop =3D object_property_iter_next(&iter))) { + QOMPropertyInfo *info; + QOMPropertyInfoList *entry; + + info =3D g_malloc0(sizeof(*info)); + info->name =3D g_strdup(prop->name); + info->type =3D g_strdup(prop->type); + info->has_description =3D !!prop->description; + info->description =3D g_strdup(prop->description); + + entry =3D g_malloc0(sizeof(*entry)); + entry->value =3D info; + entry->next =3D prop_list; + prop_list =3D entry; + } + + object_unref(obj); + + return prop_list; +} + CpuDefinitionInfoList *qmp_query_cpu_definitions(Error **errp) { return arch_query_cpu_definitions(errp); --=20 2.11.0