From nobody Fri May 3 03:39:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1516326296305837.8017785626191; Thu, 18 Jan 2018 17:44:56 -0800 (PST) Received: from localhost ([::1]:42469 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ecLja-0008Mg-A4 for importer@patchew.org; Thu, 18 Jan 2018 20:44:46 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54181) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ecLiI-0007dx-Fx for qemu-devel@nongnu.org; Thu, 18 Jan 2018 20:43:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ecLiE-0000ej-I3 for qemu-devel@nongnu.org; Thu, 18 Jan 2018 20:43:26 -0500 Received: from zero.eik.bme.hu ([152.66.115.2]:59917) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ecLiE-0000U5-BF; Thu, 18 Jan 2018 20:43:22 -0500 Received: from zero.eik.bme.hu (blah.eik.bme.hu [152.66.115.182]) by localhost (Postfix) with SMTP id C6F6174568D; Fri, 19 Jan 2018 02:43:13 +0100 (CET) Received: by zero.eik.bme.hu (Postfix, from userid 432) id 480EB7456D6; Fri, 19 Jan 2018 02:43:13 +0100 (CET) From: BALATON Zoltan Date: Thu, 18 Jan 2018 19:18:59 +0100 To: qemu-devel@nongnu.org, qemu-ppc@nongnu.org Message-Id: <20180119014313.480EB7456D6@zero.eik.bme.hu> X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-Received-From: 152.66.115.2 Subject: [Qemu-devel] [PATCH] sii3112: Add explicit type casts to avoid unintended sign extension X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Roth , Peter Maydell , Greg Kurz , David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Noticed by Coverity Reported-by: Peter Maydell Signed-off-by: BALATON Zoltan --- hw/ide/sii3112.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/ide/sii3112.c b/hw/ide/sii3112.c index e2f5562..17aa930 100644 --- a/hw/ide/sii3112.c +++ b/hw/ide/sii3112.c @@ -79,13 +79,13 @@ static uint64_t sii3112_reg_read(void *opaque, hwaddr a= ddr, val |=3D (d->regs[0].confstat & (1UL << 11) ? (1 << 4) : 0); /*SAT= AINT0*/ val |=3D (d->regs[1].confstat & (1UL << 11) ? (1 << 6) : 0); /*SAT= AINT1*/ val |=3D (d->i.bmdma[1].status & BM_STATUS_INT ? (1 << 14) : 0); - val |=3D d->i.bmdma[0].status << 16; - val |=3D d->i.bmdma[1].status << 24; + val |=3D (uint32_t)d->i.bmdma[0].status << 16; + val |=3D (uint32_t)d->i.bmdma[1].status << 24; break; case 0x18: val =3D d->i.bmdma[1].cmd; val |=3D (d->regs[1].confstat & (1UL << 11) ? (1 << 4) : 0); - val |=3D d->i.bmdma[1].status << 16; + val |=3D (uint32_t)d->i.bmdma[1].status << 16; break; case 0x80 ... 0x87: if (size =3D=3D 1) { @@ -128,7 +128,7 @@ static uint64_t sii3112_reg_read(void *opaque, hwaddr a= ddr, val =3D (d->i.bus[0].ifs[0].blk) ? 0x113 : 0; break; case 0x148: - val =3D d->regs[0].sien << 16; + val =3D (uint32_t)d->regs[0].sien << 16; break; case 0x180: val =3D d->regs[1].scontrol; @@ -137,7 +137,7 @@ static uint64_t sii3112_reg_read(void *opaque, hwaddr a= ddr, val =3D (d->i.bus[1].ifs[0].blk) ? 0x113 : 0; break; case 0x1c8: - val =3D d->regs[1].sien << 16; + val =3D (uint32_t)d->regs[1].sien << 16; break; default: val =3D 0; --=20 2.7.6