From nobody Mon Feb 9 16:34:54 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1516308377818426.7204345849425; Thu, 18 Jan 2018 12:46:17 -0800 (PST) Received: from localhost ([::1]:53833 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ecH4i-000490-Tq for importer@patchew.org; Thu, 18 Jan 2018 15:46:17 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44932) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ecGzz-0000T2-9R for qemu-devel@nongnu.org; Thu, 18 Jan 2018 15:41:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ecGzw-0007Sy-62 for qemu-devel@nongnu.org; Thu, 18 Jan 2018 15:41:23 -0500 Received: from mail-qt0-x241.google.com ([2607:f8b0:400d:c0d::241]:39366) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ecGzw-0007So-1p; Thu, 18 Jan 2018 15:41:20 -0500 Received: by mail-qt0-x241.google.com with SMTP id f4so12713507qtj.6; Thu, 18 Jan 2018 12:41:19 -0800 (PST) Received: from x1.local ([138.117.48.219]) by smtp.gmail.com with ESMTPSA id 24sm5484621qkv.64.2018.01.18.12.41.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Jan 2018 12:41:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TO+UjhDYmNYUT5347vMorHWZVMV/hSTmwoKB3PiqHqE=; b=Gg+hEdgUGwJqxqAfx8pzzT8EupAbmtn/XA9G0gRDv7WtGnY+aGQzhOtq2XrFTJF8Mi dYxtoUOxrD5LpMIugx8sb5EV8sDucX0VWVCyzNfV4i3A727sqT41TH2Pf8GLz+zjK3Rx IapdxUIUnQXhQ2Zdy+1IvXSt/nGjyzTxg22F5MneMfYk1gkXR1Cs6JZIx0R+ncwDHlnd yO5hEk6GPTnqs+bZemNK//getII5//ReYkh3NmzwqsOEvvBEvRH3XjzIzUfVQwqP5IF9 r7TGWFvYa24VKbFRuI5FlTXmODJnH6RFVunqmcJ0alwCet+kkDeJfnMq9tH3Wka2T7WB yN8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=TO+UjhDYmNYUT5347vMorHWZVMV/hSTmwoKB3PiqHqE=; b=FDUQPYoSL2ZMLIRYH5KnTt7ARlNxUyXMXj0UR5kDveRyqL7mr0QTirekbtCy+ty9lq 2R9AirztGqEf1zoZTmp7GmNIT4SHNhShcs9D9KanD4BkP0Hpw+alnhx8P79VrnSaFPWf 7oycXq77pLTklOK/lu/OV90NlNSobnz3MV3kqT6ECYw/yx+6B9xnZqlPK4OjDL3+pW3O iLkZAMzWakp8DTnDfYnqf05Og455//+GIbt7JOVAFm08OU7H5c6JnL4MpEGD6pyC5Uq0 hx1ujMldNtqQiE9MFB76MaXWj1PCzJ222C82hEsWc/rtRvZXfBKc/1x0O7DL0WBjC68b xmHg== X-Gm-Message-State: AKwxytfSzJW2A6ywWKyZIK3cRVMQXL+tDP3kMYOqCHmIX1lwObExRB94 e0fhljdEkqo0g3QOadZYsT0= X-Google-Smtp-Source: ACJfBosIDGDci/fmI7KFa6F+8wum/BKa1ikUH0qj9epJRyfAIFXfzHwD4hyRPqrPtWyuLa8PloDMTg== X-Received: by 10.200.41.123 with SMTP id z56mr9262033qtz.189.1516308079558; Thu, 18 Jan 2018 12:41:19 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Alistair Francis , Peter Maydell Date: Thu, 18 Jan 2018 17:40:47 -0300 Message-Id: <20180118204058.5768-4-f4bug@amsat.org> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20180118204058.5768-1-f4bug@amsat.org> References: <20180118204058.5768-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::241 Subject: [Qemu-devel] [PATCH v7 03/14] hw/arm/bcm2835_peripherals: implement SDHCI Spec v3 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Edgar E . Iglesias" , Prasad J Pandit , Peter Crosthwaite , Andrey Smirnov , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org, Sai Pavan Boddu , "open list:ARM" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/arm/bcm2835_peripherals.c | 32 +++++++++++++++++++++----------- 1 file changed, 21 insertions(+), 11 deletions(-) diff --git a/hw/arm/bcm2835_peripherals.c b/hw/arm/bcm2835_peripherals.c index 12e0dd11af..79d680cb1b 100644 --- a/hw/arm/bcm2835_peripherals.c +++ b/hw/arm/bcm2835_peripherals.c @@ -18,9 +18,6 @@ /* Peripheral base address on the VC (GPU) system bus */ #define BCM2835_VC_PERI_BASE 0x7e000000 =20 -/* Capabilities for SD controller: no DMA, high-speed, default clocks etc.= */ -#define BCM2835_SDHC_CAPAREG 0x52034b4 - static void bcm2835_peripherals_init(Object *obj) { BCM2835PeripheralState *s =3D BCM2835_PERIPHERALS(obj); @@ -254,14 +251,27 @@ static void bcm2835_peripherals_realize(DeviceState *= dev, Error **errp) memory_region_add_subregion(&s->peri_mr, RNG_OFFSET, sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->rng), 0)); =20 - /* Extended Mass Media Controller */ - object_property_set_int(OBJECT(&s->sdhci), BCM2835_SDHC_CAPAREG, "capa= reg", - &err); - if (err) { - error_propagate(errp, err); - return; - } - + /* Extended Mass Media Controller + * + * Compatible with: + * - SD Host Controller Specification Version 3.0 Draft 1.0 + * - SDIO Specification Version 3.0 + * - MMC Specification Version 4.4 + * + * - 32-bit access only + * - default clocks + * - no DMA + * - SD high-speed (SDHS) card + * - maximum block size: 1kB + * + * For the exact details please refer to the Arasan documentation: + * SD3.0_Host_AHB_eMMC4.4_Usersguide_ver5.9_jan11_10.pdf =C2=AF\_(= =E3=83=84)_/=C2=AF + */ + object_property_set_uint(OBJECT(&s->sdhci), 3, "sd-spec-version", &err= ); + object_property_set_uint(OBJECT(&s->sdhci), 52, "timeout-freq", &err); + object_property_set_uint(OBJECT(&s->sdhci), 52, "max-frequency", &err); + object_property_set_bool(OBJECT(&s->sdhci), false, "adma1", &err); + object_property_set_bool(OBJECT(&s->sdhci), true, "1v8", &err); object_property_set_bool(OBJECT(&s->sdhci), true, "pending-insert-quir= k", &err); if (err) { --=20 2.15.1