From nobody Tue Feb 10 06:25:09 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 151630877546580.59077496378279; Thu, 18 Jan 2018 12:52:55 -0800 (PST) Received: from localhost ([::1]:53947 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ecHB5-0001Y5-5S for importer@patchew.org; Thu, 18 Jan 2018 15:52:51 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45132) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ecH0S-0000uP-Tr for qemu-devel@nongnu.org; Thu, 18 Jan 2018 15:41:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ecH0R-0007nK-Ut for qemu-devel@nongnu.org; Thu, 18 Jan 2018 15:41:52 -0500 Received: from mail-qt0-x242.google.com ([2607:f8b0:400d:c0d::242]:38036) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ecH0R-0007n6-Q0 for qemu-devel@nongnu.org; Thu, 18 Jan 2018 15:41:51 -0500 Received: by mail-qt0-x242.google.com with SMTP id z10so5494183qti.5 for ; Thu, 18 Jan 2018 12:41:51 -0800 (PST) Received: from x1.local ([138.117.48.219]) by smtp.gmail.com with ESMTPSA id 24sm5484621qkv.64.2018.01.18.12.41.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Jan 2018 12:41:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ydqMLYPL8mZf4X4L58+PNGmXrTS2z41Avy1lgtju11k=; b=DewWC8EQ3XqnHYV5O0d0ETvm8rSQdXVB8ZBdwPdSfwnfqWCMXe941rJbkzhFZmU+yq fqVN5NZkocY2mrlxh4UWBstg8/az/KVME/lxovshj90d8yTGSXCmaT0zFbikKXodJxCK RH4YHlvRzWNxEJ1TQoSaGDRHGdamVGUeY3NW7v1S3Yqiovnu0kQUTwNE/K3GxhiPrTE0 b/18i2lxwFUTp8KY/en5zu/5tc9VnSvccWoWfjUkPF5qyIszsMnBBuhweFtqMRwwlqeQ JPEf/q8B8Ipud+Djvl8UqtC0FnEvywbrcpa85Walb2Kfts01RvpZJsdHVfaoqtXLApSg w/BA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=ydqMLYPL8mZf4X4L58+PNGmXrTS2z41Avy1lgtju11k=; b=mKHDqGekc9FMWOcn+bZZUCUF9EAAnsfhr/OYbrdf/hnsTi7Sd/DfZB/egtub0y7kD0 KOfzeVovZ6ze/kStcNM+hpgBta9WfU8hByqUV1OQ7s9uU48tyg+94ngUkNPEWLLOpJ94 7hf4/HWRVmRsMMT6iH+US8f3YN6JTtKdEM7o0NeoCDY1otOQuboI56fgeztn7+KsMhcS 6OxxKeF3D6WNZyPQ5hIq5libJoW6/gF9fiuOuEJqRs5kKifIg7y2TgYdcjhzzpMg5frg Fxp2Iioovda6Nvp5DOtA+JXg5FwyEnkwIKEJygTal0YlQdwMQfomHaOhBNj8Nz8P9xcq vx0g== X-Gm-Message-State: AKwxytelAqK2+6/PsceRURTPiE+3Pj96HucwukGt1HO2CWnRCTUSdgA+ SeHj7CqZr0Td04bib5ATx8d7QTLV X-Google-Smtp-Source: ACJfBot8acaBm/PjBVDY7goaczQUU4XhZUSB0NZcFOfyxPQfS4nX3+TgmPF8A/J1M9dKbdS53SqKmA== X-Received: by 10.55.6.145 with SMTP id 139mr57780399qkg.285.1516308111299; Thu, 18 Jan 2018 12:41:51 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Alistair Francis , Peter Maydell Date: Thu, 18 Jan 2018 17:40:56 -0300 Message-Id: <20180118204058.5768-13-f4bug@amsat.org> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20180118204058.5768-1-f4bug@amsat.org> References: <20180118204058.5768-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::242 Subject: [Qemu-devel] [PATCH v7 12/14] sdbus: add trace events X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Edgar E . Iglesias" , Prasad J Pandit , Peter Crosthwaite , Andrey Smirnov , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org, Sai Pavan Boddu Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/sd/core.c | 14 ++++++++++++-- hw/sd/trace-events | 5 +++++ 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/hw/sd/core.c b/hw/sd/core.c index 295dc44ab7..498284f109 100644 --- a/hw/sd/core.c +++ b/hw/sd/core.c @@ -23,6 +23,12 @@ #include "hw/qdev-core.h" #include "sysemu/block-backend.h" #include "hw/sd/sd.h" +#include "trace.h" + +static inline const char *sdbus_name(SDBus *sdbus) +{ + return sdbus->qbus.name; +} =20 static SDState *get_card(SDBus *sdbus) { @@ -39,6 +45,7 @@ int sdbus_do_command(SDBus *sdbus, SDRequest *req, uint8_= t *response) { SDState *card =3D get_card(sdbus); =20 + trace_sdbus_command(sdbus_name(sdbus), req->cmd, req->arg, req->crc); if (card) { SDCardClass *sc =3D SD_CARD_GET_CLASS(card); =20 @@ -52,6 +59,7 @@ void sdbus_write_data(SDBus *sdbus, uint8_t value) { SDState *card =3D get_card(sdbus); =20 + trace_sdbus_write(sdbus_name(sdbus), value); if (card) { SDCardClass *sc =3D SD_CARD_GET_CLASS(card); =20 @@ -62,14 +70,16 @@ void sdbus_write_data(SDBus *sdbus, uint8_t value) uint8_t sdbus_read_data(SDBus *sdbus) { SDState *card =3D get_card(sdbus); + uint8_t value =3D 0; =20 if (card) { SDCardClass *sc =3D SD_CARD_GET_CLASS(card); =20 - return sc->read_data(card); + value =3D sc->read_data(card); } + trace_sdbus_read(sdbus_name(sdbus), value); =20 - return 0; + return value; } =20 bool sdbus_data_ready(SDBus *sdbus) diff --git a/hw/sd/trace-events b/hw/sd/trace-events index 0a121156a3..c0f51f11d4 100644 --- a/hw/sd/trace-events +++ b/hw/sd/trace-events @@ -1,5 +1,10 @@ # See docs/devel/tracing.txt for syntax documentation. =20 +# hw/sd/core.c +sdbus_command(const char *bus_name, uint8_t cmd, uint32_t arg, uint8_t crc= ) "@%s CMD%02d arg 0x%08x crc 0x%02x" +sdbus_read(const char *bus_name, uint8_t value) "@%s value 0x%02x" +sdbus_write(const char *bus_name, uint8_t value) "@%s value 0x%02x" + # hw/sd/sdhci.c sdhci_set_inserted(const char *level) "card state changed: %s" sdhci_send_command(uint8_t cmd, uint32_t arg) "CMD%02u ARG[0x%08x]" --=20 2.15.1