From nobody Tue Feb 10 07:23:27 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1516300400946695.718203535738; Thu, 18 Jan 2018 10:33:20 -0800 (PST) Received: from localhost ([::1]:46770 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ecF00-0007Qp-3b for importer@patchew.org; Thu, 18 Jan 2018 13:33:16 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37758) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ecEyE-0006aI-6c for qemu-devel@nongnu.org; Thu, 18 Jan 2018 13:31:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ecEyA-0002pM-T6 for qemu-devel@nongnu.org; Thu, 18 Jan 2018 13:31:26 -0500 Received: from mail-qt0-x242.google.com ([2607:f8b0:400d:c0d::242]:40048) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ecEyA-0002oT-O4 for qemu-devel@nongnu.org; Thu, 18 Jan 2018 13:31:22 -0500 Received: by mail-qt0-x242.google.com with SMTP id s39so15494276qth.7 for ; Thu, 18 Jan 2018 10:31:22 -0800 (PST) Received: from x1.local ([138.117.48.219]) by smtp.gmail.com with ESMTPSA id g9sm446661qtg.90.2018.01.18.10.31.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Jan 2018 10:31:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LUEsUxiuurtKMmtZPPD4mg/b5YMPQh3fgZibcnp6n6E=; b=CUUAynvR5MSzMcSHDFxUF6+FGEZYjxDWAp6zRlmh2Qvyl4MmaV0jyJLqtKG8qzbKmI Z4I1nsfHRS6AGJOqBaD24uwk1xvq1Ja4Ne5ahON98fOfZJBa6QQrSgrHJ44qO7AUP8e9 0JLpWDPBpX8k52nBPkPt7lO4Ov9R1mK3UXuoekmBqOZgGHcWWIZHERm3OWYKVEyl4QCP Y3s//aHhJtqvbXWgANfM8R7kfDRs+tjo76sqM2BBLtaUEVyUyjT0hFDQo8Bj7VMSJ8fT 8TvhdhDWp8CAm+shU0BiF+hIyYo9JHkzfVZooTZXxgm9tE1CvumCVe6xCX40Yvj17Yo6 nLQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=LUEsUxiuurtKMmtZPPD4mg/b5YMPQh3fgZibcnp6n6E=; b=sPE5uJ7aaE0vtMR22/iTLGQGqGaUvp0cHti5mSAsoeMWbvIXO0Ph9OG8H9F5QRMyYe +p9J2SOw0lWP1E16OJEw1BVGaG3fkNF9Ohtv5z08GWFK1k8Wat2Tc5qhG5vRlxGJ39+S sCzuJ+gJ9Wzm6FXa8rAk0lBozeGOIr+dhn6qpolyfmQ+i7aikfJ8aKs1dU9MM94xbujf Iwz8k4xsrg38G4oupVMFxx9FZormmHoAvPpzyG04N4Tp1p9qVlqooq4eAKa8qDvrUKD6 x2V61+PDyJcDNrkhqdFC4e9pDezYp8+VETsWyHInuejrFwOXXgyMYjRgdASfs9vn9Q4h FXcg== X-Gm-Message-State: AKwxytfwTNhqwX7WVDgHG5y0+2aWveggA0IJwZ0CrbxYyBXIQjdX/qtp 8dqMzQqNUp+WhZD9vU+C5+s= X-Google-Smtp-Source: ACJfBovIKFdAtZT/XalA45NCYeljdpQtObEz9RaxB/SKEogy6kyQzTgvUI8FyK8/qAYGd9LkIBOR0g== X-Received: by 10.200.40.194 with SMTP id j2mr9546407qtj.154.1516300282231; Thu, 18 Jan 2018 10:31:22 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Paolo Bonzini , Alistair Francis , Peter Maydell , Stefan Hajnoczi Date: Thu, 18 Jan 2018 15:30:52 -0300 Message-Id: <20180118183108.16009-1-f4bug@amsat.org> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20180118182510.15630-1-f4bug@amsat.org> References: <20180118182510.15630-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::242 Subject: [Qemu-devel] [PATCH v8 01/17] sdhci: use error_propagate(local_err) in realize() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Edgar E . Iglesias" , Andrey Smirnov , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org, Kevin O'Connor , Marcel Apfelbaum Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 avoid the "errp && *errp" pattern (not recommended in "qapi/error.h" commen= ts). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis --- hw/sd/sdhci.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c index f9264d3be5..8c9c0fbc2a 100644 --- a/hw/sd/sdhci.c +++ b/hw/sd/sdhci.c @@ -1300,10 +1300,12 @@ static Property sdhci_pci_properties[] =3D { static void sdhci_pci_realize(PCIDevice *dev, Error **errp) { SDHCIState *s =3D PCI_SDHCI(dev); + Error *local_err =3D NULL; =20 sdhci_initfn(s); sdhci_common_realize(s, errp); - if (errp && *errp) { + if (local_err) { + error_propagate(errp, local_err); return; } =20 @@ -1381,9 +1383,11 @@ static void sdhci_sysbus_realize(DeviceState *dev, E= rror ** errp) { SDHCIState *s =3D SYSBUS_SDHCI(dev); SysBusDevice *sbd =3D SYS_BUS_DEVICE(dev); + Error *local_err =3D NULL; =20 sdhci_common_realize(s, errp); - if (errp && *errp) { + if (local_err) { + error_propagate(errp, local_err); return; } =20 --=20 2.15.1