[Qemu-devel] [PATCH v2 0/6] nbd export qmp interface

Vladimir Sementsov-Ogievskiy posted 6 patches 6 years, 2 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180118181123.37056-1-vsementsov@virtuozzo.com
Test checkpatch passed
Test docker-build@min-glib passed
Test docker-mingw@fedora passed
Test docker-quick@centos6 passed
Test ppc passed
Test s390x passed
There is a newer version of this series
qapi/block.json               |  54 +++++++++++++-
include/block/nbd.h           |   1 +
blockdev-nbd.c                |  38 ++++++++--
hmp.c                         |   6 +-
nbd/server.c                  |  21 ++++++
hmp-commands.hx               |   9 +--
tests/qemu-iotests/147        |  68 ++++++++++++++----
tests/qemu-iotests/147.out    |   4 +-
tests/qemu-iotests/201        | 159 ++++++++++++++++++++++++++++++++++++++++++
tests/qemu-iotests/201.out    |   5 ++
tests/qemu-iotests/group      |   1 +
tests/qemu-iotests/iotests.py |  38 ++++++++++
12 files changed, 376 insertions(+), 28 deletions(-)
create mode 100644 tests/qemu-iotests/201
create mode 100644 tests/qemu-iotests/201.out
[Qemu-devel] [PATCH v2 0/6] nbd export qmp interface
Posted by Vladimir Sementsov-Ogievskiy 6 years, 2 months ago
v2:
01: tweak comment
    add Eric's r-b
02: new patch
03: rewritten, to move form 'bool force' flag to 'enum mode' parameter
04: add Eric's r-b
05: improve commit message
    tweak comment
06: rebase on 03 changes
    make PEP8 happy
    some other tweaks
    I've left nbd_port variable hard-set to 10900. I think all such things
    should be fixed together, and it is simple to change in future
    nbd_port = '10900'
    to
    nbd_port = iotests.get_free_port()
    if needed.

[Unfortunately, qmp query-nbd-server is not finished yet, coming soon,
 but may be after my vocation on the next week]

Vladimir Sementsov-Ogievskiy (6):
  qapi: add name parameter to nbd-server-add
  hmp: add name parameter to nbd_server_add
  qapi: add nbd-server-remove
  iotest 147: add cases to test new @name parameter of nbd-server-add
  iotests: implement QemuIoInteractive class
  iotest 201: new test for qmp nbd-server-remove

 qapi/block.json               |  54 +++++++++++++-
 include/block/nbd.h           |   1 +
 blockdev-nbd.c                |  38 ++++++++--
 hmp.c                         |   6 +-
 nbd/server.c                  |  21 ++++++
 hmp-commands.hx               |   9 +--
 tests/qemu-iotests/147        |  68 ++++++++++++++----
 tests/qemu-iotests/147.out    |   4 +-
 tests/qemu-iotests/201        | 159 ++++++++++++++++++++++++++++++++++++++++++
 tests/qemu-iotests/201.out    |   5 ++
 tests/qemu-iotests/group      |   1 +
 tests/qemu-iotests/iotests.py |  38 ++++++++++
 12 files changed, 376 insertions(+), 28 deletions(-)
 create mode 100644 tests/qemu-iotests/201
 create mode 100644 tests/qemu-iotests/201.out

-- 
2.11.1


Re: [Qemu-devel] [PATCH v2 0/6] nbd export qmp interface
Posted by Eric Blake 6 years, 2 months ago
On 01/18/2018 12:11 PM, Vladimir Sementsov-Ogievskiy wrote:
> v2:
> 01: tweak comment
>     add Eric's r-b
> 02: new patch
> 03: rewritten, to move form 'bool force' flag to 'enum mode' parameter
> 04: add Eric's r-b
> 05: improve commit message
>     tweak comment
> 06: rebase on 03 changes
>     make PEP8 happy
>     some other tweaks
>     I've left nbd_port variable hard-set to 10900. I think all such things
>     should be fixed together, and it is simple to change in future
>     nbd_port = '10900'
>     to
>     nbd_port = iotests.get_free_port()
>     if needed.
> 
> [Unfortunately, qmp query-nbd-server is not finished yet, coming soon,
>  but may be after my vocation on the next week]

Enjoy your time off. I think the series is nearly ready to go; I had
some tweaks that I suggested, and will probably replace your 2/6 with my
counterproposal, but I don't mind doing that cleanup if you don't have
time to respin.  I'll give it a few more days in case anyone else has
comments, then add it to my NBD queue.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Re: [Qemu-devel] [PATCH v2 0/6] nbd export qmp interface
Posted by Kevin Wolf 6 years, 2 months ago
Am 18.01.2018 um 23:45 hat Eric Blake geschrieben:
> On 01/18/2018 12:11 PM, Vladimir Sementsov-Ogievskiy wrote:
> > v2:
> > 01: tweak comment
> >     add Eric's r-b
> > 02: new patch
> > 03: rewritten, to move form 'bool force' flag to 'enum mode' parameter
> > 04: add Eric's r-b
> > 05: improve commit message
> >     tweak comment
> > 06: rebase on 03 changes
> >     make PEP8 happy
> >     some other tweaks
> >     I've left nbd_port variable hard-set to 10900. I think all such things
> >     should be fixed together, and it is simple to change in future
> >     nbd_port = '10900'
> >     to
> >     nbd_port = iotests.get_free_port()
> >     if needed.
> > 
> > [Unfortunately, qmp query-nbd-server is not finished yet, coming soon,
> >  but may be after my vocation on the next week]
> 
> Enjoy your time off. I think the series is nearly ready to go; I had
> some tweaks that I suggested, and will probably replace your 2/6 with my
> counterproposal, but I don't mind doing that cleanup if you don't have
> time to respin.  I'll give it a few more days in case anyone else has
> comments, then add it to my NBD queue.

I haven't reviewed the patches in detail, but the API changes look good
to me.

Kevin