From nobody Sun Oct 26 00:02:36 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 151627968299126.196564286441912; Thu, 18 Jan 2018 04:48:02 -0800 (PST) Received: from localhost ([::1]:56713 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ec9bk-000482-Qd for importer@patchew.org; Thu, 18 Jan 2018 07:47:52 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36801) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ec9Nn-0000Vc-6s for qemu-devel@nongnu.org; Thu, 18 Jan 2018 07:33:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ec9Nl-0007PY-AC for qemu-devel@nongnu.org; Thu, 18 Jan 2018 07:33:26 -0500 Received: from mail-qt0-x244.google.com ([2607:f8b0:400d:c0d::244]:45807) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ec9Nl-0007PQ-5c for qemu-devel@nongnu.org; Thu, 18 Jan 2018 07:33:25 -0500 Received: by mail-qt0-x244.google.com with SMTP id x27so21691898qtm.12 for ; Thu, 18 Jan 2018 04:33:25 -0800 (PST) Received: from x1.local ([138.117.48.219]) by smtp.gmail.com with ESMTPSA id s12sm4489623qke.4.2018.01.18.04.33.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Jan 2018 04:33:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=B7SVPVgL4O8p3QOXSiDlYh1p60ycxGl3UOlGHgAWVVs=; b=kUqF6EZoS/uNRzQpu/txywGHmHvqL2pcO27hunOww65H9DE2gzEfz7zA2CFkJ7CrWI hymMd7hUDo0TOwlYiBnK27gYr3BGwLtuLCRQhXhVBlC86vt3BWb/3PERbhvoxXoST4P3 bLD9wMm3ie/pIHXJ5vd24APNoATesDsQ0ajWjOCIq/ExDLRjnRTSjP/VQyI2fYSfbuyH Rftvh6tbcLKGhS+A2U4nDqtR8HM1/G6ToP7pwEosvLo8GLTQerBMRAY3ybjE95nvsDjQ aqDn5XjVRzaSNJdKrm5ej0bCBitDYBM0GwT4rQoVbW+ekPQKX96d2eSjGLOwGqCevZ/j Ks3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=B7SVPVgL4O8p3QOXSiDlYh1p60ycxGl3UOlGHgAWVVs=; b=RdD7bO4et96sDvxzJEbgIFqukvcge71h7c4dhKVFw4hCNcyt9PTvoaAI7u/J5Bhs49 evtgtj9SKTwJMzdc+UoUmD0ZyziZa5KGoZMGaQn62bQdiEwWT2mtSq8CSRfASCE2d85/ gOzFg+OxtJ2+zVsEirLD6IgGhX/7u5eM2Bmvp+USnr4C9obK8CGaV8L6oWpP85/2eDXR DsqlyS3bm3GGrn7eOB9YoZkNXw2oXDtGf1LkuIn6L1QCTNtXj2hzWLB30rC2clSw5wQY bFX1NdKkaw6NJL1iZ2mrJxEqkT/P4haoVAqTj0Jyb7cXkzoLsFfDdhhORJJbQK1IdBrb tqfw== X-Gm-Message-State: AKwxytcY+9vzQPy1OfZVUvWao00ZUXyd+qrldYKkvtbpCrHBOnGc10Is Vkrs4xmfPRFOPEXoQ5r3h7g= X-Google-Smtp-Source: ACJfBotTDOvgfL0l5eh6CDv+22SsG3q0VgUIvm+yxpsR9GS0tE74UWkRyuJGl5YXoWZrDbPhRO0fqA== X-Received: by 10.237.46.130 with SMTP id k2mr17949566qtd.85.1516278804745; Thu, 18 Jan 2018 04:33:24 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Paolo Bonzini , Alistair Francis , Peter Maydell , Stefan Hajnoczi Date: Thu, 18 Jan 2018 09:32:18 -0300 Message-Id: <20180118123219.19410-17-f4bug@amsat.org> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20180118123219.19410-1-f4bug@amsat.org> References: <20180118123219.19410-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::244 Subject: [Qemu-devel] [PATCH v7 16/16] sdhci: throw an error if capabilities are incorrectly configured X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Edgar E . Iglesias" , Andrey Smirnov , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org, Kevin O'Connor , Marcel Apfelbaum Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 now than the Exynos4210 uses the 'capareg-reserved' property, we can safely report missing capabilities as error, since capabilities will only get changed once new SDHCI models are added. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis --- hw/sd/sdhci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c index 7799382e89..07a7ebcc1e 100644 --- a/hw/sd/sdhci.c +++ b/hw/sd/sdhci.c @@ -23,7 +23,6 @@ */ =20 #include "qemu/osdep.h" -#include "qemu/error-report.h" #include "qapi/error.h" #include "hw/hw.h" #include "sysemu/block-backend.h" @@ -1208,7 +1207,8 @@ static void sdhci_init_readonly_registers(SDHCIState = *s, Error **errp) } else { capab =3D s->capareg & ~capab; if (capab) { - warn_report("SDHCI: missing capability mask: 0x%" PRIx64, capa= b); + error_setg(errp, "missing capability mask: 0x%" PRIx64, capab); + return; } } } --=20 2.15.1