From nobody Sun Oct 26 00:03:10 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1516279462906407.9536551793225; Thu, 18 Jan 2018 04:44:22 -0800 (PST) Received: from localhost ([::1]:56541 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ec9YM-000131-2s for importer@patchew.org; Thu, 18 Jan 2018 07:44:22 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36798) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ec9Nn-0000Vb-6r for qemu-devel@nongnu.org; Thu, 18 Jan 2018 07:33:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ec9Nh-0007Np-Ri for qemu-devel@nongnu.org; Thu, 18 Jan 2018 07:33:26 -0500 Received: from mail-qt0-x242.google.com ([2607:f8b0:400d:c0d::242]:33276) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ec9Nh-0007Ng-NS; Thu, 18 Jan 2018 07:33:21 -0500 Received: by mail-qt0-x242.google.com with SMTP id e2so29724973qti.0; Thu, 18 Jan 2018 04:33:21 -0800 (PST) Received: from x1.local ([138.117.48.219]) by smtp.gmail.com with ESMTPSA id s12sm4489623qke.4.2018.01.18.04.33.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Jan 2018 04:33:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=w4cF8nBWMgtYO8vYeoe5XnN1zsLEoTSdpZMqL5PVRxQ=; b=qR/YVFRag7e9anWAHPapVTOWm1WuvSUheUEtQ2+na9FfMZLa51LnY6PRUx0fAnaVKd GNlaUaP8FISo45Q0PsRCVnPA52qgAJfthB9wDi4/vwLTuDUygk7nT+El3/iHJ95MLTAM MDJ20yq/gMIWrrxMjai9KN4LW/myriuDBPzvGra8HdJ4uXEyqVoU3x33VLzY4diPYukK 5+Q28XXa39VVzIyuQmCffYCuPm3CIt6V9TApeDdaNDe3sq1jLTekXsfmn00yiBdj5Y+e n4sICJga7+CUG3kokI72JOhd/dBYpx8/hzzigMLFbeBr36aQffjdyUh4n/44ACI+sqnJ /7Cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=w4cF8nBWMgtYO8vYeoe5XnN1zsLEoTSdpZMqL5PVRxQ=; b=mDsusnPy7doK8S0UHBpbBB5Cg18E49iy+iV8YzydIuO+ImdI4pWNWcirEd1vRxGuzH Qk2swdTB+vW9Qz2/pGu8nk5s3xPLatwIs6s3+WZ9q6bUx+hsWyJuTx3tdi2rehYRjBuG cyKlwZKD50x5Ml8SbUs56CASbLM5arOKDdrdYvH+jeACjutunzFgMBH+SodbwQHnFnSp iOKbyyW4O2KWUfWhKra1k5yDlWra9zM7dwMgka94BKE6rTEPnHuRvnYPOCG9L2bpQ9gw ppN05/UH4MpU3cqzYJJSbJN7WOqEsp2WfvlVQfmiHkEMbtb7vIYXYOhz7ylYMZP/DjUI e6gA== X-Gm-Message-State: AKwxytfWZLHbDNOEwuT0KLwdNs1tQOMWXXpXXFUlt2u1VckHHV1Geqmi JAcDA5KxhMTLI/nVfC3mWX4= X-Google-Smtp-Source: ACJfBotj2KvuLUu0Xv2njx/7VhC2j3K5Zy5N9ZnWx+Ci41/rmI95py4iOkH0vbQUUuZfOlbuFwIOMQ== X-Received: by 10.200.46.214 with SMTP id i22mr37688916qta.157.1516278801265; Thu, 18 Jan 2018 04:33:21 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Paolo Bonzini , Alistair Francis , Peter Maydell , Krzysztof Kozlowski , Stefan Hajnoczi Date: Thu, 18 Jan 2018 09:32:17 -0300 Message-Id: <20180118123219.19410-16-f4bug@amsat.org> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20180118123219.19410-1-f4bug@amsat.org> References: <20180118123219.19410-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::242 Subject: [Qemu-devel] [PATCH v7 15/16] hw/arm/exynos4210: implement SDHCI Spec v2 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Edgar E . Iglesias" , Andrey Smirnov , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org, Igor Mitsyanko , Kevin O'Connor , "open list:Exynos" , Marcel Apfelbaum Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Acked-by: Alistair Francis --- Krzysztof kindly checked those values with Manaul, the Samsung datasheet :) hw/arm/exynos4210.c | 21 +++++++++++++++++++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/hw/arm/exynos4210.c b/hw/arm/exynos4210.c index e8e1d81e62..e70e234f58 100644 --- a/hw/arm/exynos4210.c +++ b/hw/arm/exynos4210.c @@ -75,7 +75,6 @@ #define EXYNOS4210_INT_COMBINER_BASE_ADDR 0x10448000 =20 /* SD/MMC host controllers */ -#define EXYNOS4210_SDHCI_CAPABILITIES 0x05E80080 #define EXYNOS4210_SDHCI_BASE_ADDR 0x12510000 #define EXYNOS4210_SDHCI_ADDR(n) (EXYNOS4210_SDHCI_BASE_ADDR + \ 0x00010000 * (n)) @@ -377,8 +376,26 @@ Exynos4210State *exynos4210_init(MemoryRegion *system_= mem) BlockBackend *blk; DriveInfo *di; =20 + /* Compatible with: + * - SD Host Controller Specification Version 2.0 + * - SDIO Specification Version 2.0 + * - MMC Specification Version 4.3 + * - SDMA + * - ADMA2 + * + * As this part of the Exynos4210 is not publically available, + * we used the "HS-MMC Controller S3C2416X RISC Microprocessor" + * public datasheet which is very similar (implementing + * MMC Specification Version 4.0 being the only difference noted) + */ dev =3D qdev_create(NULL, TYPE_SYSBUS_SDHCI); - qdev_prop_set_uint32(dev, "capareg", EXYNOS4210_SDHCI_CAPABILITIES= ); + qdev_prop_set_uint8(dev, "sd-spec-version", 2); + qdev_prop_set_uint8(dev, "timeout-freq", 0); + qdev_prop_set_uint8(dev, "max-frequency", 0); + qdev_prop_set_bit(dev, "suspend", true); + qdev_prop_set_bit(dev, "sdma", true); + qdev_prop_set_bit(dev, "adma1", false); + qdev_prop_set_bit(dev, "adma2", true); qdev_init_nofail(dev); =20 busdev =3D SYS_BUS_DEVICE(dev); --=20 2.15.1