From nobody Sun Oct 26 00:02:39 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 15162794299451019.937657989515; Thu, 18 Jan 2018 04:43:49 -0800 (PST) Received: from localhost ([::1]:56490 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ec9Xp-0000dZ-6V for importer@patchew.org; Thu, 18 Jan 2018 07:43:49 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36696) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ec9Nb-0000MJ-3e for qemu-devel@nongnu.org; Thu, 18 Jan 2018 07:33:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ec9NW-0007J8-88 for qemu-devel@nongnu.org; Thu, 18 Jan 2018 07:33:15 -0500 Received: from mail-qt0-x241.google.com ([2607:f8b0:400d:c0d::241]:45801) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ec9NW-0007It-4F for qemu-devel@nongnu.org; Thu, 18 Jan 2018 07:33:10 -0500 Received: by mail-qt0-x241.google.com with SMTP id x27so21690044qtm.12 for ; Thu, 18 Jan 2018 04:33:10 -0800 (PST) Received: from x1.local ([138.117.48.219]) by smtp.gmail.com with ESMTPSA id s12sm4489623qke.4.2018.01.18.04.33.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Jan 2018 04:33:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=EAXxeQJUrqetvk43phxLBwXXtBl3Qc9zONh5OAxnxlY=; b=b3EGd9kvXoBoM8/9YCM63lszAlJk1XGJtME1YfcJ/mpm7pRrla8pJ+bjdE1pIXzpil 3RW/CyKLWHXNlsxfvIBQ2YnHuOG1XRrtAbpR8Ql+YD/SOr32+/czWb6qdOIu0UPW73Pu F0dY6I84KmFnd2uwWNpXn82/ZIfrJyFVSzW/oKbT2EF12IKK3KWLo2zSxbXmCsOT+SA+ nSwLzfNbm4eoKs6d7MBNRpuzTWyjt+ZAxh7meNf05Lb4JHYlAZUdyuzy1M9CPI/htx6J w2IcWi7O/ov1QsX/3XIFP3XkV64y2cPNRSUqrb5hLli/XGGYMiXs5sYMmzrjWWOyZxDx lUGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=EAXxeQJUrqetvk43phxLBwXXtBl3Qc9zONh5OAxnxlY=; b=QH2bDeXrP1hYeLlL6ZbA38+CuMpUzN22jzFLvzjSiLBpRS5bhqalxTc3STFNDoQwu6 smJf9DP8AAdYdQKoewwuuXTT4zC/DqlLC/e31gtPLz7dsKtwF+2MEmQcOEmzg+nUTCEv b67LzFg7gU068UgnD58qDs7blGTuY2nqIS5yEwPgr/ldPGbhDCinShg7FHu+iPR2YplU ystCHximdjz8IQwWJtj84yCN/EBEXlkw9RclbbOcf0taeORZMEyMhCCt1rYhbfzSpw/b X5KU4ZDxd4NshGgyi9j9iDIAUdeQqEJXOpmovQfEBMYR//js4y03y5K1binbjmcF58Ww oLTQ== X-Gm-Message-State: AKwxyteJZTeXkDnXk3iNuee7vq0qwjMvLv8WtqIZj2KYwYfmjLxp+GIQ Ap0g2lECi0rSzO9jQLJ4uow= X-Google-Smtp-Source: ACJfBovvz89eYQfqhTNgw1+8eMvP4/Z+iJrFIcgh6PiD3u6llxGfHWAoHa/CljXWVFbckm1Z+Q7k+g== X-Received: by 10.55.53.21 with SMTP id c21mr41577139qka.38.1516278789695; Thu, 18 Jan 2018 04:33:09 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Paolo Bonzini , Alistair Francis , Peter Maydell , Stefan Hajnoczi Date: Thu, 18 Jan 2018 09:32:14 -0300 Message-Id: <20180118123219.19410-13-f4bug@amsat.org> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20180118123219.19410-1-f4bug@amsat.org> References: <20180118123219.19410-1-f4bug@amsat.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::241 Subject: [Qemu-devel] [PATCH v7 12/16] sdhci: Fix 64-bit ADMA2 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Edgar E . Iglesias" , Andrey Smirnov , qemu-devel@nongnu.org, Sai Pavan Boddu , Kevin O'Connor , Marcel Apfelbaum Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Sai Pavan Boddu The 64-bit ADMA address is not converted to the cpu endianes correctly. This patch fixes the issue and uses a valid mask for the attribute data. Signed-off-by: Sai Pavan Boddu [AF: Re-write commit message] Reviewed-by: Alistair Francis --- hw/sd/sdhci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c index a8663979c5..aff914009b 100644 --- a/hw/sd/sdhci.c +++ b/hw/sd/sdhci.c @@ -632,8 +632,8 @@ static void get_adma_description(SDHCIState *s, ADMADes= cr *dscr) dscr->length =3D le16_to_cpu(dscr->length); dma_memory_read(s->dma_as, entry_addr + 4, (uint8_t *)(&dscr->addr), 8); - dscr->attr =3D le64_to_cpu(dscr->attr); - dscr->attr &=3D 0xfffffff8; + dscr->addr =3D le64_to_cpu(dscr->addr); + dscr->attr &=3D (uint8_t) ~0xC0; dscr->incr =3D 12; break; } --=20 2.15.1