From nobody Tue Oct 28 01:48:48 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1516211738611686.4883378422655; Wed, 17 Jan 2018 09:55:38 -0800 (PST) Received: from localhost ([::1]:51306 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebrw1-0004Lm-Ll for importer@patchew.org; Wed, 17 Jan 2018 12:55:37 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47303) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebrj3-0000lH-MA for qemu-devel@nongnu.org; Wed, 17 Jan 2018 12:42:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ebrj1-0000Hq-MT for qemu-devel@nongnu.org; Wed, 17 Jan 2018 12:42:13 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44160) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ebrj1-0000H2-DS; Wed, 17 Jan 2018 12:42:11 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6E2762BCD; Wed, 17 Jan 2018 17:42:10 +0000 (UTC) Received: from t460s.redhat.com (ovpn-117-185.ams2.redhat.com [10.36.117.185]) by smtp.corp.redhat.com (Postfix) with ESMTP id 80FBC61F32; Wed, 17 Jan 2018 17:42:07 +0000 (UTC) From: David Hildenbrand To: qemu-s390x@nongnu.org, qemu-devel@nongnu.org Date: Wed, 17 Jan 2018 18:40:47 +0100 Message-Id: <20180117174047.6382-19-david@redhat.com> In-Reply-To: <20180117174047.6382-1-david@redhat.com> References: <20180117174047.6382-1-david@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Wed, 17 Jan 2018 17:42:10 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v2 18/18] s390x/flic: cache the common flic class in a central function X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , David Hildenbrand , Cornelia Huck , Alexander Graf , Christian Borntraeger , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" This avoids tons of conversions when handling interrupts. Signed-off-by: David Hildenbrand --- hw/intc/s390_flic.c | 13 ++++++++++++- hw/s390x/css.c | 10 +++++----- hw/s390x/virtio-ccw.c | 4 ++-- include/hw/s390x/s390_flic.h | 1 + target/s390x/interrupt.c | 6 +++--- 5 files changed, 23 insertions(+), 11 deletions(-) diff --git a/hw/intc/s390_flic.c b/hw/intc/s390_flic.c index b46c0f1bb4..a85a149c6d 100644 --- a/hw/intc/s390_flic.c +++ b/hw/intc/s390_flic.c @@ -22,6 +22,17 @@ #include "qapi/error.h" #include "hw/s390x/s390-virtio-ccw.h" =20 +S390FLICStateClass *s390_get_flic_class(S390FLICState *fs) +{ + static S390FLICStateClass *class; + + if (!class) { + /* we only have one flic device, so this is fine to cache */ + class =3D S390_FLIC_COMMON_GET_CLASS(fs); + } + return class; +} + QEMUS390FLICState *s390_get_qemu_flic(S390FLICState *fs) { static QEMUS390FLICState *flic; @@ -146,7 +157,7 @@ static int qemu_s390_inject_airq(S390FLICState *fs, uin= t8_t type, uint8_t isc, uint8_t flags) { QEMUS390FLICState *flic =3D s390_get_qemu_flic(fs); - S390FLICStateClass *fsc =3D S390_FLIC_COMMON_GET_CLASS(fs); + S390FLICStateClass *fsc =3D s390_get_flic_class(fs); bool flag =3D flags & S390_ADAPTER_SUPPRESSIBLE; uint32_t io_int_word =3D (isc << 27) | IO_INT_WORD_AI; =20 diff --git a/hw/s390x/css.c b/hw/s390x/css.c index 1c526fd7e2..301bf1772f 100644 --- a/hw/s390x/css.c +++ b/hw/s390x/css.c @@ -439,7 +439,7 @@ static int s390_io_adapter_map(AdapterInfo *adapter, ui= nt64_t map_addr, bool do_map) { S390FLICState *fs =3D s390_get_flic(); - S390FLICStateClass *fsc =3D S390_FLIC_COMMON_GET_CLASS(fs); + S390FLICStateClass *fsc =3D s390_get_flic_class(fs); =20 return fsc->io_adapter_map(fs, adapter->adapter_id, map_addr, do_map); } @@ -520,7 +520,7 @@ void css_register_io_adapters(CssIoAdapterType type, bo= ol swap, bool maskable, int ret, isc; IoAdapter *adapter; S390FLICState *fs =3D s390_get_flic(); - S390FLICStateClass *fsc =3D S390_FLIC_COMMON_GET_CLASS(fs); + S390FLICStateClass *fsc =3D s390_get_flic_class(fs); =20 /* * Disallow multiple registrations for the same device type. @@ -566,7 +566,7 @@ static void css_clear_io_interrupt(uint16_t subchannel_= id, Error *err =3D NULL; static bool no_clear_irq; S390FLICState *fs =3D s390_get_flic(); - S390FLICStateClass *fsc =3D S390_FLIC_COMMON_GET_CLASS(fs); + S390FLICStateClass *fsc =3D s390_get_flic_class(fs); int r; =20 if (unlikely(no_clear_irq)) { @@ -640,7 +640,7 @@ void css_conditional_io_interrupt(SubchDev *sch) int css_do_sic(CPUS390XState *env, uint8_t isc, uint16_t mode) { S390FLICState *fs =3D s390_get_flic(); - S390FLICStateClass *fsc =3D S390_FLIC_COMMON_GET_CLASS(fs); + S390FLICStateClass *fsc =3D s390_get_flic_class(fs); int r; =20 if (env->psw.mask & PSW_MASK_PSTATE) { @@ -666,7 +666,7 @@ out: void css_adapter_interrupt(CssIoAdapterType type, uint8_t isc) { S390FLICState *fs =3D s390_get_flic(); - S390FLICStateClass *fsc =3D S390_FLIC_COMMON_GET_CLASS(fs); + S390FLICStateClass *fsc =3D s390_get_flic_class(fs); uint32_t io_int_word =3D (isc << 27) | IO_INT_WORD_AI; IoAdapter *adapter =3D channel_subsys.io_adapters[type][isc]; =20 diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c index 3d8f26949b..8f7fbc2ab7 100644 --- a/hw/s390x/virtio-ccw.c +++ b/hw/s390x/virtio-ccw.c @@ -1111,7 +1111,7 @@ static int virtio_ccw_setup_irqroutes(VirtioCcwDevice= *dev, int nvqs) VirtIODevice *vdev =3D virtio_bus_get_device(&dev->bus); int ret; S390FLICState *fs =3D s390_get_flic(); - S390FLICStateClass *fsc =3D S390_FLIC_COMMON_GET_CLASS(fs); + S390FLICStateClass *fsc =3D s390_get_flic_class(fs); =20 ret =3D virtio_ccw_get_mappings(dev); if (ret) { @@ -1129,7 +1129,7 @@ static int virtio_ccw_setup_irqroutes(VirtioCcwDevice= *dev, int nvqs) static void virtio_ccw_release_irqroutes(VirtioCcwDevice *dev, int nvqs) { S390FLICState *fs =3D s390_get_flic(); - S390FLICStateClass *fsc =3D S390_FLIC_COMMON_GET_CLASS(fs); + S390FLICStateClass *fsc =3D s390_get_flic_class(fs); =20 fsc->release_adapter_routes(fs, &dev->routes); } diff --git a/include/hw/s390x/s390_flic.h b/include/hw/s390x/s390_flic.h index a636afce42..4687ecfe83 100644 --- a/include/hw/s390x/s390_flic.h +++ b/include/hw/s390x/s390_flic.h @@ -136,6 +136,7 @@ void s390_flic_init(void); =20 S390FLICState *s390_get_flic(void); QEMUS390FLICState *s390_get_qemu_flic(S390FLICState *fs); +S390FLICStateClass *s390_get_flic_class(S390FLICState *fs); bool ais_needed(void *opaque); =20 #endif /* HW_S390_FLIC_H */ diff --git a/target/s390x/interrupt.c b/target/s390x/interrupt.c index 1947012b25..25cfb3eef8 100644 --- a/target/s390x/interrupt.c +++ b/target/s390x/interrupt.c @@ -134,7 +134,7 @@ void cpu_inject_stop(S390CPU *cpu) void s390_sclp_extint(uint32_t parm) { S390FLICState *fs =3D s390_get_flic(); - S390FLICStateClass *fsc =3D S390_FLIC_COMMON_GET_CLASS(fs); + S390FLICStateClass *fsc =3D s390_get_flic_class(fs); =20 fsc->inject_service(fs, parm); } @@ -143,7 +143,7 @@ void s390_io_interrupt(uint16_t subchannel_id, uint16_t= subchannel_nr, uint32_t io_int_parm, uint32_t io_int_word) { S390FLICState *fs =3D s390_get_flic(); - S390FLICStateClass *fsc =3D S390_FLIC_COMMON_GET_CLASS(fs); + S390FLICStateClass *fsc =3D s390_get_flic_class(fs); =20 fsc->inject_io(fs, subchannel_id, subchannel_nr, io_int_parm, io_int_w= ord); } @@ -151,7 +151,7 @@ void s390_io_interrupt(uint16_t subchannel_id, uint16_t= subchannel_nr, void s390_crw_mchk(void) { S390FLICState *fs =3D s390_get_flic(); - S390FLICStateClass *fsc =3D S390_FLIC_COMMON_GET_CLASS(fs); + S390FLICStateClass *fsc =3D s390_get_flic_class(fs); =20 fsc->inject_crw_mchk(fs); } --=20 2.14.3