From nobody Sat Oct 25 23:38:25 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1516121321994292.80097486972613; Tue, 16 Jan 2018 08:48:41 -0800 (PST) Received: from localhost ([::1]:48219 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebUPY-0001gs-JN for importer@patchew.org; Tue, 16 Jan 2018 11:48:32 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52071) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebUNG-0000U0-B4 for qemu-devel@nongnu.org; Tue, 16 Jan 2018 11:46:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ebUNC-0008NO-MQ for qemu-devel@nongnu.org; Tue, 16 Jan 2018 11:46:10 -0500 Received: from mail-pf0-x242.google.com ([2607:f8b0:400e:c00::242]:39642) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ebUNC-0008M2-Ef for qemu-devel@nongnu.org; Tue, 16 Jan 2018 11:46:06 -0500 Received: by mail-pf0-x242.google.com with SMTP id e11so9976601pff.6 for ; Tue, 16 Jan 2018 08:46:06 -0800 (PST) Received: from cloudburst.twiddle.net.com (24-181-135-57.dhcp.knwc.wa.charter.com. [24.181.135.57]) by smtp.gmail.com with ESMTPSA id y7sm3875780pfe.48.2018.01.16.08.46.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 16 Jan 2018 08:46:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=6NsXEr3flB7sBkwFuqOd8m3pcuQPwR79IBEPep8/0tE=; b=UT1akP8bizUIqvSYHFEZz4m66sGKbgh7LxXoRkqzy9tPfxXOyslibJdlwh/PKpL0Lt iF98IGrg87bDOiZHBZfitmnzppPur3SCjMU36TksQn5LtSuKipNPgE5SzFnl4H/NY7mZ FR14aNnTMsQ4AeinjaCYpqUZUKTyZQ+BDZl1o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=6NsXEr3flB7sBkwFuqOd8m3pcuQPwR79IBEPep8/0tE=; b=OKmqiV/uHxBazk+83o2+Igg+bMwbMjaivbgj76Z3G8EMdrsmprmgYvIuVKccVeBHXl GStya8m/ibbegPpfQFmlLKPwZP4kBxNUovg/PgvPUtNFYk5E37dj1FrZFg8+tjf/ab1d PskTu0u5FkInaHSbC/ZfRPO1Ew3JNgI8aY23vyeaGVb6oaCgq2jwts4eHF0S7SUphdqJ MNTEcB4bsq5OLMiQDXppfkGXt7uepB6xps0sBlEgoU1BwD5EfBx/iyc0oUT/up4YNUIL 8NMxhcNWjo+vTrh0lzTuFon9hWw93mdZW7O5MhGsRwogq2ZSc5A3/bcEWaUlvZ737zFo JHAw== X-Gm-Message-State: AKGB3mIXGnYGrtrDMRoDmuihUYwNIQiar59A+38vPYLKxamPT6xrp4Iz AtoZJ3ODFaCd7IwQsOUpCNiF98lPFrU= X-Google-Smtp-Source: ACJfBosvO8HpYBy0gXCJPSbZ9EJCS44av9xXwxcxvnoJz+3qfGdkFYltRXJBlX79RVhhVVF5qNqiPg== X-Received: by 10.99.97.69 with SMTP id v66mr28033366pgb.307.1516121165075; Tue, 16 Jan 2018 08:46:05 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Tue, 16 Jan 2018 08:45:57 -0800 Message-Id: <20180116164600.7480-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180116164600.7480-1-richard.henderson@linaro.org> References: <20180116164600.7480-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::242 Subject: [Qemu-devel] [PULL v2 1/4] tcg/arm: Fix double-word comparisons X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The code sequence we were generating was only good for unsigned comparisons. For signed comparisions, use the sequence from gcc. Fixes booting of ppc64 firmware, with a patch changing the code sequence for ppc comparisons. Tested-by: Michael Roth Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.inc.c | 86 +++++++++++++++++++++++++++++++++-----------= ---- 1 file changed, 60 insertions(+), 26 deletions(-) diff --git a/tcg/arm/tcg-target.inc.c b/tcg/arm/tcg-target.inc.c index 98a12535a5..d7b09e8e0c 100644 --- a/tcg/arm/tcg-target.inc.c +++ b/tcg/arm/tcg-target.inc.c @@ -1103,6 +1103,56 @@ static inline void tcg_out_mb(TCGContext *s, TCGArg = a0) } } =20 +static TCGCond tcg_out_cmp2(TCGContext *s, const TCGArg *args, + const int *const_args) +{ + TCGReg al =3D args[0]; + TCGReg ah =3D args[1]; + TCGArg bl =3D args[2]; + TCGArg bh =3D args[3]; + TCGCond cond =3D args[4]; + int const_bl =3D const_args[2]; + int const_bh =3D const_args[3]; + + switch (cond) { + case TCG_COND_EQ: + case TCG_COND_NE: + case TCG_COND_LTU: + case TCG_COND_LEU: + case TCG_COND_GTU: + case TCG_COND_GEU: + /* We perform a conditional comparision. If the high half is + equal, then overwrite the flags with the comparison of the + low half. The resulting flags cover the whole. */ + tcg_out_dat_rI(s, COND_AL, ARITH_CMP, 0, ah, bh, const_bh); + tcg_out_dat_rI(s, COND_EQ, ARITH_CMP, 0, al, bl, const_bl); + return cond; + + case TCG_COND_LT: + case TCG_COND_GE: + /* We perform a double-word subtraction and examine the result. + We do not actually need the result of the subtract, so the + low part "subtract" is a compare. For the high half we have + no choice but to compute into a temporary. */ + tcg_out_dat_rI(s, COND_AL, ARITH_CMP, 0, al, bl, const_bl); + tcg_out_dat_rI(s, COND_AL, ARITH_SBC | TO_CPSR, + TCG_REG_TMP, ah, bh, const_bh); + return cond; + + case TCG_COND_LE: + case TCG_COND_GT: + /* Similar, but with swapped arguments, via reversed subtract. */ + tcg_out_dat_rI(s, COND_AL, ARITH_RSB | TO_CPSR, + TCG_REG_TMP, al, bl, const_bl); + tcg_out_dat_rI(s, COND_AL, ARITH_RSC | TO_CPSR, + TCG_REG_TMP, ah, bh, const_bh); + return tcg_swap_cond(cond); + + default: + g_assert_not_reached(); + } +} + #ifdef CONFIG_SOFTMMU #include "tcg-ldst.inc.c" =20 @@ -1964,22 +2014,6 @@ static inline void tcg_out_op(TCGContext *s, TCGOpco= de opc, tcg_out_goto_label(s, tcg_cond_to_arm_cond[args[2]], arg_label(args[3])); break; - case INDEX_op_brcond2_i32: - /* The resulting conditions are: - * TCG_COND_EQ --> a0 =3D=3D a2 && a1 =3D=3D a3, - * TCG_COND_NE --> (a0 !=3D a2 && a1 =3D=3D a3) || a1 !=3D a3, - * TCG_COND_LT(U) --> (a0 < a2 && a1 =3D=3D a3) || a1 < a3, - * TCG_COND_GE(U) --> (a0 >=3D a2 && a1 =3D=3D a3) || (a1 >=3D a3 = && a1 !=3D a3), - * TCG_COND_LE(U) --> (a0 <=3D a2 && a1 =3D=3D a3) || (a1 <=3D a3 = && a1 !=3D a3), - * TCG_COND_GT(U) --> (a0 > a2 && a1 =3D=3D a3) || a1 > a3, - */ - tcg_out_dat_rIN(s, COND_AL, ARITH_CMP, ARITH_CMN, 0, - args[1], args[3], const_args[3]); - tcg_out_dat_rIN(s, COND_EQ, ARITH_CMP, ARITH_CMN, 0, - args[0], args[2], const_args[2]); - tcg_out_goto_label(s, tcg_cond_to_arm_cond[args[4]], - arg_label(args[5])); - break; case INDEX_op_setcond_i32: tcg_out_dat_rIN(s, COND_AL, ARITH_CMP, ARITH_CMN, 0, args[1], args[2], const_args[2]); @@ -1988,15 +2022,15 @@ static inline void tcg_out_op(TCGContext *s, TCGOpc= ode opc, tcg_out_dat_imm(s, tcg_cond_to_arm_cond[tcg_invert_cond(args[3])], ARITH_MOV, args[0], 0, 0); break; + + case INDEX_op_brcond2_i32: + c =3D tcg_out_cmp2(s, args, const_args); + tcg_out_goto_label(s, tcg_cond_to_arm_cond[c], arg_label(args[5])); + break; case INDEX_op_setcond2_i32: - /* See brcond2_i32 comment */ - tcg_out_dat_rIN(s, COND_AL, ARITH_CMP, ARITH_CMN, 0, - args[2], args[4], const_args[4]); - tcg_out_dat_rIN(s, COND_EQ, ARITH_CMP, ARITH_CMN, 0, - args[1], args[3], const_args[3]); - tcg_out_dat_imm(s, tcg_cond_to_arm_cond[args[5]], - ARITH_MOV, args[0], 0, 1); - tcg_out_dat_imm(s, tcg_cond_to_arm_cond[tcg_invert_cond(args[5])], + c =3D tcg_out_cmp2(s, args + 1, const_args + 1); + tcg_out_dat_imm(s, tcg_cond_to_arm_cond[c], ARITH_MOV, args[0], 0,= 1); + tcg_out_dat_imm(s, tcg_cond_to_arm_cond[tcg_invert_cond(c)], ARITH_MOV, args[0], 0, 0); break; =20 @@ -2093,9 +2127,9 @@ static const TCGTargetOpDef *tcg_target_op_def(TCGOpc= ode op) static const TCGTargetOpDef sub2 =3D { .args_ct_str =3D { "r", "r", "rI", "rI", "rIN", "rIK" } }; static const TCGTargetOpDef br2 - =3D { .args_ct_str =3D { "r", "r", "rIN", "rIN" } }; + =3D { .args_ct_str =3D { "r", "r", "rI", "rI" } }; static const TCGTargetOpDef setc2 - =3D { .args_ct_str =3D { "r", "r", "r", "rIN", "rIN" } }; + =3D { .args_ct_str =3D { "r", "r", "r", "rI", "rI" } }; =20 switch (op) { case INDEX_op_goto_ptr: --=20 2.14.3 From nobody Sat Oct 25 23:38:25 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1516121321850648.6071145770837; Tue, 16 Jan 2018 08:48:41 -0800 (PST) Received: from localhost ([::1]:48222 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebUPd-0001od-AQ for importer@patchew.org; Tue, 16 Jan 2018 11:48:37 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52085) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebUNI-0000UJ-B5 for qemu-devel@nongnu.org; Tue, 16 Jan 2018 11:46:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ebUNE-0008Ox-31 for qemu-devel@nongnu.org; Tue, 16 Jan 2018 11:46:12 -0500 Received: from mail-pg0-x242.google.com ([2607:f8b0:400e:c05::242]:43808) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ebUND-0008Oa-Tc for qemu-devel@nongnu.org; Tue, 16 Jan 2018 11:46:08 -0500 Received: by mail-pg0-x242.google.com with SMTP id n17so2201133pgf.10 for ; Tue, 16 Jan 2018 08:46:07 -0800 (PST) Received: from cloudburst.twiddle.net.com (24-181-135-57.dhcp.knwc.wa.charter.com. [24.181.135.57]) by smtp.gmail.com with ESMTPSA id y7sm3875780pfe.48.2018.01.16.08.46.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 16 Jan 2018 08:46:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=NWl592gmcmqdqRRwvrPDTA263IuCumCkTRQeZKUCePU=; b=M/iCaZLVBDMSb5j2yXv9Cqw0Aqmudgr/z2Z4GNogS/9wys9K1jq6dQTEzMkQjnkMrQ 6MC/rfTgu/2RyI7cSRwPP5zFBLStGYebE8vh8X581ElcB4I3cneb2wZyX+DzpiOfaBca VzJbw8qJIP74UEpRQJxToo7j4udn/HVh5BXUI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=NWl592gmcmqdqRRwvrPDTA263IuCumCkTRQeZKUCePU=; b=ZCE9USZIjEaC7BqAMCiRHuFAqArQzMcFYYNTieLvSU8vqG1GqUZPr7Amr5I2k+qta0 mWS6aW/4VMNhgci6jQQwdlZvyCNd+KeBv9d6p5hN+1AHmFVCtC2S5xgnxRaborKsVQlO tR5QJYGnmoWTDAgomy8//gj5bzRLiYOjcF9IqfCmDsF0YtibnVDiE9o0xZbi9sd0oGBP rsLqjUO40s8yqJ2oSj6fwBt/d100llNgG0FYulGaP99NEqH9YxQd82oFfkGDyVburkUX BZUiUSDw0Qq2gkcAKOwXonTdXcNJnvubB1vt99rt8BgI7ygbuJ0FQSkoKZkwMX+DCkYU r3Ag== X-Gm-Message-State: AKwxytdj49WZyv9ffj2I6+/KqNRiNX9bOfDDVE6g3sGJKoJutlTYHwqW BIIzm7KIc/COCi8MsQhgMjRT5uDrARM= X-Google-Smtp-Source: ACJfBotQ6Wz/xjOD4SYSx7OqYbvz9E6XeUt/D8qMe1FGfIRzmMH170NU3t3203YLR2UyTY7L/EtQaQ== X-Received: by 10.101.75.81 with SMTP id k17mr208568pgt.335.1516121166510; Tue, 16 Jan 2018 08:46:06 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Tue, 16 Jan 2018 08:45:58 -0800 Message-Id: <20180116164600.7480-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180116164600.7480-1-richard.henderson@linaro.org> References: <20180116164600.7480-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c05::242 Subject: [Qemu-devel] [PULL v2 2/4] tcg/arm: Support tlb offsets larger than 64k X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" AArch64 with SVE has an offset of 80k to the 8th TLB. Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.inc.c | 30 +++++++++++++++++------------- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/tcg/arm/tcg-target.inc.c b/tcg/arm/tcg-target.inc.c index d7b09e8e0c..dc83f3e5be 100644 --- a/tcg/arm/tcg-target.inc.c +++ b/tcg/arm/tcg-target.inc.c @@ -1247,12 +1247,6 @@ static TCGReg tcg_out_arg_reg64(TCGContext *s, TCGRe= g argreg, /* We're expecting to use an 8-bit immediate and to mask. */ QEMU_BUILD_BUG_ON(CPU_TLB_BITS > 8); =20 -/* We're expecting to use an 8-bit immediate add + 8-bit ldrd offset. - Using the offset of the second entry in the last tlb table ensures - that we can index all of the elements of the first entry. */ -QEMU_BUILD_BUG_ON(offsetof(CPUArchState, tlb_table[NB_MMU_MODES - 1][1]) - > 0xffff); - /* Load and compare a TLB entry, leaving the flags set. Returns the regis= ter containing the addend of the tlb entry. Clobbers R0, R1, R2, TMP. */ =20 @@ -1265,6 +1259,7 @@ static TCGReg tcg_out_tlb_read(TCGContext *s, TCGReg = addrlo, TCGReg addrhi, ? offsetof(CPUArchState, tlb_table[mem_index][0].addr_read) : offsetof(CPUArchState, tlb_table[mem_index][0].addr_write)); int add_off =3D offsetof(CPUArchState, tlb_table[mem_index][0].addend); + int mask_off; unsigned s_bits =3D opc & MO_SIZE; unsigned a_bits =3D get_alignment_bits(opc); =20 @@ -1296,16 +1291,25 @@ static TCGReg tcg_out_tlb_read(TCGContext *s, TCGRe= g addrlo, TCGReg addrhi, 0, addrlo, SHIFT_IMM_LSR(TARGET_PAGE_BITS)); } =20 - /* We checked that the offset is contained within 16 bits above. */ - if (add_off > 0xfff - || (use_armv6_instructions && TARGET_LONG_BITS =3D=3D 64 - && cmp_off > 0xff)) { + /* Add portions of the offset until the memory access is in range. + * If we plan on using ldrd, reduce to an 8-bit offset; otherwise + * we can use a 12-bit offset. */ + if (use_armv6_instructions && TARGET_LONG_BITS =3D=3D 64) { + mask_off =3D 0xff; + } else { + mask_off =3D 0xfff; + } + while (cmp_off > mask_off) { + int shift =3D ctz32(cmp_off & ~mask_off) & ~1; + int rot =3D ((32 - shift) << 7) & 0xf00; + int addend =3D cmp_off & (0xff << shift); tcg_out_dat_imm(s, COND_AL, ARITH_ADD, TCG_REG_R2, base, - (24 << 7) | (cmp_off >> 8)); + rot | ((cmp_off >> shift) & 0xff)); base =3D TCG_REG_R2; - add_off -=3D cmp_off & 0xff00; - cmp_off &=3D 0xff; + add_off -=3D addend; + cmp_off -=3D addend; } + if (!use_armv7_instructions) { tcg_out_dat_imm(s, COND_AL, ARITH_AND, TCG_REG_R0, TCG_REG_TMP, CPU_TLB_SIZE - 1); --=20 2.14.3 From nobody Sat Oct 25 23:38:25 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1516121323280340.73897684432154; Tue, 16 Jan 2018 08:48:43 -0800 (PST) Received: from localhost ([::1]:48220 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebUPb-0001nc-G5 for importer@patchew.org; Tue, 16 Jan 2018 11:48:35 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52101) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebUNJ-0000Ur-5R for qemu-devel@nongnu.org; Tue, 16 Jan 2018 11:46:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ebUNF-0008Q3-BE for qemu-devel@nongnu.org; Tue, 16 Jan 2018 11:46:13 -0500 Received: from mail-pg0-x243.google.com ([2607:f8b0:400e:c05::243]:46917) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ebUNF-0008PI-6O for qemu-devel@nongnu.org; Tue, 16 Jan 2018 11:46:09 -0500 Received: by mail-pg0-x243.google.com with SMTP id s9so7958782pgq.13 for ; Tue, 16 Jan 2018 08:46:09 -0800 (PST) Received: from cloudburst.twiddle.net.com (24-181-135-57.dhcp.knwc.wa.charter.com. [24.181.135.57]) by smtp.gmail.com with ESMTPSA id y7sm3875780pfe.48.2018.01.16.08.46.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 16 Jan 2018 08:46:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=RkJQxOnAGP0/1GM4j5AhPbVm0ZbUL4Gx9Je9FrSasnc=; b=RLJIVa0WSpIBt4SM+ANf6dOPk3+HoICkMDWXQ4mQo6vmIv0vgsL3FsaKq0aNbAC5Jo oWVgPHBWBaf1E4wh/Tas6+LsP3mPWbugpEipvSni/engOU+/o63tto4VTSu9/VVYSMvC Xo7+0+9HvnU6wiC2z7hXulEWpvVewc4kdweYY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=RkJQxOnAGP0/1GM4j5AhPbVm0ZbUL4Gx9Je9FrSasnc=; b=ovH3BC5nBKchT8I6DmpPVaOOBItparsDY/+V1oNMfZ+lA9XTZpIIyELTOWcfskyFSz 6j4IsEedjgbHIT8/tVbA6RyR5mRAxH8RML5uj5JEYDHnXRh64a8x21j1/thnjrbO13RT WW8kIt/6flDKlfKo1huPFkbMr3aGEssrncclO11N9z2I7CKbJB9zyJiQeKcQXHJW2BIT BavhyWAi2bBSqWAhZvsr1Tw025EK8wPYsMI7MjijBX6c4D3jca4mlUYIhsDYK7RgzwsL jDpMc9d63l9xq0quQTCK7tDRuUqE6DDKNa+kpIWxBBZIoDTnajrJH1V80FeMEXqukGdZ cDRg== X-Gm-Message-State: AKwxytfTOaSsPUVKHuerd6nt6sBnmy1ptLoQ0wXACwLJXhty1utZLzyT ISmS+3CG6DKuoQ48lBBCFwv67QPqjto= X-Google-Smtp-Source: ACJfBos+bhSk8BdzFQ9n0Mi5+xnJAWRqoBTIVOr1LBgRoIlDv3siCbmZw16OffIo+U9u/CFZlSe6AA== X-Received: by 10.99.140.18 with SMTP id m18mr13221786pgd.59.1516121167879; Tue, 16 Jan 2018 08:46:07 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Tue, 16 Jan 2018 08:45:59 -0800 Message-Id: <20180116164600.7480-4-richard.henderson@linaro.org> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180116164600.7480-1-richard.henderson@linaro.org> References: <20180116164600.7480-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c05::243 Subject: [Qemu-devel] [PULL v2 3/4] tcg/ppc: Support tlb offsets larger than 64k X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" AArch64 with SVE has an offset of 80k to the 8th TLB. Signed-off-by: Richard Henderson --- tcg/ppc/tcg-target.inc.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/tcg/ppc/tcg-target.inc.c b/tcg/ppc/tcg-target.inc.c index 879885b68b..74f9b4aa34 100644 --- a/tcg/ppc/tcg-target.inc.c +++ b/tcg/ppc/tcg-target.inc.c @@ -1524,16 +1524,15 @@ static TCGReg tcg_out_tlb_read(TCGContext *s, TCGMe= mOp opc, =20 /* Compensate for very large offsets. */ if (add_off >=3D 0x8000) { - /* Most target env are smaller than 32k; none are larger than 64k. - Simplify the logic here merely to offset by 0x7ff0, giving us a - range just shy of 64k. Check this assumption. */ - QEMU_BUILD_BUG_ON(offsetof(CPUArchState, - tlb_table[NB_MMU_MODES - 1][1]) - > 0x7ff0 + 0x7fff); - tcg_out32(s, ADDI | TAI(TCG_REG_TMP1, base, 0x7ff0)); + int low =3D (int16_t)cmp_off; + int high =3D cmp_off - low; + assert((high & 0xffff) =3D=3D 0); + assert(cmp_off - high =3D=3D (int16_t)(cmp_off - high)); + assert(add_off - high =3D=3D (int16_t)(add_off - high)); + tcg_out32(s, ADDIS | TAI(TCG_REG_TMP1, base, high >> 16)); base =3D TCG_REG_TMP1; - cmp_off -=3D 0x7ff0; - add_off -=3D 0x7ff0; + cmp_off -=3D high; + add_off -=3D high; } =20 /* Extraction and shifting, part 2. */ --=20 2.14.3 From nobody Sat Oct 25 23:38:25 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1516121321848814.8287159195481; Tue, 16 Jan 2018 08:48:41 -0800 (PST) Received: from localhost ([::1]:48221 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebUPc-0001oP-Kt for importer@patchew.org; Tue, 16 Jan 2018 11:48:36 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52087) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebUNI-0000UL-D4 for qemu-devel@nongnu.org; Tue, 16 Jan 2018 11:46:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ebUNH-0008RK-8s for qemu-devel@nongnu.org; Tue, 16 Jan 2018 11:46:12 -0500 Received: from mail-pl0-x242.google.com ([2607:f8b0:400e:c01::242]:41196) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ebUNH-0008Qp-2J for qemu-devel@nongnu.org; Tue, 16 Jan 2018 11:46:11 -0500 Received: by mail-pl0-x242.google.com with SMTP id q3so6573727plr.8 for ; Tue, 16 Jan 2018 08:46:10 -0800 (PST) Received: from cloudburst.twiddle.net.com (24-181-135-57.dhcp.knwc.wa.charter.com. [24.181.135.57]) by smtp.gmail.com with ESMTPSA id y7sm3875780pfe.48.2018.01.16.08.46.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 16 Jan 2018 08:46:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=FUUWRYtwa278VZrUKwI2J5+6Tu8CghM2hw9X/xV8zwA=; b=QG6ttO9JU1DNfAmlIpgrCexIAQNBb/Su2KM4PYX6IAnN6/CrAHq5oXkAyhyO7AsxpG 3ef5so/sdcK84qVIwH2av0te20mZioWwzZqTWh3SDTolZ64U6dxVa0M5H5FeUfRq+l+o wMvlH7RFyiYciz41S7GHv/jNtJv1K4PevQuo4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=FUUWRYtwa278VZrUKwI2J5+6Tu8CghM2hw9X/xV8zwA=; b=iBgdrQsj80NO4HKWKYtpIGC/6acLG+ml80GULOVy5OnZpNkJFc6Zfhy0hykeHkyg6Y yDDExm0pRDPIXOUjyW93j8SD5p2HtCwrcFLLfT54BOmJ3vETIFTNFB9VOB7J7v3KoWJJ inLS6aOsJNwsGIChCmLo7yutAOHs6XTEcBHjvzVrRJzu4BGCmiRKk4rKg+uHt+oWUdsa GxXTFtEdzaC7w/yMXhDXi8ymiTFD3BeOQV9ow2TkCCT3wjZkzkO5SgGOIn64iFS0EtXS 412m4xN5i1OuLhnAlqOhWUCbkYvs7BqGr8g+z6WS9VVcRWc/ov41u9iypC0pdNLoHKCo 4RUQ== X-Gm-Message-State: AKGB3mLC6JHNXW+un4liBeTavmxRBCQebukhKgT1jAD+patVmenj8DK1 ibsKDIY3K8BiQcmggmZDu+rJ10f3w6k= X-Google-Smtp-Source: ACJfBovhsQyK2tW/seEUFEfZ6lu2fQLL8/hzWMslBg5qwpu30jprZx2Ux98OW5U7QoWUx15+/w29rA== X-Received: by 10.84.151.70 with SMTP id i64mr40148525pli.337.1516121169671; Tue, 16 Jan 2018 08:46:09 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Tue, 16 Jan 2018 08:46:00 -0800 Message-Id: <20180116164600.7480-5-richard.henderson@linaro.org> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180116164600.7480-1-richard.henderson@linaro.org> References: <20180116164600.7480-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c01::242 Subject: [Qemu-devel] [PULL v2 4/4] tcg/ppc: Allow a 32-bit offset to the constant pool X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" We recently relaxed the limit of the number of opcodes that can appear in a TranslationBlock. In certain cases this has resulted in relocation overflow. Signed-off-by: Richard Henderson --- tcg/ppc/tcg-target.inc.c | 67 ++++++++++++++++++++++++++++----------------= ---- 1 file changed, 39 insertions(+), 28 deletions(-) diff --git a/tcg/ppc/tcg-target.inc.c b/tcg/ppc/tcg-target.inc.c index 74f9b4aa34..86f7de5f7e 100644 --- a/tcg/ppc/tcg-target.inc.c +++ b/tcg/ppc/tcg-target.inc.c @@ -222,33 +222,6 @@ static inline void tcg_out_bc_noaddr(TCGContext *s, in= t insn) tcg_out32(s, insn | retrans); } =20 -static void patch_reloc(tcg_insn_unit *code_ptr, int type, - intptr_t value, intptr_t addend) -{ - tcg_insn_unit *target; - tcg_insn_unit old; - - value +=3D addend; - target =3D (tcg_insn_unit *)value; - - switch (type) { - case R_PPC_REL14: - reloc_pc14(code_ptr, target); - break; - case R_PPC_REL24: - reloc_pc24(code_ptr, target); - break; - case R_PPC_ADDR16: - assert(value =3D=3D (int16_t)value); - old =3D *code_ptr; - old =3D deposit32(old, 0, 16, value); - *code_ptr =3D old; - break; - default: - tcg_abort(); - } -} - /* parse target specific constraints */ static const char *target_parse_constraint(TCGArgConstraint *ct, const char *ct_str, TCGType typ= e) @@ -552,6 +525,43 @@ static const uint32_t tcg_to_isel[] =3D { [TCG_COND_GTU] =3D ISEL | BC_(7, CR_GT), }; =20 +static void patch_reloc(tcg_insn_unit *code_ptr, int type, + intptr_t value, intptr_t addend) +{ + tcg_insn_unit *target; + tcg_insn_unit old; + + value +=3D addend; + target =3D (tcg_insn_unit *)value; + + switch (type) { + case R_PPC_REL14: + reloc_pc14(code_ptr, target); + break; + case R_PPC_REL24: + reloc_pc24(code_ptr, target); + break; + case R_PPC_ADDR16: + /* We are abusing this relocation type. This points to a pair + of insns, addis + load. If the displacement is small, we + can nop out the addis. */ + if (value =3D=3D (int16_t)value) { + code_ptr[0] =3D NOP; + old =3D deposit32(code_ptr[1], 0, 16, value); + code_ptr[1] =3D deposit32(old, 16, 5, TCG_REG_TB); + } else { + int16_t lo =3D value; + int hi =3D value - lo; + assert(hi + lo =3D=3D value); + code_ptr[0] =3D deposit32(code_ptr[0], 0, 16, hi >> 16); + code_ptr[1] =3D deposit32(code_ptr[1], 0, 16, lo); + } + break; + default: + g_assert_not_reached(); + } +} + static void tcg_out_mem_long(TCGContext *s, int opi, int opx, TCGReg rt, TCGReg base, tcg_target_long offset); =20 @@ -690,7 +700,8 @@ static void tcg_out_movi_int(TCGContext *s, TCGType typ= e, TCGReg ret, if (!in_prologue && USE_REG_TB) { new_pool_label(s, arg, R_PPC_ADDR16, s->code_ptr, -(intptr_t)s->code_gen_ptr); - tcg_out32(s, LD | TAI(ret, TCG_REG_TB, 0)); + tcg_out32(s, ADDIS | TAI(ret, TCG_REG_TB, 0)); + tcg_out32(s, LD | TAI(ret, ret, 0)); return; } =20 --=20 2.14.3