From nobody Tue Oct 28 01:52:09 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1516118262948570.7239612063794; Tue, 16 Jan 2018 07:57:42 -0800 (PST) Received: from localhost ([::1]:43329 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebTcM-0007Ci-4v for importer@patchew.org; Tue, 16 Jan 2018 10:57:42 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41126) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebSwy-0000lh-Nw for qemu-devel@nongnu.org; Tue, 16 Jan 2018 10:14:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ebSwv-0003vQ-Lk for qemu-devel@nongnu.org; Tue, 16 Jan 2018 10:14:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53034) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ebSwv-0003v2-Fj for qemu-devel@nongnu.org; Tue, 16 Jan 2018 10:14:53 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8B3CF32FA0; Tue, 16 Jan 2018 15:14:52 +0000 (UTC) Received: from localhost (ovpn-112-58.ams2.redhat.com [10.36.112.58]) by smtp.corp.redhat.com (Postfix) with ESMTP id EDDE97E240; Tue, 16 Jan 2018 15:13:55 +0000 (UTC) From: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= To: qemu-devel@nongnu.org Date: Tue, 16 Jan 2018 16:11:51 +0100 Message-Id: <20180116151152.4040-3-marcandre.lureau@redhat.com> In-Reply-To: <20180116151152.4040-1-marcandre.lureau@redhat.com> References: <20180116151152.4040-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Tue, 16 Jan 2018 15:14:52 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 2/3] build-sys: add --enable-sanitizers X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pbonzini@redhat.com, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , stefanha@redhat.com, peter.maydell@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Typical slowdown introduced by AddressSanitizer is 2x. UBSan shouldn't have much impact on runtime cost. Enable it by default when --enable-debug, unless --disable-sanitizers. Signed-off-by: Marc-Andr=C3=A9 Lureau --- configure | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) diff --git a/configure b/configure index 6d8c996c62..9a435917cc 100755 --- a/configure +++ b/configure @@ -342,6 +342,7 @@ rdma=3D"" gprof=3D"no" debug_tcg=3D"no" debug=3D"no" +sanitizers=3D"" fortify_source=3D"" strip_opt=3D"yes" tcg_interpreter=3D"no" @@ -994,6 +995,10 @@ for opt do strip_opt=3D"no" fortify_source=3D"no" ;; + --enable-sanitizers) sanitizers=3D"yes" + ;; + --disable-sanitizers) sanitizers=3D"no" + ;; --enable-sparse) sparse=3D"yes" ;; --disable-sparse) sparse=3D"no" @@ -1471,6 +1476,7 @@ Advanced options (experts only): --firmwarepath=3DPATH search PATH for firmware files --with-confsuffix=3DSUFFIX suffix for QEMU data inside datadir/libdir/sy= sconfdir [$confsuffix] --enable-debug enable common debug build options + --enable-sanitizers enable default sanitizers --disable-strip disable stripping binaries --disable-werror disable compilation abort on warning --disable-stack-protector disable compiler-provided stack protection @@ -5185,6 +5191,28 @@ if compile_prog "" "" ; then have_utmpx=3Dyes fi =20 +########################################## +# checks for sanitizers + +write_c_skeleton + +have_asan=3Dno +have_ubsan=3Dno + +# enable sanitizers by default if --enable-debug +if test "$sanitizers" =3D "" -a "$debug" =3D "yes"; then + sanitizers=3Dyes +fi + +if test "$sanitizers" =3D "yes" ; then + if compile_prog "$CPU_CFLAGS -Werror -fsanitize=3Daddress" ""; then + have_asan=3Dyes + fi + if compile_prog "$CPU_CFLAGS -Werror -fsanitize=3Dundefined" ""; then + have_ubsan=3Dyes + fi +fi + ########################################## # End of CC checks # After here, no more $cc or $ld runs @@ -5209,6 +5237,13 @@ else CFLAGS=3D"-O2 $CFLAGS" fi =20 +if test "$have_asan" =3D "yes"; then + CFLAGS=3D"-fsanitize=3Daddress $CFLAGS" +fi +if test "$have_ubsan" =3D "yes"; then + CFLAGS=3D"-fsanitize=3Dundefined $CFLAGS" +fi + ########################################## # Do we have libnfs if test "$libnfs" !=3D "no" ; then --=20 2.16.0.rc1.1.gef27df75a1