From nobody Tue Oct 28 01:56:33 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1515705291309455.7639097575958; Thu, 11 Jan 2018 13:14:51 -0800 (PST) Received: from localhost ([::1]:42629 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eZkBW-0004NH-EY for importer@patchew.org; Thu, 11 Jan 2018 16:14:50 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59756) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eZjva-00073T-6f for qemu-devel@nongnu.org; Thu, 11 Jan 2018 15:58:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eZjvZ-0003Pl-AO for qemu-devel@nongnu.org; Thu, 11 Jan 2018 15:58:22 -0500 Received: from mail-qt0-x241.google.com ([2607:f8b0:400d:c0d::241]:46868) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eZjvZ-0003PA-6h; Thu, 11 Jan 2018 15:58:21 -0500 Received: by mail-qt0-x241.google.com with SMTP id r39so3554680qtr.13; Thu, 11 Jan 2018 12:58:21 -0800 (PST) Received: from x1.local ([138.117.48.219]) by smtp.gmail.com with ESMTPSA id c1sm12818399qta.52.2018.01.11.12.58.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 Jan 2018 12:58:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ydqMLYPL8mZf4X4L58+PNGmXrTS2z41Avy1lgtju11k=; b=F0ni6o6zDd3Ov4cjBVnoHV5rIdZ4mkejdqJDyoLgtPfuJgIAqg8NTPop0VwKkH1Vuj R2z4UdUuzjhyEdwoh0KtyD3wq4zvT0J8QtDXTRtUZE3DVIVSb0RfZDHoJi0hFc73uJna a+7rHlAJdLKlZF0arFcBU/Evac1fhaGhTBMXuPJUt5YVlZZheM1TP+t4s+mfmZdgTnKV rkqRp6qlbuM2L1UsYYXM+Yzeadek/fe6Z/w0pzo1HWXjXb5RY2kI39DAQACnAx67Bs3n xw2tIJQsiP/fwamj9tIUz0EZt44FamvRisaOUeqT6Y0VpAt1VTED2Fm4rcJ+D7F7TSt8 9Zyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=ydqMLYPL8mZf4X4L58+PNGmXrTS2z41Avy1lgtju11k=; b=kEIcydRmA9qXszcdyKEmj0GZSSlIvuw2oZLn4fNoUz3amlzIHEDC0Do6KGnrJegdn+ AeBixwVaiNkn95QrlkQ7JTX2VbT7e2g0s8EdWeJ7XUMRRImwJF7QXMXdUPM6bFw9tEtf UZEKuClx9+pIpbA9+k2ojILDQRxBXosQeXin4CBaOWmRj0IStOGHwDAvd0DHAfhDxRw4 kMcSNP3UF9H25+lvWqYoOKH3eh9AwDnHdQtyj7LR9fPqBTyqq6e2CQXOZeXGK4qgEqVD aPmUP8hRnSG8jXQb55OdL/d5OzNvqytkGUhHskS34JCdHv6dd/E6TBUm3P5gefp9VBG8 +YyQ== X-Gm-Message-State: AKwxytcF3ybcJzDPOQ7D2bj0gnQlwo+LgBN4XKgMdN8eFKWqjwyEdmBI X5/QI88LokmaEFzj+HKVzog= X-Google-Smtp-Source: ACJfBovXAa1lO+Kpu2YdiFdEk0CzD3VyzOk9uCHOA8xPjyUG6UhEqW6mwESVjcUuLHVfJxLzSAK8IQ== X-Received: by 10.237.49.195 with SMTP id 61mr34438774qth.27.1515704300621; Thu, 11 Jan 2018 12:58:20 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Alistair Francis , Peter Maydell , Andrey Smirnov , Igor Mitsyanko Date: Thu, 11 Jan 2018 17:56:24 -0300 Message-Id: <20180111205626.23291-20-f4bug@amsat.org> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20180111205626.23291-1-f4bug@amsat.org> References: <20180111205626.23291-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::241 Subject: [Qemu-devel] [PATCH v6 19/21] sdbus: add trace events X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Edgar E . Iglesias" , Prasad J Pandit , =?UTF-8?q?Gr=C3=A9gory=20Estrade?= , qemu-devel@nongnu.org, Peter Crosthwaite , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Krzysztof Kozlowski , Jean-Christophe Dubois , Sai Pavan Boddu , qemu-arm@nongnu.org, Clement Deschamps , Andrew Baumann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis --- hw/sd/core.c | 14 ++++++++++++-- hw/sd/trace-events | 5 +++++ 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/hw/sd/core.c b/hw/sd/core.c index 295dc44ab7..498284f109 100644 --- a/hw/sd/core.c +++ b/hw/sd/core.c @@ -23,6 +23,12 @@ #include "hw/qdev-core.h" #include "sysemu/block-backend.h" #include "hw/sd/sd.h" +#include "trace.h" + +static inline const char *sdbus_name(SDBus *sdbus) +{ + return sdbus->qbus.name; +} =20 static SDState *get_card(SDBus *sdbus) { @@ -39,6 +45,7 @@ int sdbus_do_command(SDBus *sdbus, SDRequest *req, uint8_= t *response) { SDState *card =3D get_card(sdbus); =20 + trace_sdbus_command(sdbus_name(sdbus), req->cmd, req->arg, req->crc); if (card) { SDCardClass *sc =3D SD_CARD_GET_CLASS(card); =20 @@ -52,6 +59,7 @@ void sdbus_write_data(SDBus *sdbus, uint8_t value) { SDState *card =3D get_card(sdbus); =20 + trace_sdbus_write(sdbus_name(sdbus), value); if (card) { SDCardClass *sc =3D SD_CARD_GET_CLASS(card); =20 @@ -62,14 +70,16 @@ void sdbus_write_data(SDBus *sdbus, uint8_t value) uint8_t sdbus_read_data(SDBus *sdbus) { SDState *card =3D get_card(sdbus); + uint8_t value =3D 0; =20 if (card) { SDCardClass *sc =3D SD_CARD_GET_CLASS(card); =20 - return sc->read_data(card); + value =3D sc->read_data(card); } + trace_sdbus_read(sdbus_name(sdbus), value); =20 - return 0; + return value; } =20 bool sdbus_data_ready(SDBus *sdbus) diff --git a/hw/sd/trace-events b/hw/sd/trace-events index 0a121156a3..c0f51f11d4 100644 --- a/hw/sd/trace-events +++ b/hw/sd/trace-events @@ -1,5 +1,10 @@ # See docs/devel/tracing.txt for syntax documentation. =20 +# hw/sd/core.c +sdbus_command(const char *bus_name, uint8_t cmd, uint32_t arg, uint8_t crc= ) "@%s CMD%02d arg 0x%08x crc 0x%02x" +sdbus_read(const char *bus_name, uint8_t value) "@%s value 0x%02x" +sdbus_write(const char *bus_name, uint8_t value) "@%s value 0x%02x" + # hw/sd/sdhci.c sdhci_set_inserted(const char *level) "card state changed: %s" sdhci_send_command(uint8_t cmd, uint32_t arg) "CMD%02u ARG[0x%08x]" --=20 2.15.1