From nobody Tue Oct 28 01:56:36 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1515704946547550.7578656326851; Thu, 11 Jan 2018 13:09:06 -0800 (PST) Received: from localhost ([::1]:42416 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eZk5x-0007Wq-Ml for importer@patchew.org; Thu, 11 Jan 2018 16:09:05 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59336) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eZjv1-00069H-Gw for qemu-devel@nongnu.org; Thu, 11 Jan 2018 15:57:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eZjv0-0002sJ-MM for qemu-devel@nongnu.org; Thu, 11 Jan 2018 15:57:47 -0500 Received: from mail-qt0-x241.google.com ([2607:f8b0:400d:c0d::241]:46865) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eZjv0-0002rz-HG; Thu, 11 Jan 2018 15:57:46 -0500 Received: by mail-qt0-x241.google.com with SMTP id r39so3552650qtr.13; Thu, 11 Jan 2018 12:57:46 -0800 (PST) Received: from x1.local ([138.117.48.219]) by smtp.gmail.com with ESMTPSA id c1sm12818399qta.52.2018.01.11.12.57.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 Jan 2018 12:57:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TO+UjhDYmNYUT5347vMorHWZVMV/hSTmwoKB3PiqHqE=; b=hdLI0xPnnBDFOVSEt32T+1EzwwZ0Gni3V7axs1lDLJKSjxm1ZG3h+WuY+NI91ukdvR 7lGnMuxe7x0joRwkMvSp5JVpzev95tWRJvk4A/494P6MgXX7kQKdvhHFqJGRiwXUC3ix AzsatmB4JZQwNz5YotGXfGN1U9G0gyBmAlMq2bWTXI2gVBP2vUtaEqfoak1mtw/CKTPp 2wvf721afDDhuXwNWEk0xZ8YPBdQ/qeWGfeEBbADlIcORUWZYLClp5BmA/alogSmhEpv pstvKxaUxmf2QXOqxXL4YxWdIuacKyxXVlBEbEHxMCgz0vWkCaTTTdq6LmLDUT6lRjRc Hgxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=TO+UjhDYmNYUT5347vMorHWZVMV/hSTmwoKB3PiqHqE=; b=qgDumqkj0/nZ8k4vcDb65RhgPcveWxqy5O5N8o9nTgl01E+Tvs9WBJiXbBCI1wGhuP E4DLpbO5m6OHDOiUHPs3oSxiWLMPnLIjeY9dnG8dKKA/QMgfCSFAMJpq/a2Ig/k2uRVd 93Fn2Ck8sJONnuhD8JsOGiBrAFJe2KYxjcr30VILbqtFYmPpDP7z0qQujufsFBvYq0px VX+gx2edpFvZOiMN9Yb4kJ1gEdC2mV9sqx1D7hjvSxfYJiYEQVD662bNWb2joY43SlPU 6zc2jbMv5Q53/8TccJtFDm56YJs3KaCbR4vM5UnZYMq0SP5k/7yo5YkekJeSMOkpQ3Vl GuzA== X-Gm-Message-State: AKwxyteWLiCdARdzSVICYVtRUlAWYL10xlKb4H1qHtRjk5iUXUtLqC6y CcmUs/gZGKw5u2ryb1LFUd4= X-Google-Smtp-Source: ACJfBotMPf+0nSQ7jXJKROI8S9VwSjifdSlsu+57BW+d8w5Vkm9FZr1O2DLldfRX+clbCriH9d5O7Q== X-Received: by 10.200.24.18 with SMTP id q18mr33205311qtj.210.1515704265975; Thu, 11 Jan 2018 12:57:45 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Alistair Francis , Peter Maydell , Andrey Smirnov , Igor Mitsyanko Date: Thu, 11 Jan 2018 17:56:17 -0300 Message-Id: <20180111205626.23291-13-f4bug@amsat.org> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20180111205626.23291-1-f4bug@amsat.org> References: <20180111205626.23291-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::241 Subject: [Qemu-devel] [PATCH v6 12/21] hw/arm/bcm2835_peripherals: implement SDHCI Spec v3 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Edgar E . Iglesias" , Prasad J Pandit , =?UTF-8?q?Gr=C3=A9gory=20Estrade?= , qemu-devel@nongnu.org, Peter Crosthwaite , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Krzysztof Kozlowski , Jean-Christophe Dubois , Sai Pavan Boddu , qemu-arm@nongnu.org, Clement Deschamps , Andrew Baumann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/arm/bcm2835_peripherals.c | 32 +++++++++++++++++++++----------- 1 file changed, 21 insertions(+), 11 deletions(-) diff --git a/hw/arm/bcm2835_peripherals.c b/hw/arm/bcm2835_peripherals.c index 12e0dd11af..79d680cb1b 100644 --- a/hw/arm/bcm2835_peripherals.c +++ b/hw/arm/bcm2835_peripherals.c @@ -18,9 +18,6 @@ /* Peripheral base address on the VC (GPU) system bus */ #define BCM2835_VC_PERI_BASE 0x7e000000 =20 -/* Capabilities for SD controller: no DMA, high-speed, default clocks etc.= */ -#define BCM2835_SDHC_CAPAREG 0x52034b4 - static void bcm2835_peripherals_init(Object *obj) { BCM2835PeripheralState *s =3D BCM2835_PERIPHERALS(obj); @@ -254,14 +251,27 @@ static void bcm2835_peripherals_realize(DeviceState *= dev, Error **errp) memory_region_add_subregion(&s->peri_mr, RNG_OFFSET, sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->rng), 0)); =20 - /* Extended Mass Media Controller */ - object_property_set_int(OBJECT(&s->sdhci), BCM2835_SDHC_CAPAREG, "capa= reg", - &err); - if (err) { - error_propagate(errp, err); - return; - } - + /* Extended Mass Media Controller + * + * Compatible with: + * - SD Host Controller Specification Version 3.0 Draft 1.0 + * - SDIO Specification Version 3.0 + * - MMC Specification Version 4.4 + * + * - 32-bit access only + * - default clocks + * - no DMA + * - SD high-speed (SDHS) card + * - maximum block size: 1kB + * + * For the exact details please refer to the Arasan documentation: + * SD3.0_Host_AHB_eMMC4.4_Usersguide_ver5.9_jan11_10.pdf =C2=AF\_(= =E3=83=84)_/=C2=AF + */ + object_property_set_uint(OBJECT(&s->sdhci), 3, "sd-spec-version", &err= ); + object_property_set_uint(OBJECT(&s->sdhci), 52, "timeout-freq", &err); + object_property_set_uint(OBJECT(&s->sdhci), 52, "max-frequency", &err); + object_property_set_bool(OBJECT(&s->sdhci), false, "adma1", &err); + object_property_set_bool(OBJECT(&s->sdhci), true, "1v8", &err); object_property_set_bool(OBJECT(&s->sdhci), true, "pending-insert-quir= k", &err); if (err) { --=20 2.15.1