From nobody Mon Feb 9 12:48:13 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1515379897767580.0583145129843; Sun, 7 Jan 2018 18:51:37 -0800 (PST) Received: from localhost ([::1]:59354 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eYNXE-00029w-VC for importer@patchew.org; Sun, 07 Jan 2018 21:51:37 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51393) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eYNSa-0006vb-JV for qemu-devel@nongnu.org; Sun, 07 Jan 2018 21:46:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eYNSZ-0002Vh-GX for qemu-devel@nongnu.org; Sun, 07 Jan 2018 21:46:48 -0500 Received: from mail-qk0-x244.google.com ([2607:f8b0:400d:c09::244]:44107) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eYNSZ-0002VY-Cq for qemu-devel@nongnu.org; Sun, 07 Jan 2018 21:46:47 -0500 Received: by mail-qk0-x244.google.com with SMTP id v188so12535823qkh.11 for ; Sun, 07 Jan 2018 18:46:47 -0800 (PST) Received: from x1.local ([138.117.48.219]) by smtp.gmail.com with ESMTPSA id d10sm7156245qkg.16.2018.01.07.18.46.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 07 Jan 2018 18:46:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XDFVDszPM59jDh1dUr6/6FsEEUzm7pgA8ycgI6wOzf0=; b=Yi6gu94QfLSqlNOnG60z7TUW19RsuFwpsaLh/iUWoWN+k6PhsO/8YYuQN2F/H2A5Pq vdjmz5b6RDqXaK0Kk6cb+hImj6lgviwiPgEV+fYPZpCY6aEzN0KERRYL2VPPFJ+u0Y25 iP+ujr6lOnMt25RONZOFwtWXOecrWEJKeo3t6U4GRrpTPi6+B3+vyqO9Gyt8GMBoTtKQ GI62IJG6wQUeZj+1Cdc/bcw733smOH5kl43rT0lnAxXduWrhnSkUMunTEtqa1SlvMWCE B8POtpg3RN9Fl62q3MmcQq1KD/m8KZXlA59HQc9JcmQuZ2hKhz2bWgELttumrpS+TlX2 z7Lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=XDFVDszPM59jDh1dUr6/6FsEEUzm7pgA8ycgI6wOzf0=; b=XiMjEacN8q1lCzlknexezlIJniEpaU1hRVkI+13zmKZQJ+Yq+yRN/rAbO9Gq7AQ6sS mixWa0T6XcpSQZPBBL7oLsDtwk0n1NHu/MNFHRFltBEJRfg83e3Jz75RgjZTw6ARY3ld y0lLSh5yXkbcLVWqOkf5ksoZ2d4o0tz24K1b4IDxL1uHLWnZemGn5Tk7RpzmPQZeMtlx oGx0zuryc0ploxgDBNXVWQGWYt2UQ6ycqpZduvy8NS+M5g+5FWooHwNhbqOlKlFcaNbf HqhkAx/EtNrqru571Dw/Cug3OdTdC41S1cDYEwDe477ViZ99MdTTuNFlcOUUKJbJGL7M MJ/A== X-Gm-Message-State: AKwxytfG95Uho0ZzMNFzjkvOGgecfJebp2cla/v2GxwpY+hUMn4FcMeM ebS58RRtSbCzDCppUWzHYYs= X-Google-Smtp-Source: ACJfBovsjyfz1v7PICymkeTF+3KpIsCOUcq7Tjt+f51IH4m4jGFpJAnMPGqZHRHslVJxqhwyY+wcjQ== X-Received: by 10.55.217.132 with SMTP id q4mr12383067qkl.236.1515379606879; Sun, 07 Jan 2018 18:46:46 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Paolo Bonzini , "Michael S. Tsirkin" , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Aurelien Jarno , Eduardo Habkost , Marcel Apfelbaum Date: Sun, 7 Jan 2018 23:45:40 -0300 Message-Id: <20180108024558.17983-12-f4bug@amsat.org> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20180108024558.17983-1-f4bug@amsat.org> References: <20180108024558.17983-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::244 Subject: [Qemu-devel] [PATCH 11/29] mc146818rtc: always register rtc to rtc list X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Igor Mammedov , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 From: Herv=C3=A9 Poussineau We are not required anymore to use rtc_init() function. Acked-by: Michael S. Tsirkin Acked-by: Paolo Bonzini Signed-off-by: Herv=C3=A9 Poussineau --- hw/timer/mc146818rtc.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/hw/timer/mc146818rtc.c b/hw/timer/mc146818rtc.c index 35a05a64cc..b0027e8f62 100644 --- a/hw/timer/mc146818rtc.c +++ b/hw/timer/mc146818rtc.c @@ -997,17 +997,16 @@ static void rtc_realizefn(DeviceState *dev, Error **e= rrp) OBJECT(s), "date", NULL); =20 qdev_init_gpio_out(dev, &s->irq, 1); + QLIST_INSERT_HEAD(&rtc_devices, s, link); } =20 ISADevice *mc146818_rtc_init(ISABus *bus, int base_year, qemu_irq intercep= t_irq) { DeviceState *dev; ISADevice *isadev; - RTCState *s; =20 isadev =3D isa_create(bus, TYPE_MC146818_RTC); dev =3D DEVICE(isadev); - s =3D MC146818_RTC(isadev); qdev_prop_set_int32(dev, "base_year", base_year); qdev_init_nofail(dev); if (intercept_irq) { @@ -1015,7 +1014,6 @@ ISADevice *mc146818_rtc_init(ISABus *bus, int base_ye= ar, qemu_irq intercept_irq) } else { isa_connect_gpio_out(isadev, 0, RTC_ISA_IRQ); } - QLIST_INSERT_HEAD(&rtc_devices, s, link); =20 return isadev; } @@ -1046,8 +1044,6 @@ static void rtc_class_initfn(ObjectClass *klass, void= *data) dc->reset =3D rtc_resetdev; dc->vmsd =3D &vmstate_rtc; dc->props =3D mc146818rtc_properties; - /* Reason: needs to be wired up by rtc_init() */ - dc->user_creatable =3D false; } =20 static void rtc_finalize(Object *obj) --=20 2.15.1