From nobody Tue Oct 28 12:15:15 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1515019430261667.7752441052228; Wed, 3 Jan 2018 14:43:50 -0800 (PST) Received: from localhost ([::1]:39959 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eWrl7-0006LY-H3 for importer@patchew.org; Wed, 03 Jan 2018 17:43:41 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57717) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eWrjm-0005E3-Ed for qemu-devel@nongnu.org; Wed, 03 Jan 2018 17:42:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eWrjl-0002Ji-Lm for qemu-devel@nongnu.org; Wed, 03 Jan 2018 17:42:18 -0500 Received: from mail-qk0-x244.google.com ([2607:f8b0:400d:c09::244]:38070) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eWrjl-0002JI-Hy; Wed, 03 Jan 2018 17:42:17 -0500 Received: by mail-qk0-x244.google.com with SMTP id l19so3470775qke.5; Wed, 03 Jan 2018 14:42:17 -0800 (PST) Received: from x1.lan ([138.117.48.219]) by smtp.gmail.com with ESMTPSA id f13sm1325127qke.47.2018.01.03.14.42.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Jan 2018 14:42:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZJq1D+6X52CnnyC1bfI/X/6oJwh8LSIHrDElxC0RtR0=; b=f1hke0B/e9zYirnhNQooO/EibY332z7emEpBOEsdImd2vpNgRjh8FWKnz+Dij0o14v 2Ffsri+xe8wKSBRIO8zrFjYQey4UcFqMKHycM3bw7F0RLoveLuhrLLHvSQGaHevE+1Jz nQ82NUw/a7z3IBkJPYakY7+M1PHM6zpYzaGcy717vJ983FtVZbfLI+FzZv8OQqAWGOOE BaKrcKJ3U+mzp+XL5crGBeF2pn+RV+fmNB2/v8jvSlzBJtM7lIl2HbEDh7eWrJicXWth gKjh/hNhvV6IgktwjehtVKgv1TuIeJNfZQugdU4ymMfYMKuFGItl/ntJmtod1+sr7s6x KexA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=ZJq1D+6X52CnnyC1bfI/X/6oJwh8LSIHrDElxC0RtR0=; b=V4utluxs1cL250/KR4mZy+MEm2fqIq/p2lGQit+ra3SoaYWGffbNTp4fk8zUEN+YNS SLTtyQu8YemZrwcdETC5fUBUF4KCK0G01oZ7qWiRvvVV/Egb4UCcBxSeZe77mG1pQsmG bgc2HytnSiQMIVnEo+OLCH2UTPb6CmhGcqInGOXaes+y73F1t790MryfrAGiAcXpGLYq 24AalyJ8UUw66qTpmiBs72xb2r6j7zqHx2wKGWLNJb2WN40gmMwfTp1G083FmuOsU6/0 42ymaSbpukO/qXyAxZ0cStdpQmUxHy1ZkaUettlS1pNsPGPt9DTqEVwK16X8l/lXQlbP s4zQ== X-Gm-Message-State: AKGB3mLgSFg3x27CG0wDXH022/0OkJU8LhHKxyPpqDtfAhPA0fXSmhzv 6QEKztrbubnwD4MAAh29lYs= X-Google-Smtp-Source: ACJfBotFbDVix3uoD8HMZa+MEARupTzlL4JjlfwnbZVax2e5Mt53ZkYdJ5xY+asW0kDJL0Zt134ogg== X-Received: by 10.55.4.130 with SMTP id 124mr3549257qke.330.1515019336992; Wed, 03 Jan 2018 14:42:16 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Alistair Francis , Peter Maydell , Andrzej Zaborowski Date: Wed, 3 Jan 2018 19:42:07 -0300 Message-Id: <20180103224208.30291-2-f4bug@amsat.org> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20180103224208.30291-1-f4bug@amsat.org> References: <20180103224208.30291-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::244 Subject: [Qemu-devel] [PATCH v2 1/2] hw/timer/pxa2xx_timer: replace hw_error() -> qemu_log_mask() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Edgar E . Iglesias" , qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis --- hw/timer/pxa2xx_timer.c | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/hw/timer/pxa2xx_timer.c b/hw/timer/pxa2xx_timer.c index 68ba5a70b3..a489bf5159 100644 --- a/hw/timer/pxa2xx_timer.c +++ b/hw/timer/pxa2xx_timer.c @@ -13,6 +13,7 @@ #include "sysemu/sysemu.h" #include "hw/arm/pxa.h" #include "hw/sysbus.h" +#include "qemu/log.h" =20 #define OSMR0 0x00 #define OSMR1 0x04 @@ -252,8 +253,14 @@ static uint64_t pxa2xx_timer_read(void *opaque, hwaddr= offset, case OSNR: return s->snapshot; default: + qemu_log_mask(LOG_UNIMP, + "%s: unknown register 0x%02" HWADDR_PRIx "\n", + __func__, offset); + break; badreg: - hw_error("pxa2xx_timer_read: Bad offset " REG_FMT "\n", offset); + qemu_log_mask(LOG_GUEST_ERROR, + "%s: incorrect register 0x%02" HWADDR_PRIx "\n", + __func__, offset); } =20 return 0; @@ -377,8 +384,14 @@ static void pxa2xx_timer_write(void *opaque, hwaddr of= fset, } break; default: + qemu_log_mask(LOG_UNIMP, + "%s: unknown register 0x%02" HWADDR_PRIx " " + "(value 0x%08" PRIx64 ")\n", __func__, offset, valu= e); + break; badreg: - hw_error("pxa2xx_timer_write: Bad offset " REG_FMT "\n", offset); + qemu_log_mask(LOG_GUEST_ERROR, + "%s: incorrect register 0x%02" HWADDR_PRIx " " + "(value 0x%08" PRIx64 ")\n", __func__, offset, value= ); } } =20 --=20 2.15.1