From nobody Tue Oct 28 12:15:18 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1515005144543840.9199129531643; Wed, 3 Jan 2018 10:45:44 -0800 (PST) Received: from localhost ([::1]:60842 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eWo2m-0005BW-6n for importer@patchew.org; Wed, 03 Jan 2018 13:45:40 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33851) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eWnsK-0003Bg-Pe for qemu-devel@nongnu.org; Wed, 03 Jan 2018 13:34:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eWnsK-0007PD-2a for qemu-devel@nongnu.org; Wed, 03 Jan 2018 13:34:52 -0500 Received: from mail-qk0-x243.google.com ([2607:f8b0:400d:c09::243]:42482) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eWnsJ-0007P9-UN for qemu-devel@nongnu.org; Wed, 03 Jan 2018 13:34:52 -0500 Received: by mail-qk0-x243.google.com with SMTP id d202so2654403qkc.9 for ; Wed, 03 Jan 2018 10:34:51 -0800 (PST) Received: from x1.lan ([138.117.48.219]) by smtp.gmail.com with ESMTPSA id 185sm992854qkd.1.2018.01.03.10.34.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Jan 2018 10:34:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Kwoab9xTy8zDxC0pz8lU16oolPUZ3Lqk8kWYWTCVa9A=; b=MTJ2ka/GWXt69RuRRkykINCMo0hrhofxdB6e18Ij6wy/icFw50roWWw3hdetYqONUE aAt/5NiNxoNUrEylKU6omTsZ+Fq33ClMywzLzaha2XlYABWcrtNH8kaxouy5N0IaDaLt GJE2OynLU1VJKqSKk4jGDIAPXiFacmSpNN4uMu7OSGYvfcfgJVSXLsg2j272Wd32NDo2 gWXDqwVYj7rZvwv36yB6g4Qc10ISVbt9o3XJBFveGmu0NMKqF/y0+VcH6FXXJh3LCrm9 IiE8L0/Qt0g9S8FtO2nmCOJXufh+dGbFR8vCX0l0eRWfLS88T2G7Cy5FAJIq5qwd6KRq ix+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=Kwoab9xTy8zDxC0pz8lU16oolPUZ3Lqk8kWYWTCVa9A=; b=K0j3FQ7GEEHtUpPRSZaJqWh6BhaEyhJEIXrpERFtBh/krNzFlCus2skodt2PDCDDBs Z1b4bSwxVrkRo2DSXPhTGzdVxRnMcPoDJorj4pCn7xKlshF4InPzAusy6SpUT0VcLlBq 4WjEN6Lk2Btf3Lli8+Bhue8DKfTUt0LjLstx7YWqbFOYmu3zb/S9vBkbwf4bSh5N/9Tf By+7K76XI/hNGKFmbGhmvvutwEo6E2xnV0yItU6OW8d4UXKuKkC0v90r2RCnrlC/Fieq y3fX2qBm+zgMkJZPJr8LVKREj4pXbouzusx8Hht/E6Vzz7OcQgG/SWogZ5sKL5OeUyvY JZxQ== X-Gm-Message-State: AKGB3mL+s2cFq7J4/8JtaO9Zt/9F+KDftN2XaUsA3arAgPmPYCIRrLct 8jy0ZXuWDjEFzL5ODL1nUr4= X-Google-Smtp-Source: ACJfBour2krW8Ss3H9wbnKjb9u2gUiNI+0Y9yZea6PXfvSYhFucRLYIjZKRX2R/5FN+z5bCd0EISCA== X-Received: by 10.55.103.20 with SMTP id b20mr2918174qkc.224.1515004491491; Wed, 03 Jan 2018 10:34:51 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Alistair Francis , "Edgar E . Iglesias" , Peter Maydell , Andrey Smirnov , =?UTF-8?q?Gr=C3=A9gory=20Estrade?= , Prasad J Pandit Date: Wed, 3 Jan 2018 15:34:02 -0300 Message-Id: <20180103183418.23730-10-f4bug@amsat.org> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20180103183418.23730-1-f4bug@amsat.org> References: <20180103183418.23730-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::243 Subject: [Qemu-devel] [PATCH v4 09/25] sdhci: Fix 64-bit ADMA2 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sai Pavan Boddu , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org, Peter Crosthwaite Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 From: Sai Pavan Boddu The 64-bit ADMA address is not converted to the cpu endianes correctly. This patch fixes the issue and uses a valid mask for the attribute data. Signed-off-by: Sai Pavan Boddu [AF: Re-write commit message] Reviewed-by: Alistair Francis Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/sd/sdhci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c index 755bbbecd1..50b483cbf2 100644 --- a/hw/sd/sdhci.c +++ b/hw/sd/sdhci.c @@ -623,8 +623,8 @@ static void get_adma_description(SDHCIState *s, ADMADes= cr *dscr) dscr->length =3D le16_to_cpu(dscr->length); dma_memory_read(&s->dma_as, entry_addr + 4, (uint8_t *)(&dscr->addr), 8); - dscr->attr =3D le64_to_cpu(dscr->attr); - dscr->attr &=3D 0xfffffff8; + dscr->addr =3D le64_to_cpu(dscr->addr); + dscr->attr &=3D (uint8_t) ~0xC0; dscr->incr =3D 12; break; } --=20 2.15.1