From nobody Tue Oct 28 04:17:44 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1515003213787134.4992814204262; Wed, 3 Jan 2018 10:13:33 -0800 (PST) Received: from localhost ([::1]:60045 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eWnXh-0004G0-0u for importer@patchew.org; Wed, 03 Jan 2018 13:13:33 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47861) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eWnT3-0000Yn-FY for qemu-devel@nongnu.org; Wed, 03 Jan 2018 13:08:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eWnT0-00073d-U7 for qemu-devel@nongnu.org; Wed, 03 Jan 2018 13:08:45 -0500 Received: from mail-qk0-x242.google.com ([2607:f8b0:400d:c09::242]:45427) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eWnT0-00073U-Pg for qemu-devel@nongnu.org; Wed, 03 Jan 2018 13:08:42 -0500 Received: by mail-qk0-x242.google.com with SMTP id o126so2556955qke.12 for ; Wed, 03 Jan 2018 10:08:42 -0800 (PST) Received: from x1.lan ([138.117.48.219]) by smtp.gmail.com with ESMTPSA id 46sm914901qtx.65.2018.01.03.10.08.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Jan 2018 10:08:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PEwPmDJz/2ZZ9Z5zYDCEd87igDtbUABJ+5RLWrVHoko=; b=lmQy6GV/JKyyjery3jeNjXRL5nvmRRit2efZNOT1mqQxphE1lGF2bzq+3Et1cXAuQN nWY0mgTv9N1C1ELxzYLXajhJY1AMYn8AcOjzG9nGk+mCLyw8AYA5D79/4xECrpIS5bXk gSYfmr6J8Gk9vIExoyCnrXTt/Yr3HoyGJV1kaaoOVHmeQFuTf5bedjMkTTVKhK+3Bv1A Mmg5+5mH/Jew+d5TnUcw0Kt76KlqDhzdoCO9GfUaTunOPKduMAK/KmE2DBgs0fAv3Ggy nZZZFJJzumTT8IR7fCqb/YTjk2T4Y3RxwD38M6nTpf/K+jK6DkcYfjH5n2CYDOZAu92m O/4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=PEwPmDJz/2ZZ9Z5zYDCEd87igDtbUABJ+5RLWrVHoko=; b=A+YskooJ5TBCBrLsoFzvItV0m/439oXPzxpvZcWRbbPrAT9Tqs1nVf4ppkndLs64La pmhY8NvWD7/D/uhvUzg3vRgUrlJAIsBvcfzfjuGfvVFigjE/RoOpnJxi0mWc8FnCPid3 C6u+585IjnU2SjQDzVBYVZFXTMTd7b7EH7NJp4QH7C0/1DMGqv2pi5hoX4OFmf5nkMXi opYry8Xh9g6o0EgB171N32meNxIgM55wjzv1soHdlvA/Al1A7qSUomYCwfAKgqcvylmP d/pOWGL66HwjPPsMwn+zORbX3tPSvE1kKWfV9+zHA9ctMQNeWLwSaOA3NYh5ybBs0AvR VU8w== X-Gm-Message-State: AKGB3mLKz3Ux3vezWq7FBTF73lq3z5pzC9KNGr2rM4sgqobTazkTChNt X4THmValR8IUYX2nr1tJpnw= X-Google-Smtp-Source: ACJfBotJT/jazYWn4cZvusvltrsRzuubK3OLEivZbFXKHjFa/KL7O2xXnG4dB6As/YT6hb/JpQ5qNg== X-Received: by 10.233.216.195 with SMTP id u186mr2532268qkf.341.1515002922414; Wed, 03 Jan 2018 10:08:42 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Alistair Francis Date: Wed, 3 Jan 2018 15:07:58 -0300 Message-Id: <20180103180805.18140-11-f4bug@amsat.org> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20180103180805.18140-1-f4bug@amsat.org> References: <20180103180805.18140-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::242 Subject: [Qemu-devel] [PATCH v5 10/17] sdhci: add a GPIO for the 'access control' LED X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Edgar E . Iglesias" , Peter Maydell , Fam Zheng , Eduardo Habkost , Andrey Smirnov , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 It blinks to caution the user not to remove the card while the SD card is being accessed. So far it only emits a trace event. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Acked-by: Alistair Francis --- include/hw/sd/sdhci.h | 2 ++ hw/sd/sdhci.c | 14 ++++++++++++++ hw/sd/trace-events | 1 + 3 files changed, 17 insertions(+) diff --git a/include/hw/sd/sdhci.h b/include/hw/sd/sdhci.h index a6fe064f51..da943a6562 100644 --- a/include/hw/sd/sdhci.h +++ b/include/hw/sd/sdhci.h @@ -45,6 +45,8 @@ typedef struct SDHCIState { QEMUTimer *insert_timer; /* timer for 'changing' sd card. */ QEMUTimer *transfer_timer; qemu_irq irq; + qemu_irq access_led; + int access_led_level; =20 /* Registers cleared on reset */ /* 0x00 */ diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c index a781cc5211..de9c4e5a83 100644 --- a/hw/sd/sdhci.c +++ b/hw/sd/sdhci.c @@ -203,6 +203,16 @@ static void sdhci_poweron_reset(DeviceState *dev) } } =20 +static void sdhci_led_handler(void *opaque, int line, int level) +{ + SDHCIState *s =3D (SDHCIState *)opaque; + + if (s->access_led_level !=3D level) { + trace_sdhci_led(level); + s->access_led_level =3D level; + } +} + static void sdhci_data_transfer(void *opaque); =20 static void sdhci_send_command(SDHCIState *s) @@ -1051,6 +1061,7 @@ sdhci_write(void *opaque, hwaddr offset, uint64_t val= , unsigned size) !(s->capareg & (1 << (31 - ((s->pwrcon >> 1) & 0x7))))) { s->pwrcon &=3D ~SDHC_POWER_ON; } + qemu_set_irq(s->access_led, s->hostctl & 1); break; case SDHC_CLKCON: if (!(mask & 0xFF000000)) { @@ -1163,6 +1174,7 @@ static void sdhci_initfn(SDHCIState *s) qbus_create_inplace(&s->sdbus, sizeof(s->sdbus), TYPE_SDHCI_BUS, DEVICE(s), "sd-bus"); =20 + s->access_led =3D qemu_allocate_irq(sdhci_led_handler, s, 0); s->insert_timer =3D timer_new_ns(QEMU_CLOCK_VIRTUAL, sdhci_raise_inser= tion_irq, s); s->transfer_timer =3D timer_new_ns(QEMU_CLOCK_VIRTUAL, sdhci_data_tran= sfer, s); } @@ -1193,6 +1205,8 @@ static void sdhci_uninitfn(SDHCIState *s) timer_free(s->insert_timer); timer_del(s->transfer_timer); timer_free(s->transfer_timer); + + qemu_free_irq(s->access_led); } =20 static bool sdhci_pending_insert_vmstate_needed(void *opaque) diff --git a/hw/sd/trace-events b/hw/sd/trace-events index e4e26c6d73..f821db2046 100644 --- a/hw/sd/trace-events +++ b/hw/sd/trace-events @@ -13,6 +13,7 @@ sdhci_adma_transfer_completed(void) "ADMA transfer comple= ted" sdhci_access(const char *access, unsigned int size, uint64_t offset, const= char *dir, uint64_t val, uint64_t val2) "%s %ub: addr[0x%04" PRIx64 "] %s = %" PRIu64 "(0x%" PRIx64 ")" sdhci_read_dataport(uint16_t data_count) "all %u bytes of data have been r= ead from input buffer" sdhci_write_dataport(uint16_t data_count) "write buffer filled with %u byt= es of data" +sdhci_led(bool state) "LED: %u" =20 # hw/sd/milkymist-memcard.c milkymist_memcard_memory_read(uint32_t addr, uint32_t value) "addr 0x%08x = value 0x%08x" --=20 2.15.1