From nobody Tue Oct 28 12:15:21 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1514996784321367.21548848984526; Wed, 3 Jan 2018 08:26:24 -0800 (PST) Received: from localhost ([::1]:57073 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eWlrs-0005GX-2g for importer@patchew.org; Wed, 03 Jan 2018 11:26:16 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44045) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eWlps-00042A-Ph for qemu-devel@nongnu.org; Wed, 03 Jan 2018 11:24:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eWlpr-0004wz-PW for qemu-devel@nongnu.org; Wed, 03 Jan 2018 11:24:12 -0500 Received: from mail-qk0-x241.google.com ([2607:f8b0:400d:c09::241]:39750) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eWlpr-0004wf-L7; Wed, 03 Jan 2018 11:24:11 -0500 Received: by mail-qk0-x241.google.com with SMTP id c5so2151778qkg.6; Wed, 03 Jan 2018 08:24:11 -0800 (PST) Received: from x1.lan ([138.117.48.219]) by smtp.gmail.com with ESMTPSA id 102sm839393qkx.85.2018.01.03.08.24.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Jan 2018 08:24:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=syf+Muj7Wjji0hClLilXJeGv6u3kvMHoCi/4Evw2Zug=; b=nEZHjFYKUo+os+2hkgATFyuyrh/75ICM5xWkGwmdfIR7WWqcBw5CgbDcEe3KammK1T bfeI+XQDQm3LWo4u0uZvK9lvPcPa4TJtxEF0//AAlRbcG07A2UmEydUR3hd6ed7I+ykY oUA1QDOZDBO006i3RaM0irx5DO5bn5jCmYSAQfBMBh2ZFu37gmLRZPJIqEV4mvPGYCY6 33v2ApLXZ2iWwcYnciLHL7N0DufboTdA2WNEbzQf2cXIYwNszFrF/N9FCQ+tceHpwCSy H2VkVDmQF3CCuInFK/ISPvVk4Ra5RKAuHFFIklJHKieyGUCPwLwHe6C7b9Cz06QVssZQ 5csA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=syf+Muj7Wjji0hClLilXJeGv6u3kvMHoCi/4Evw2Zug=; b=lA7S6qXwyiTx4bGfosa2T0L+uv++myFTNDmHa+6VH7rNseIRVJrcOQpP2ZwbbPjBz/ L1OfBI4wYdxKQKG0w5+RvdfU3Waa+XS2JjS1E/J35dtvXDryD0yaQq7HVxWF0OP7NuEu wq/tQZ8YW2NonGDBwbEFXSJeizWLeAR0cDfTGDdT5lcv92d1oAWqQpLKVu6NY4ZSQFrn lNbclrS2MQPL6eDboewY/T0D9oPK6fmQ18ay4JNJXWKydfqSxvaRVsgxxGa0ERAvC1Aw Os4I9Z06tDlBE5RjFzzLLhqb9XmvgWF3UqVK2L181z+E+vumojnlhuLLQIANBr+rfdwS BdJA== X-Gm-Message-State: AKGB3mIX0Z803rreh1GLcHCNG73gdZ52gbJMdZ6/jq+ewSJBAi4nwytf eUyJ18vqmJyLlcm1GneHppM= X-Google-Smtp-Source: ACJfBot4lEN0ug87W29X03DC62JKZ65dWk278F8pQp/rdTwJF13Hr179VTm6T1NMoy3WfFV48O+DEA== X-Received: by 10.55.210.129 with SMTP id f123mr2375719qkj.64.1514996651133; Wed, 03 Jan 2018 08:24:11 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Alistair Francis , Michael Walle Date: Wed, 3 Jan 2018 13:23:55 -0300 Message-Id: <20180103162400.10396-2-f4bug@amsat.org> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20180103162400.10396-1-f4bug@amsat.org> References: <20180103162400.10396-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::241 Subject: [Qemu-devel] [PATCH 1/6] hw/sd/milkymist-memcard: use qemu_log_mask() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Edgar E . Iglesias" , Peter Maydell , qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis --- hw/sd/milkymist-memcard.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/hw/sd/milkymist-memcard.c b/hw/sd/milkymist-memcard.c index 4008c81002..5de3e00e2f 100644 --- a/hw/sd/milkymist-memcard.c +++ b/hw/sd/milkymist-memcard.c @@ -26,7 +26,7 @@ #include "hw/sysbus.h" #include "sysemu/sysemu.h" #include "trace.h" -#include "qemu/error-report.h" +#include "include/qapi/error.h" #include "sysemu/block-backend.h" #include "sysemu/blockdev.h" #include "hw/sd/sd.h" @@ -138,8 +138,8 @@ static uint64_t memcard_read(void *opaque, hwaddr addr, } else { r =3D s->response[s->response_read_ptr++]; if (s->response_read_ptr > s->response_len) { - error_report("milkymist_memcard: " - "read more cmd bytes than available. Clipping."); + qemu_log_mask(LOG_GUEST_ERROR, "milkymist_memcard: " + "read more cmd bytes than available. Clippin= g."); s->response_read_ptr =3D 0; } } @@ -163,8 +163,9 @@ static uint64_t memcard_read(void *opaque, hwaddr addr, break; =20 default: - error_report("milkymist_memcard: read access to unknown register 0= x" - TARGET_FMT_plx, addr << 2); + qemu_log_mask(LOG_UNIMP, "milkymist_memcard: " + "read access to unknown register 0x%" HWADDR_PRIx "\= n", + addr << 2); break; } =20 @@ -220,8 +221,9 @@ static void memcard_write(void *opaque, hwaddr addr, ui= nt64_t value, break; =20 default: - error_report("milkymist_memcard: write access to unknown register = 0x" - TARGET_FMT_plx, addr << 2); + qemu_log_mask(LOG_UNIMP, "milkymist_memcard: " + "write access to unknown register 0x%" HWADDR_PRIx "= " + "(value 0x%" PRIx64 ")\n", addr << 2, value); break; } } --=20 2.15.1