From nobody Tue Oct 28 12:10:44 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1514982168139656.7765968516745; Wed, 3 Jan 2018 04:22:48 -0800 (PST) Received: from localhost ([::1]:50592 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eWi4A-00081Z-A4 for importer@patchew.org; Wed, 03 Jan 2018 07:22:42 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56692) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eWi2A-0006i7-DC for qemu-devel@nongnu.org; Wed, 03 Jan 2018 07:20:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eWi29-00027T-G7 for qemu-devel@nongnu.org; Wed, 03 Jan 2018 07:20:38 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35058) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eWi29-00026W-7C for qemu-devel@nongnu.org; Wed, 03 Jan 2018 07:20:37 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 73A887E420 for ; Wed, 3 Jan 2018 12:20:36 +0000 (UTC) Received: from xz-mi.nay.redhat.com (dhcp-14-131.nay.redhat.com [10.66.14.131]) by smtp.corp.redhat.com (Postfix) with ESMTP id A94F863756; Wed, 3 Jan 2018 12:20:34 +0000 (UTC) From: Peter Xu To: qemu-devel@nongnu.org Date: Wed, 3 Jan 2018 20:20:10 +0800 Message-Id: <20180103122017.14794-7-peterx@redhat.com> In-Reply-To: <20180103122017.14794-1-peterx@redhat.com> References: <20180103122017.14794-1-peterx@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Wed, 03 Jan 2018 12:20:36 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v2 06/13] migration: introduce downtime_start X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , "Dr . David Alan Gilbert" , peterx@redhat.com, Juan Quintela Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Introduce MigrationState.downtime_start to replace the local variable "start_time" in migration_thread to avoid passing things around. Reviewed-by: Juan Quintela Signed-off-by: Peter Xu --- migration/migration.c | 12 ++++-------- migration/migration.h | 2 ++ 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index ca0c600178..bfe1a76254 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -2055,16 +2055,14 @@ static int migration_maybe_pause(MigrationState *s, * * @s: Current migration state * @current_active_state: The migration state we expect to be in - * @*start_time: Pointer to time to update */ -static void migration_completion(MigrationState *s, int current_active_sta= te, - int64_t *start_time) +static void migration_completion(MigrationState *s, int current_active_sta= te) { int ret; =20 if (s->state =3D=3D MIGRATION_STATUS_ACTIVE) { qemu_mutex_lock_iothread(); - *start_time =3D qemu_clock_get_ms(QEMU_CLOCK_REALTIME); + s->downtime_start =3D qemu_clock_get_ms(QEMU_CLOCK_REALTIME); qemu_system_wakeup_request(QEMU_WAKEUP_REASON_OTHER); s->vm_was_running =3D runstate_is_running(); ret =3D global_state_store(); @@ -2170,7 +2168,6 @@ static void *migration_thread(void *opaque) * measured bandwidth */ int64_t threshold_size =3D 0; - int64_t start_time =3D initial_time; int64_t end_time; bool entered_postcopy =3D false; /* The active state we expect to be in; ACTIVE or POSTCOPY_ACTIVE */ @@ -2241,8 +2238,7 @@ static void *migration_thread(void *opaque) qemu_savevm_state_iterate(s->to_dst_file, entered_postcopy= ); } else { trace_migration_thread_low_pending(pending_size); - migration_completion(s, current_active_state, - &start_time); + migration_completion(s, current_active_state); break; } } @@ -2293,7 +2289,7 @@ static void *migration_thread(void *opaque) uint64_t transferred_bytes =3D qemu_ftell(s->to_dst_file); s->total_time =3D end_time - s->start_time; if (!entered_postcopy) { - s->downtime =3D end_time - start_time; + s->downtime =3D end_time - s->downtime_start; } if (s->total_time) { s->mbps =3D (((double) transferred_bytes * 8.0) / diff --git a/migration/migration.h b/migration/migration.h index 45053ae8c5..867383f18d 100644 --- a/migration/migration.h +++ b/migration/migration.h @@ -107,6 +107,8 @@ struct MigrationState int64_t start_time; /* Total time used by latest migration (ms) */ int64_t total_time; + /* Timestamp when VM is down (ms) to migrate the last stuff */ + int64_t downtime_start; int64_t downtime; int64_t expected_downtime; bool enabled_capabilities[MIGRATION_CAPABILITY__MAX]; --=20 2.14.3