From nobody Tue Feb 10 00:39:42 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1514922411475664.7960399823; Tue, 2 Jan 2018 11:46:51 -0800 (PST) Received: from localhost ([::1]:53129 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eWSWM-00044Z-Aa for importer@patchew.org; Tue, 02 Jan 2018 14:46:46 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58768) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eWSMk-0003Mw-Jo for qemu-devel@nongnu.org; Tue, 02 Jan 2018 14:36:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eWSMj-0000RW-If for qemu-devel@nongnu.org; Tue, 02 Jan 2018 14:36:50 -0500 Received: from mail-pf0-x244.google.com ([2607:f8b0:400e:c00::244]:39724) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eWSMh-0000PK-4t; Tue, 02 Jan 2018 14:36:47 -0500 Received: by mail-pf0-x244.google.com with SMTP id l24so26024882pfj.6; Tue, 02 Jan 2018 11:36:47 -0800 (PST) Received: from squirtle.westlake.spaceflightindustries.com ([173.226.206.194]) by smtp.gmail.com with ESMTPSA id g9sm97905951pfk.0.2018.01.02.11.36.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 02 Jan 2018 11:36:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=krjP4ycTOa7hxNduyxB7DLScklOA9sr6EGMYFcFXKS4=; b=e+YhLqik6HjvfyDlXnbG41se7F5GxAnoltp7NAEdwLOFxEFwkLbb0XGCp5ccGttsdT OIYIw/FCQYVxc1XQS1KPYJfbZS6BjthbEQ79cduAWj2Lrf8KX95GBZSFeZIEi87J0iIJ eyvTe2S/Q9D1ewt7vkkqSg7j9S5K5kJFDrN2huNYBHM5UvahxlrmimSyjJr3T4z+7AIi 2CvifLDpLiIY2r01YMCUgXjivmcnSXBmVUCm/bI84rh60EdmCFNVk8Lj5pUcSjvTnXWM laewN6yUCrAvVXmyIZzPBVIPVvWYEcEaQGTqFKvwogaHau1tfYbVhOTCqax2K/uO/dp1 80+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=krjP4ycTOa7hxNduyxB7DLScklOA9sr6EGMYFcFXKS4=; b=dyoX3iLA1gcpbjR/q9dD55R2nh0ZM4w1m3luHRwkNwUF17BWb3YQ3ts6J8SBSkhZ3y Xg8JBmRWBLxxsiM4TvK5cFA75Hqxre9FG8D5a2+ccpFEhnK9iDXfbLm1/jKzloZoglDz f941KugJBHNxYUzEuA1Q4fLKADPPK/ZnEJjlu8x+MN8/MNAjZjOpBHZaXc/ApDzeJyxW IBOX8QXcoyZIHpEeOYzdANIop4zpzolu7J1T6JNTTkXLJQ9/UtMLdOqYpcrGA8dRQ8Tv 3scHjFgfRZcRXUDWXmOfMn2/dPGJnAt1273HAQscB7J5eYJVVKxR3E1RjmpIrrz/oZKZ Nc6Q== X-Gm-Message-State: AKGB3mJkhhV7eddV4vwC/YQZYz6ZTqAGCbdr+J3hgQnfBEcu+neX+qxX iWGmBaylsSAyl700vNT5tYH/OHnOCIM= X-Google-Smtp-Source: ACJfBovekGyDvOfk1JjMAkniQHFYylxkeKH3NzNHHkCwETRCpQtmxj8qL5JZFddC711By2DGbIOaDg== X-Received: by 10.101.86.6 with SMTP id l6mr22654493pgs.322.1514921805870; Tue, 02 Jan 2018 11:36:45 -0800 (PST) From: Andrey Smirnov To: qemu-arm@nongnu.org Date: Tue, 2 Jan 2018 11:36:22 -0800 Message-Id: <20180102193622.27215-12-andrew.smirnov@gmail.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180102193622.27215-1-andrew.smirnov@gmail.com> References: <20180102193622.27215-1-andrew.smirnov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::244 Subject: [Qemu-devel] [PATCH v3 11/11] imx_fec: Reserve full FSL_IMX25_FEC_SIZE page for the register file X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Andrey Smirnov , Jason Wang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org, yurovsky@gmail.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Some i.MX SoCs (e.g. i.MX7) have FEC registers going as far as offset 0x614, so to avoid getting aborts when accessing those on QEMU, extend the register file to cover FSL_IMX25_FEC_SIZE(16K) of address space instead of just 1K. Cc: Peter Maydell Cc: Jason Wang Cc: Philippe Mathieu-Daud=C3=A9 Cc: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org Cc: yurovsky@gmail.com Reviewed-by: Peter Maydell Signed-off-by: Andrey Smirnov --- hw/net/imx_fec.c | 2 +- include/hw/arm/fsl-imx25.h | 1 - include/hw/net/imx_fec.h | 1 + 3 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/net/imx_fec.c b/hw/net/imx_fec.c index c1cf7f9c58..4fb48f62ba 100644 --- a/hw/net/imx_fec.c +++ b/hw/net/imx_fec.c @@ -1281,7 +1281,7 @@ static void imx_eth_realize(DeviceState *dev, Error *= *errp) SysBusDevice *sbd =3D SYS_BUS_DEVICE(dev); =20 memory_region_init_io(&s->iomem, OBJECT(dev), &imx_eth_ops, s, - TYPE_IMX_FEC, 0x400); + TYPE_IMX_FEC, FSL_IMX25_FEC_SIZE); sysbus_init_mmio(sbd, &s->iomem); sysbus_init_irq(sbd, &s->irq[0]); sysbus_init_irq(sbd, &s->irq[1]); diff --git a/include/hw/arm/fsl-imx25.h b/include/hw/arm/fsl-imx25.h index d0e8e9d956..65a73714ef 100644 --- a/include/hw/arm/fsl-imx25.h +++ b/include/hw/arm/fsl-imx25.h @@ -192,7 +192,6 @@ typedef struct FslIMX25State { #define FSL_IMX25_UART5_ADDR 0x5002C000 #define FSL_IMX25_UART5_SIZE 0x4000 #define FSL_IMX25_FEC_ADDR 0x50038000 -#define FSL_IMX25_FEC_SIZE 0x4000 #define FSL_IMX25_CCM_ADDR 0x53F80000 #define FSL_IMX25_CCM_SIZE 0x4000 #define FSL_IMX25_GPT4_ADDR 0x53F84000 diff --git a/include/hw/net/imx_fec.h b/include/hw/net/imx_fec.h index 91ef8f89a6..7b3faa4019 100644 --- a/include/hw/net/imx_fec.h +++ b/include/hw/net/imx_fec.h @@ -245,6 +245,7 @@ typedef struct { =20 #define ENET_TX_RING_NUM 3 =20 +#define FSL_IMX25_FEC_SIZE 0x4000 =20 typedef struct IMXFECState { /*< private >*/ --=20 2.14.3