From nobody Tue Oct 28 21:11:13 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1513488682325775.2546383743379; Sat, 16 Dec 2017 21:31:22 -0800 (PST) Received: from localhost ([::1]:53180 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eQRXg-0007m2-9r for importer@patchew.org; Sun, 17 Dec 2017 00:31:16 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40298) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eQRWN-00076o-G2 for qemu-devel@nongnu.org; Sun, 17 Dec 2017 00:29:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eQRWL-0004w0-KU for qemu-devel@nongnu.org; Sun, 17 Dec 2017 00:29:55 -0500 Received: from mail-wr0-x242.google.com ([2a00:1450:400c:c0c::242]:39638) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eQRWL-0004vf-DP for qemu-devel@nongnu.org; Sun, 17 Dec 2017 00:29:53 -0500 Received: by mail-wr0-x242.google.com with SMTP id a41so11250732wra.6 for ; Sat, 16 Dec 2017 21:29:53 -0800 (PST) Received: from donizetti.lan (dynamic-adsl-78-12-251-125.clienti.tiscali.it. [78.12.251.125]) by smtp.gmail.com with ESMTPSA id v18sm6169790wrv.37.2017.12.16.21.29.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 16 Dec 2017 21:29:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id; bh=J6n+on8V/LUjai093+51Q/ESOi5BX53YwBFZHaGzIlw=; b=P7ZbNTzO6u9GwgShpUnGbu2VZmbUp1PIP9ehs69mFw4LY82vRdxg848/nXBWCzvqjw VCHQL5fBlFQzU19Ia8QTNDO31OqS3sAItDtTtwYyPdq/d1XLB/nhGwHVYUO+fDWqzvCC degXWTsnSO3XX5jT1CkBzox6IhdltlOYDBYWx11apNzmTz0SsPmhGJA5AQm31b5jSpk4 pcFTX7Q71k7bQbLyBacU8mq1fPtU9oN89O6HN2Eoo/+A5OTxk5Jt25vBS33yxD8VB1OH oKOgl3oZgI+HKGF2+mnZMmeycAHMzQaw5vKFaqLRbi4a/gVsrAnzk+wd3PjUccMhVHr4 auvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=J6n+on8V/LUjai093+51Q/ESOi5BX53YwBFZHaGzIlw=; b=T//1qinaZb7qI39UjW2TzQSswyf6QSpleDRPFbXEPQWHv5djT3hnq/wtIYmZep7nj0 M63XPcFB8tMsHwwotecYQFiH6bxWyfMiALum9uCa+c3/u8QDTScHCG/VjGbqvCZhl8Ts 2bCDUC0NmO5cMb60fAKzdIxr+OcVD8hLUpYMQ9t15hDnc4T9obDoqDBq6Yr+BCCUeIVd tnoSCCr7jJ3lls5wPZ2KJMIhnkjAbncHI7QT42GxijwtlU+DKqYONiaE1HIcvWIadtif 8FlQblyNz1i/tltLxErQVnFDpuvmny+TFzECgjzaRwzix7XRRQLu7gGe/zaVe7C5uUok Vt3A== X-Gm-Message-State: AKGB3mKOb3jGYdLQ/1vpDU3V8tgIBRgpEuWTTbhH4dhDdQoAIFS6YHEU rjC88VXJuRK1M54f9zXNXNKF4v67 X-Google-Smtp-Source: ACJfBovXC8dqOuHymu9nStf588zTut0rk40uLR/Ouopd0mmnmFp6YvU9XBIelCwoCoTUdZhp0vv3iA== X-Received: by 10.223.169.67 with SMTP id u61mr524828wrc.30.1513488592107; Sat, 16 Dec 2017 21:29:52 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Sun, 17 Dec 2017 06:29:45 +0100 Message-Id: <20171217052945.12782-2-pbonzini@redhat.com> X-Mailer: git-send-email 2.14.3 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::242 Subject: [Qemu-devel] [PATCH] scsi: replace hex constants with #defines X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dgilbert@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Sense keys have nice #defines in scsi/constants.h, use them. Reported-by: Dr. David Alan Gilbert Signed-off-by: Paolo Bonzini Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- scsi/utils.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/scsi/utils.c b/scsi/utils.c index 61bc1a8e2b..ddae650a99 100644 --- a/scsi/utils.c +++ b/scsi/utils.c @@ -339,16 +339,16 @@ int scsi_convert_sense(uint8_t *in_buf, int in_len, int scsi_sense_to_errno(int key, int asc, int ascq) { switch (key) { - case 0x00: /* NO SENSE */ - case 0x01: /* RECOVERED ERROR */ - case 0x06: /* UNIT ATTENTION */ + case NO_SENSE: + case RECOVERED_ERROR: + case UNIT_ATTENTION: /* These sense keys are not errors */ return 0; - case 0x0b: /* COMMAND ABORTED */ + case ABORTED_COMMAND: /* COMMAND ABORTED */ return ECANCELED; - case 0x02: /* NOT READY */ - case 0x05: /* ILLEGAL REQUEST */ - case 0x07: /* DATA PROTECTION */ + case NOT_READY: + case ILLEGAL_REQUEST: + case DATA_PROTECT: /* Parse ASCQ */ break; default: --=20 2.14.3