From nobody Sun Feb 8 21:06:52 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1513028483866944.3061798096898; Mon, 11 Dec 2017 13:41:23 -0800 (PST) Received: from localhost ([::1]:55599 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eOVp8-0003kJ-DP for importer@patchew.org; Mon, 11 Dec 2017 16:41:18 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35933) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eOVfI-0000uV-4t for qemu-devel@nongnu.org; Mon, 11 Dec 2017 16:31:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eOVfG-0004g3-VK for qemu-devel@nongnu.org; Mon, 11 Dec 2017 16:31:08 -0500 Received: from mail-pg0-x244.google.com ([2607:f8b0:400e:c05::244]:39002) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eOVfB-0004QX-Tc; Mon, 11 Dec 2017 16:31:02 -0500 Received: by mail-pg0-x244.google.com with SMTP id w7so11841711pgv.6; Mon, 11 Dec 2017 13:31:01 -0800 (PST) Received: from squirtle.westlake.spaceflightindustries.com ([173.226.206.194]) by smtp.gmail.com with ESMTPSA id q10sm25359690pgc.84.2017.12.11.13.30.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 11 Dec 2017 13:30:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZTqLlHi4ok1Ycz/bAfYiDWhusb4heKGG6AqeSlvLFIg=; b=Nzeg8HC5FXPT2O2mVSadGugdwTBOsUHN77Uq7fs7nYzX9JNB/ZxY5IpJF/ZS3O3f60 bQd7a1jE1umrnCEgxtVTMcU6yVEYFckFFj/zNtO8XjU7Wi1bPzAL3EEddIGrlBM33au+ /D/kX9VNXzMmU+Vr3BBKgFluPjVReU1GkyyXnXPLMVq8F5sHYwCbjrOfnMOgu3E0b9w9 12udrYC2BNR4xQ2dl3htDhDaVy0ia2xqU+7Vul4HOtHJeOKVOQlWEQfVMVNk/QbnBfr5 kWpm4p2QXJEjqRcL8hWLuAiuuqWM6FBvIAKGnibD7+lKMNKBmmT3GjY1h+dysw3uwEol qgAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZTqLlHi4ok1Ycz/bAfYiDWhusb4heKGG6AqeSlvLFIg=; b=kZMiutTkmKnbhWVhfQUuUctuNQsJGwsKNs1wrqv5J0ZCqfpwZo7/xUoKN70+mqjs8U wkNFF9iqrTiWelsAa2u9XKWdJtMajBxWLnV9E6iOEHnaK7uEaS8q1KExft5le08dB/R/ gfAXwlntgr3f+XvBpgyF7WHMzRhca34GnZWHRXuqb9NYTzweYRIG+mz8Q22Gq7IUILcg vkuFODh632vBnnIx8jDt2jljNwf4yZWZT80HJH0gtcB91K/ff1BDRnvOJydn8QrHWy5p i8gE1ILt429rfNoK/wmpXle0lIWiSRYed7uSvKZrXpp4F/vNt7iQXBiW4sncSS+sRlzi ozuQ== X-Gm-Message-State: AKGB3mI6Edi5EPrvvgnO0Ck/7YYV0t2caTogBgQ62xwGMDnZmHAwXXY0 VVh/IJcqCvmKbCDhWDV6zBhxWiGs X-Google-Smtp-Source: ACJfBovkBVwgV1YRi7Lp9jyrXlYnppQ15PwlzdNq9ayOrqCyBSndB+lrGW53FwKdVIYmaHDYH/aG5g== X-Received: by 10.159.235.132 with SMTP id f4mr1668504plr.122.1513027860708; Mon, 11 Dec 2017 13:31:00 -0800 (PST) From: Andrey Smirnov To: qemu-arm@nongnu.org Date: Mon, 11 Dec 2017 13:30:05 -0800 Message-Id: <20171211213007.7353-12-andrew.smirnov@gmail.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20171211213007.7353-1-andrew.smirnov@gmail.com> References: <20171211213007.7353-1-andrew.smirnov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c05::244 Subject: [Qemu-devel] [PATCH 11/13] imx_fec: Reserve full FSL_IMX25_FEC_SIZE page for the register file X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Andrey Smirnov , Jason Wang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org, yurovsky@gmail.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Some i.MX SoCs (e.g. i.MX7) have FEC registers going as far as offset 0x614, so to avoid getting aborts when accessing those on QEMU, extend the register file to cover FSL_IMX25_FEC_SIZE(16K) of address space instead of just 1K. Cc: Peter Maydell Cc: Jason Wang Cc: Philippe Mathieu-Daud=C3=A9 Cc: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org Cc: yurovsky@gmail.com Signed-off-by: Andrey Smirnov Reviewed-by: Peter Maydell --- hw/net/imx_fec.c | 2 +- include/hw/arm/fsl-imx25.h | 1 - include/hw/net/imx_fec.h | 1 + 3 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/net/imx_fec.c b/hw/net/imx_fec.c index c1cf7f9c58..4fb48f62ba 100644 --- a/hw/net/imx_fec.c +++ b/hw/net/imx_fec.c @@ -1281,7 +1281,7 @@ static void imx_eth_realize(DeviceState *dev, Error *= *errp) SysBusDevice *sbd =3D SYS_BUS_DEVICE(dev); =20 memory_region_init_io(&s->iomem, OBJECT(dev), &imx_eth_ops, s, - TYPE_IMX_FEC, 0x400); + TYPE_IMX_FEC, FSL_IMX25_FEC_SIZE); sysbus_init_mmio(sbd, &s->iomem); sysbus_init_irq(sbd, &s->irq[0]); sysbus_init_irq(sbd, &s->irq[1]); diff --git a/include/hw/arm/fsl-imx25.h b/include/hw/arm/fsl-imx25.h index d0e8e9d956..65a73714ef 100644 --- a/include/hw/arm/fsl-imx25.h +++ b/include/hw/arm/fsl-imx25.h @@ -192,7 +192,6 @@ typedef struct FslIMX25State { #define FSL_IMX25_UART5_ADDR 0x5002C000 #define FSL_IMX25_UART5_SIZE 0x4000 #define FSL_IMX25_FEC_ADDR 0x50038000 -#define FSL_IMX25_FEC_SIZE 0x4000 #define FSL_IMX25_CCM_ADDR 0x53F80000 #define FSL_IMX25_CCM_SIZE 0x4000 #define FSL_IMX25_GPT4_ADDR 0x53F84000 diff --git a/include/hw/net/imx_fec.h b/include/hw/net/imx_fec.h index 91ef8f89a6..7b3faa4019 100644 --- a/include/hw/net/imx_fec.h +++ b/include/hw/net/imx_fec.h @@ -245,6 +245,7 @@ typedef struct { =20 #define ENET_TX_RING_NUM 3 =20 +#define FSL_IMX25_FEC_SIZE 0x4000 =20 typedef struct IMXFECState { /*< private >*/ --=20 2.14.3