From nobody Wed Oct 29 09:14:49 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1513028379703879.4012517528713; Mon, 11 Dec 2017 13:39:39 -0800 (PST) Received: from localhost ([::1]:55582 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eOVnW-00022k-9I for importer@patchew.org; Mon, 11 Dec 2017 16:39:38 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35923) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eOVfH-0000tw-OA for qemu-devel@nongnu.org; Mon, 11 Dec 2017 16:31:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eOVfG-0004fi-Sc for qemu-devel@nongnu.org; Mon, 11 Dec 2017 16:31:07 -0500 Received: from mail-pf0-x243.google.com ([2607:f8b0:400e:c00::243]:35689) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eOVf9-0004I0-8e; Mon, 11 Dec 2017 16:30:59 -0500 Received: by mail-pf0-x243.google.com with SMTP id j124so12531646pfc.2; Mon, 11 Dec 2017 13:30:59 -0800 (PST) Received: from squirtle.westlake.spaceflightindustries.com ([173.226.206.194]) by smtp.gmail.com with ESMTPSA id q10sm25359690pgc.84.2017.12.11.13.30.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 11 Dec 2017 13:30:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Ty+c/nHpZuV2ryMR9Vetge+TEO8E4qKSpfUH6xLUNk0=; b=pDnq98zTshPtj13RRqEx1jUPGHLPlzLEcnP0hPzAZV+xlRqH1fz/+m5sUwx92fl5sS sfzN22XCliER8VPN8F8Ov5CEi33zUzGCEfx8jzcZzuGZUm20Q8Z1J8wQZ4NXewrAGqF6 3PtQvSA1xHu1oREU6TQa+PbuU99dM0sFwZXdLygfuyANoG3fX3pXvHW5qhVHUH9h06cD K6Vnw0BQALPDxxleO8frWwXSK4U6PXKbZM0V2y/YEVOE4gOiSfxSV/cdM+QIVimLzCKA LxzoMBwkhwknzfAWISj/xN9t+lNuCZxAK8VdL00xVtxdBsBR+Bz/yHpxJZuOtkCaX5AL yL7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Ty+c/nHpZuV2ryMR9Vetge+TEO8E4qKSpfUH6xLUNk0=; b=iZwdhNvHZA3KoWfKQPLQXc5b39rYCMvHaDSLBnpAV8LflAaAzSmLk3aej0oDpFPtFK 4g8USizX6P3qFM6lChUhtkFnAOTYqqrSbyWUWbhVqvN2JBh7IzG2QOkcLEvQIuBPA/nB t58RdI761jturLAJPaFhl6DlM8cG31d9rwgGngnHl5bko4xGlmKFBM83mHIv+Sw6odLU a/0ZS0ejwKzqRTdPbYKadaqVs/R+bD1EQtBaADnBvixoaAgVPDWLugNwn8FyrFzGR2QZ arj2Ahp3jzh2FCbmtloIbkKNVizRtTjdHE0q7YdQtASvfy+DmHzyTCrCHlVx1/wSmhpi vRGw== X-Gm-Message-State: AKGB3mJTbkIgm+9RipD7wpAoVc2GACWUvg8l/oH8HNTqzJ8K+ou3e2Tj 917SH2d9mWc4cTMBydG/pdgxg+sI X-Google-Smtp-Source: ACJfBovBDzhhljYHZfuCJcFNpJH2zq/pgojhiEjQ6BNk/MzTFONVGDhXynsebwZI7kitDbqkO3gahQ== X-Received: by 10.84.241.67 with SMTP id u3mr1650726plm.275.1513027857915; Mon, 11 Dec 2017 13:30:57 -0800 (PST) From: Andrey Smirnov To: qemu-arm@nongnu.org Date: Mon, 11 Dec 2017 13:30:03 -0800 Message-Id: <20171211213007.7353-10-andrew.smirnov@gmail.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20171211213007.7353-1-andrew.smirnov@gmail.com> References: <20171211213007.7353-1-andrew.smirnov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::243 Subject: [Qemu-devel] [PATCH 09/13] imx_fec: Use correct length for packet size X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Andrey Smirnov , Jason Wang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org, yurovsky@gmail.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Use 'frame_size' instead of 'len' when calling qemu_send_packet(), failing to do so results in malformed packets send in case when that packed is fragmented into multiple DMA transactions. Cc: Peter Maydell Cc: Jason Wang Cc: Philippe Mathieu-Daud=C3=A9 Cc: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org Cc: yurovsky@gmail.com Reviewed-by: Peter Maydell Signed-off-by: Andrey Smirnov --- hw/net/imx_fec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/imx_fec.c b/hw/net/imx_fec.c index 77d27f763e..6cb9e2e20e 100644 --- a/hw/net/imx_fec.c +++ b/hw/net/imx_fec.c @@ -556,7 +556,7 @@ static void imx_enet_do_tx(IMXFECState *s, uint32_t ind= ex) } /* Last buffer in frame. */ =20 - qemu_send_packet(qemu_get_queue(s->nic), s->frame, len); + qemu_send_packet(qemu_get_queue(s->nic), s->frame, frame_size); ptr =3D s->frame; =20 frame_size =3D 0; --=20 2.14.3