From nobody Tue Feb 10 04:29:50 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1510852113735673.0943237383674; Thu, 16 Nov 2017 09:08:33 -0800 (PST) Received: from localhost ([::1]:41982 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eFNe9-0003bw-0n for importer@patchew.org; Thu, 16 Nov 2017 12:08:13 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48386) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eFNbc-0001zX-9a for qemu-devel@nongnu.org; Thu, 16 Nov 2017 12:05:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eFNbb-00017U-GK for qemu-devel@nongnu.org; Thu, 16 Nov 2017 12:05:36 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33662) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eFNbb-00017J-At; Thu, 16 Nov 2017 12:05:35 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 79EC7C0587F5; Thu, 16 Nov 2017 17:05:34 +0000 (UTC) Received: from t460s.redhat.com (ovpn-116-22.ams2.redhat.com [10.36.116.22]) by smtp.corp.redhat.com (Postfix) with ESMTP id B85F960DCD; Thu, 16 Nov 2017 17:05:32 +0000 (UTC) From: David Hildenbrand To: qemu-s390x@nongnu.org, qemu-devel@nongnu.org Date: Thu, 16 Nov 2017 18:05:25 +0100 Message-Id: <20171116170526.12643-3-david@redhat.com> In-Reply-To: <20171116170526.12643-1-david@redhat.com> References: <20171116170526.12643-1-david@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Thu, 16 Nov 2017 17:05:34 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v1 for-2.11 2/3] s390x/tcg: fix DIAG 308 with > 1 VCPU (single threaded TCG) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Christian Borntraeger , Cornelia Huck , David Hildenbrand , Alexander Graf , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Currently, single threaded TCG with > 1 VCPU gets stuck during IPL, when the bios tries to switch to the loaded kernel via DIAG 308. pause_all_vcpus()/resume_all_vcpus() should not be called from a VCPU. And there is also no need for it. run_on_cpu() will make sure that the CPUs exit KVM/TCG, where they get stopped. Once stopped, they will no longer run. Signed-off-by: David Hildenbrand --- target/s390x/diag.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/target/s390x/diag.c b/target/s390x/diag.c index dbbb9e886f..52bc348808 100644 --- a/target/s390x/diag.c +++ b/target/s390x/diag.c @@ -27,7 +27,6 @@ static int modified_clear_reset(S390CPU *cpu) S390CPUClass *scc =3D S390_CPU_GET_CLASS(cpu); CPUState *t; =20 - pause_all_vcpus(); cpu_synchronize_all_states(); CPU_FOREACH(t) { run_on_cpu(t, s390_do_cpu_full_reset, RUN_ON_CPU_NULL); @@ -37,7 +36,6 @@ static int modified_clear_reset(S390CPU *cpu) s390_crypto_reset(); scc->load_normal(CPU(cpu)); cpu_synchronize_all_post_reset(); - resume_all_vcpus(); return 0; } =20 @@ -53,7 +51,6 @@ static int load_normal_reset(S390CPU *cpu) S390CPUClass *scc =3D S390_CPU_GET_CLASS(cpu); CPUState *t; =20 - pause_all_vcpus(); cpu_synchronize_all_states(); CPU_FOREACH(t) { run_on_cpu(t, s390_do_cpu_reset, RUN_ON_CPU_NULL); @@ -63,7 +60,6 @@ static int load_normal_reset(S390CPU *cpu) scc->initial_cpu_reset(CPU(cpu)); scc->load_normal(CPU(cpu)); cpu_synchronize_all_post_reset(); - resume_all_vcpus(); return 0; } =20 --=20 2.13.6