From nobody Mon Feb 9 00:01:41 2026 Delivered-To: importer@patchew.org Received-SPF: temperror (zoho.com: Error in retrieving data from DNS) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=temperror (zoho.com: Error in retrieving data from DNS) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1510242248611633.5787472659492; Thu, 9 Nov 2017 07:44:08 -0800 (PST) Received: from localhost ([::1]:37555 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eCoze-00028K-QP for importer@patchew.org; Thu, 09 Nov 2017 10:43:50 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48480) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eCowv-0000Yi-1z for qemu-devel@nongnu.org; Thu, 09 Nov 2017 10:41:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eCowq-0006yf-5p for qemu-devel@nongnu.org; Thu, 09 Nov 2017 10:41:01 -0500 Received: from mailhub.sw.ru ([195.214.232.25]:46397 helo=relay.sw.ru) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eCowp-0006wq-QG for qemu-devel@nongnu.org; Thu, 09 Nov 2017 10:40:56 -0500 Received: from kvm.sw.ru (msk-vpn.virtuozzo.com [195.214.232.6]) by relay.sw.ru (8.13.4/8.13.4) with ESMTP id vA9Fen69032756; Thu, 9 Nov 2017 18:40:50 +0300 (MSK) From: Vladimir Sementsov-Ogievskiy To: qemu-block@nongnu.org, qemu-devel@nongnu.org Date: Thu, 9 Nov 2017 18:40:48 +0300 Message-Id: <20171109154049.42386-2-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.11.1 In-Reply-To: <20171109154049.42386-1-vsementsov@virtuozzo.com> References: <20171109154049.42386-1-vsementsov@virtuozzo.com> X-detected-operating-system: by eggs.gnu.org: OpenBSD 3.x [fuzzy] X-Received-From: 195.214.232.25 Subject: [Qemu-devel] [PATCH 1/2] nbd/server: add additional assert to nbd_export_put X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, vsementsov@virtuozzo.com, armbru@redhat.com, mreitz@redhat.com, den@openvz.org, pbonzini@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_6 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" This place is not obvious, nbd_export_close may theoretically reduce refcount to 0. It may happen if someone calls nbd_export_put on named export not through nbd_export_set_name when refcount is 1. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- nbd/server.c | 1 + 1 file changed, 1 insertion(+) diff --git a/nbd/server.c b/nbd/server.c index 70b40ed27e..2f2e05943f 100644 --- a/nbd/server.c +++ b/nbd/server.c @@ -1179,6 +1179,7 @@ void nbd_export_put(NBDExport *exp) nbd_export_close(exp); } =20 + assert(exp->refcount > 0); if (--exp->refcount =3D=3D 0) { assert(exp->name =3D=3D NULL); assert(exp->description =3D=3D NULL); --=20 2.11.1