[Qemu-devel] [PATCH 0/2] Optimize sparse reads over NBD

Eric Blake posted 2 patches 6 years, 4 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20171107030912.23930-1-eblake@redhat.com
Test checkpatch passed
Test docker passed
Test ppc passed
Test s390x passed
nbd/server.c     | 79 +++++++++++++++++++++++++++++++++++++++++++++++++++++---
nbd/trace-events |  1 +
2 files changed, 77 insertions(+), 3 deletions(-)
[Qemu-devel] [PATCH 0/2] Optimize sparse reads over NBD
Posted by Eric Blake 6 years, 4 months ago
When I first proposed the NBD extension of structured reads,
it was in order to more efficiently read sparse files without
sending lots of zeroes over the wire.  These two patches feel
like a feature addition, and missed soft freeze, so I'm
reluctant to include them in a 2.11 pull request; on the other
hand, implementing structured replies without sparse reads is
a rather incomplete feature addition even if it complies with
the NBD spec.  Since structured replies is a new 2.11 feature,
I could argue that it is a bug if the new feature does not go
all the way to sparse reads.

I've posted this as two patches, but welcome opinions on whether
it should be squashed into one.

Based-on: 20171107030236.23633-1-eblake@redhat.com
([PATCH 0/8] various NBD fixes for 2.11)

Eric Blake (2):
  nbd/server: Implement sparse reads atop structured reply
  nbd/server: Optimize final chunk of sparse read

 nbd/server.c     | 79 +++++++++++++++++++++++++++++++++++++++++++++++++++++---
 nbd/trace-events |  1 +
 2 files changed, 77 insertions(+), 3 deletions(-)

-- 
2.13.6


Re: [Qemu-devel] [PATCH 0/2] Optimize sparse reads over NBD
Posted by Paolo Bonzini 6 years, 4 months ago
On 07/11/2017 04:09, Eric Blake wrote:
> When I first proposed the NBD extension of structured reads,
> it was in order to more efficiently read sparse files without
> sending lots of zeroes over the wire.  These two patches feel
> like a feature addition, and missed soft freeze, so I'm
> reluctant to include them in a 2.11 pull request; on the other
> hand, implementing structured replies without sparse reads is
> a rather incomplete feature addition even if it complies with
> the NBD spec.  Since structured replies is a new 2.11 feature,
> I could argue that it is a bug if the new feature does not go
> all the way to sparse reads.
> 
> I've posted this as two patches, but welcome opinions on whether
> it should be squashed into one.

I think I agree with pushing this to the next release.

Paolo

> Based-on: 20171107030236.23633-1-eblake@redhat.com
> ([PATCH 0/8] various NBD fixes for 2.11)
> 
> Eric Blake (2):
>   nbd/server: Implement sparse reads atop structured reply
>   nbd/server: Optimize final chunk of sparse read
> 
>  nbd/server.c     | 79 +++++++++++++++++++++++++++++++++++++++++++++++++++++---
>  nbd/trace-events |  1 +
>  2 files changed, 77 insertions(+), 3 deletions(-)
>