From nobody Mon Feb 9 19:07:20 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1509521081066949.3267390639245; Wed, 1 Nov 2017 00:24:41 -0700 (PDT) Received: from localhost ([::1]:48725 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e9nNz-0003JO-RC for importer@patchew.org; Wed, 01 Nov 2017 03:24:27 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54538) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e9nGz-0006EE-BX for qemu-devel@nongnu.org; Wed, 01 Nov 2017 03:17:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e9nGy-0001WU-Fw for qemu-devel@nongnu.org; Wed, 01 Nov 2017 03:17:13 -0400 Received: from mail-lf0-x244.google.com ([2a00:1450:4010:c07::244]:46665) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e9nGy-0001W3-8O for qemu-devel@nongnu.org; Wed, 01 Nov 2017 03:17:12 -0400 Received: by mail-lf0-x244.google.com with SMTP id g70so1489829lfl.3 for ; Wed, 01 Nov 2017 00:17:12 -0700 (PDT) Received: from localhost.localdomain (c83-254-152-225.bredband.comhem.se. [83.254.152.225]) by smtp.gmail.com with ESMTPSA id c132sm562371lfe.37.2017.11.01.00.17.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 01 Nov 2017 00:17:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Kd3Ts2sK0qM5EZrgstgg3un17UPdc18uEXx8/KI/71Y=; b=Lvf9XXsKAWIdSABCivF6TpvHoRHssyl12EEcd4ZKraSjptiGydOyXZwQcyEpFRpSbD K7yFGjflzvzbhePfaRxXqAsPHM12kfO8+ItPvp9vdcvGYWPwU/ZpAX9SIFmYIc53e702 lBCEZFmzWu6Mef+J8WchEiajNUSXGDUe+CVSfQ/6+CGE8v7nu2RMCBn9AGxHlTER1dYP 7NsU2k9Un6bo+0Y9OfmzwX+Cq92/Myw7XD3bGNhGumIUo35T6ZnENd9sGfbbcxImdnDu 2E/vUskI37gQtmU6e7W4R7Kch0GU1OqM5ULXiws7xxncSzQvzHNQQknFvMKYu+v+byeF iqOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Kd3Ts2sK0qM5EZrgstgg3un17UPdc18uEXx8/KI/71Y=; b=P4tRRNgYUEZ5WYsLjsSf0Qdwj11o+QoC95Q49sE+DMtVOyAWd1yo7c0Phr0J3tHZeJ +U8XHFzqADDUlOFyk+9Die8ICm9sSrL6f/8u1bhAxv06J0+YR/llHNJdcrvTfvT3J8Uw LAdhL1SiXsl63oKoVsKFcYfaFAZg6ME1TCqv1TTmeK86DwOc3J24s1+zeDbQVDTiZDe2 KsTIvkrTFncl7eJzxfSnE8cNHyQrIoiuqvxGKycdzl2lOKyq+fNOVG0R5qbAQbnZaGjI NJ2IMqm8WgsV8b55EFNjdZlFlmjBerx2HO32CBGcruNiMjVMxDA3gY7oaQ6aKHZTR8Qr /nAQ== X-Gm-Message-State: AMCzsaVYRooGAygSVl6lZ631bt6M57Vlvd66KJ8vsHfqy7EfI3DPG+72 BL5eJr5yiuhbh2fm58ELOBgt6Q== X-Google-Smtp-Source: ABhQp+QsS8kPlF1O39EDii2J/LOrOeQHXpjnKA0n0/UzCJBhI0EjxUh8eGaravZnP+ns+H+zlDjHyA== X-Received: by 10.25.202.25 with SMTP id a25mr1825791lfg.83.1509520630760; Wed, 01 Nov 2017 00:17:10 -0700 (PDT) From: Francisco Iglesias To: qemu-devel@nongnu.org Date: Wed, 1 Nov 2017 08:16:50 +0100 Message-Id: <20171101071652.19375-12-frasse.iglesias@gmail.com> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20171101071652.19375-1-frasse.iglesias@gmail.com> References: <20171101071652.19375-1-frasse.iglesias@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4010:c07::244 Subject: [Qemu-devel] [PATCH v6 11/13] xilinx_spips: Don't set TX FIFO UNDERFLOW at cmd done X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: edgari@xilinx.com, alistai@xilinx.com, francisco.iglesias@feimtech.se, mar.krzeminski@gmail.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Don't set TX FIFO UNDERFLOW interrupt after done transmiting the commands. Also update interrupts after reading out the interrupt status. Signed-off-by: Francisco Iglesias --- hw/ssi/xilinx_spips.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/ssi/xilinx_spips.c b/hw/ssi/xilinx_spips.c index 7f0f317..159a89d 100644 --- a/hw/ssi/xilinx_spips.c +++ b/hw/ssi/xilinx_spips.c @@ -329,9 +329,6 @@ static void xilinx_spips_flush_txfifo(XilinxSPIPS *s) uint8_t addr_length; =20 if (fifo8_is_empty(&s->tx_fifo)) { - if (!(s->regs[R_LQSPI_CFG] & LQSPI_CFG_LQ_MODE)) { - s->regs[R_INTR_STATUS] |=3D IXR_TX_FIFO_UNDERFLOW; - } xilinx_spips_update_ixr(s); return; } else if (s->snoop_state =3D=3D SNOOP_STRIPING) { @@ -530,6 +527,7 @@ static uint64_t xilinx_spips_read(void *opaque, hwaddr = addr, ret =3D s->regs[addr] & IXR_ALL; s->regs[addr] =3D 0; DB_PRINT_L(0, "addr=3D" TARGET_FMT_plx " =3D %x\n", addr * 4, ret); + xilinx_spips_update_ixr(s); return ret; case R_INTR_MASK: mask =3D IXR_ALL; --=20 2.9.3