From nobody Tue May 7 20:12:03 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1509463634380645.244407363113; Tue, 31 Oct 2017 08:27:14 -0700 (PDT) Received: from localhost ([::1]:46206 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e9YRO-0005Vr-Gw for importer@patchew.org; Tue, 31 Oct 2017 11:26:58 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40493) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e9YPg-0004ZB-3l for qemu-devel@nongnu.org; Tue, 31 Oct 2017 11:25:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e9YPa-0004Vx-6P for qemu-devel@nongnu.org; Tue, 31 Oct 2017 11:25:12 -0400 Received: from relay2.gtri.gatech.edu ([130.207.199.168]:47248) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e9YPa-0004Uh-25 for qemu-devel@nongnu.org; Tue, 31 Oct 2017 11:25:06 -0400 Received: from hatteras.core.gtri.org (hatteras.core.gtri.org [10.41.22.72]) by relay2.gtri.gatech.edu with ESMTP id hnQHAuP8Noah5iar (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA256 bits=128 verify=NO); Tue, 31 Oct 2017 11:25:03 -0400 (EDT) Received: from tybee.core.gtri.org (10.41.1.49) by hatteras.core.gtri.org (10.41.22.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1034.26; Tue, 31 Oct 2017 11:25:03 -0400 Received: from tia-mxn-d01.ctisl.gtri.org (130.207.205.130) by tybee.core.gtri.org (10.41.1.49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1034.26; Tue, 31 Oct 2017 11:25:03 -0400 X-ASG-Debug-ID: 1509463503-0768e41b2f560600001-jgbH7p X-Barracuda-Envelope-From: Michael.Nawrocki@gtri.gatech.edu From: Mike Nawrocki To: Date: Tue, 31 Oct 2017 11:24:43 -0400 X-ASG-Orig-Subj: [PATCH] Enable 8-byte wide MMIO for 16550 serial devices Message-ID: <20171031152443.3670-1-michael.nawrocki@gtri.gatech.edu> X-Mailer: git-send-email 2.14.2 MIME-Version: 1.0 X-Originating-IP: [130.207.205.130] X-ClientProxiedBy: apatlisdmfe5.core.gtri.org (10.41.104.96) To tybee.core.gtri.org (10.41.1.49) X-Barracuda-Connect: hatteras.core.gtri.org[10.41.22.72] X-Barracuda-Start-Time: 1509463503 X-Barracuda-Encrypted: ECDHE-RSA-AES128-SHA256 X-Barracuda-URL: https://130.207.199.168:443/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at gtri.gatech.edu X-Barracuda-Scan-Msg-Size: 1582 X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=1000.0 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.44359 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 130.207.199.168 Subject: [Qemu-devel] [PATCH] Enable 8-byte wide MMIO for 16550 serial devices X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pbonzini@redhat.com, Mike Nawrocki , mst@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Some drivers for the PPMC7400 PowerPC evaluation board accesses the serial registers through the floating point unit (stfd/ldfd), which is an 8-byte wide access. This patch enables that behavior. Signed-off-by: Mike Nawrocki --- hw/char/serial.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/char/serial.c b/hw/char/serial.c index 376bd2f240..c16c19a406 100644 --- a/hw/char/serial.c +++ b/hw/char/serial.c @@ -1005,7 +1005,7 @@ static void serial_mm_write(void *opaque, hwaddr addr, uint64_t value, unsigned size) { SerialState *s =3D opaque; - value &=3D ~0u >> (32 - (size * 8)); + value &=3D ~((uint64_t)0) >> (64 - (size * 8)); serial_ioport_write(s, addr >> s->it_shift, value, 1); } =20 @@ -1014,16 +1014,22 @@ static const MemoryRegionOps serial_mm_ops[3] =3D { .read =3D serial_mm_read, .write =3D serial_mm_write, .endianness =3D DEVICE_NATIVE_ENDIAN, + .valid.max_access_size =3D 8, + .impl.max_access_size =3D 8, }, [DEVICE_LITTLE_ENDIAN] =3D { .read =3D serial_mm_read, .write =3D serial_mm_write, .endianness =3D DEVICE_LITTLE_ENDIAN, + .valid.max_access_size =3D 8, + .impl.max_access_size =3D 8, }, [DEVICE_BIG_ENDIAN] =3D { .read =3D serial_mm_read, .write =3D serial_mm_write, .endianness =3D DEVICE_BIG_ENDIAN, + .valid.max_access_size =3D 8, + .impl.max_access_size =3D 8, }, }; =20 --=20 2.14.2