From nobody Sun May 5 17:58:43 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1509447342774489.7642200374635; Tue, 31 Oct 2017 03:55:42 -0700 (PDT) Received: from localhost ([::1]:44721 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e9UCp-0003Gn-TC for importer@patchew.org; Tue, 31 Oct 2017 06:55:39 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58443) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e9U6p-0006eb-QA for qemu-devel@nongnu.org; Tue, 31 Oct 2017 06:49:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e9U6m-0005cO-3n for qemu-devel@nongnu.org; Tue, 31 Oct 2017 06:49:27 -0400 Received: from mail.ispras.ru ([83.149.199.45]:40046) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e9U6l-0005c6-Rr for qemu-devel@nongnu.org; Tue, 31 Oct 2017 06:49:24 -0400 Received: from [127.0.1.1] (unknown [85.142.117.226]) by mail.ispras.ru (Postfix) with ESMTPSA id 13CE854006A; Tue, 31 Oct 2017 13:49:23 +0300 (MSK) From: Pavel Dovgalyuk To: qemu-devel@nongnu.org Date: Tue, 31 Oct 2017 13:49:24 +0300 Message-ID: <20171031104923.3079.56109.stgit@pasha-VirtualBox> In-Reply-To: <20171031104741.3079.26584.stgit@pasha-VirtualBox> References: <20171031104741.3079.26584.stgit@pasha-VirtualBox> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 83.149.199.45 Subject: [Qemu-devel] [RFCPATCH19/20] cpu-exec: reset exit flag before calling cpu_exec_nocache X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dovgaluk@ispras.ru Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 This patch resets icount_decr.u32.high before calling cpu_exec_nocache when exception is pending. Exception is caused by the first instruction in the block and it cannot be executed without resetting the flag. Signed-off-by: Pavel Dovgalyuk --- accel/tcg/cpu-exec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c index 35d0240..aaa9c2d 100644 --- a/accel/tcg/cpu-exec.c +++ b/accel/tcg/cpu-exec.c @@ -500,6 +500,7 @@ static inline bool cpu_handle_exception(CPUState *cpu, = int *ret) } else if (replay_has_exception() && cpu->icount_decr.u16.low + cpu->icount_extra =3D=3D 0) { /* try to cause an exception pending in the log */ + atomic_set(&cpu->icount_decr.u16.high, 0); cpu_exec_nocache(cpu, 1, tb_find(cpu, NULL, 0, curr_cflags()), tru= e); *ret =3D -1; return true;