From nobody Sun Nov 2 11:45:08 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1509272662561943.0782227252109; Sun, 29 Oct 2017 03:24:22 -0700 (PDT) Received: from localhost ([::1]:35499 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e8kl4-0005um-Rw for importer@patchew.org; Sun, 29 Oct 2017 06:23:58 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46103) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e8kbV-0006dW-E1 for qemu-devel@nongnu.org; Sun, 29 Oct 2017 06:14:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e8kbU-0007ut-Fw for qemu-devel@nongnu.org; Sun, 29 Oct 2017 06:14:05 -0400 Received: from mail-lf0-x241.google.com ([2a00:1450:4010:c07::241]:49333) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e8kbU-0007uQ-8x for qemu-devel@nongnu.org; Sun, 29 Oct 2017 06:14:04 -0400 Received: by mail-lf0-x241.google.com with SMTP id w21so11682134lfc.6 for ; Sun, 29 Oct 2017 03:14:04 -0700 (PDT) Received: from localhost.localdomain (c83-254-152-225.bredband.comhem.se. [83.254.152.225]) by smtp.gmail.com with ESMTPSA id v62sm2819800lje.39.2017.10.29.03.14.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 29 Oct 2017 03:14:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Kd3Ts2sK0qM5EZrgstgg3un17UPdc18uEXx8/KI/71Y=; b=nKDcKtfxvBmPAVmbJ1AXKpmrp1AG9yyH3WgP1XJUHoRys36YbZDrbmvo+MYYGhr+0b qRsrFqyRDhFuOGkniaHIYUlo+uo1aS2OKP2bDBdG5zjY9YM0OnLe5hgbW2gvkXzpu44V k/hwXrIYCPs5BBHwhVGDbIQvJJ3UVj9/N5BZlFONrC5kTWkmd/OXDCI2QTdGeFvXvRT1 vB0Olo/WMbXkevL+MKNJuNt8P+orqQrvtTrJgnhSViGfQWHb0ZoFPU/78r32mLrxi+Nj iEumXw18L+MPI26WZVdvwdNucK+MqYReRbgWSiMWQ0TyKIJmX0doqqF336vz4cgRMrpw aJlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Kd3Ts2sK0qM5EZrgstgg3un17UPdc18uEXx8/KI/71Y=; b=S1wWbR7+/99c4e8Kwl76+uQzMvbN+JZmjlfanyiyMnNzGa2cWJ3p5reGN90NYhKWTj bhnDK4c9MoXDx5owWrZGAYZo4L6qT1eHMLUrO4CK7z5JkBStv2PaEbj+0YJd/k5rRmnF 7KGTYH7I6vOEEty6dg/CifKdBkJME6ReIwL11vgYL2oajgSgJl5DYeHqj3pWgDbhhpwk m5jGgNAtNrNfBGISgRnT5lZ2T8Q/nXf19pln7qMg1Y4swf2E6V4B5DE2S3tnMeA8e7y6 F9/2B8PXK6arVwa7iaHJUOrTFhdTxao3KdmWOT+CwTKIRY30gXOQ7F1remOgAoeV53NP mWGg== X-Gm-Message-State: AMCzsaVmE/gXaoox2tU9jTmyeLGZNnTK3J0d5lfqWOJTSFFXMfY1Mula fTCjsMt5tnqIp8eiir+5vj8VYw== X-Google-Smtp-Source: ABhQp+TCrpHByYmAqvrRSE+dslfezs2rmmLt+P2fn1+YeJ3EB77QqrqXVyQn4EM8h+vEJ+0IQ+DBXQ== X-Received: by 10.25.151.206 with SMTP id z197mr1707032lfd.3.1509272042822; Sun, 29 Oct 2017 03:14:02 -0700 (PDT) From: Francisco Iglesias To: qemu-devel@nongnu.org Date: Sun, 29 Oct 2017 11:13:41 +0100 Message-Id: <20171029101343.15544-12-frasse.iglesias@gmail.com> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20171029101343.15544-1-frasse.iglesias@gmail.com> References: <20171029101343.15544-1-frasse.iglesias@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4010:c07::241 Subject: [Qemu-devel] [PATCH v5 11/13] xilinx_spips: Don't set TX FIFO UNDERFLOW at cmd done X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: edgari@xilinx.com, alistai@xilinx.com, francisco.iglesias@feimtech.se, mar.krzeminski@gmail.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Don't set TX FIFO UNDERFLOW interrupt after done transmiting the commands. Also update interrupts after reading out the interrupt status. Signed-off-by: Francisco Iglesias --- hw/ssi/xilinx_spips.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/ssi/xilinx_spips.c b/hw/ssi/xilinx_spips.c index 7f0f317..159a89d 100644 --- a/hw/ssi/xilinx_spips.c +++ b/hw/ssi/xilinx_spips.c @@ -329,9 +329,6 @@ static void xilinx_spips_flush_txfifo(XilinxSPIPS *s) uint8_t addr_length; =20 if (fifo8_is_empty(&s->tx_fifo)) { - if (!(s->regs[R_LQSPI_CFG] & LQSPI_CFG_LQ_MODE)) { - s->regs[R_INTR_STATUS] |=3D IXR_TX_FIFO_UNDERFLOW; - } xilinx_spips_update_ixr(s); return; } else if (s->snoop_state =3D=3D SNOOP_STRIPING) { @@ -530,6 +527,7 @@ static uint64_t xilinx_spips_read(void *opaque, hwaddr = addr, ret =3D s->regs[addr] & IXR_ALL; s->regs[addr] =3D 0; DB_PRINT_L(0, "addr=3D" TARGET_FMT_plx " =3D %x\n", addr * 4, ret); + xilinx_spips_update_ixr(s); return ret; case R_INTR_MASK: mask =3D IXR_ALL; --=20 2.9.3