From nobody Tue May 7 02:36:07 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 150883561183463.74146646719635; Tue, 24 Oct 2017 02:00:11 -0700 (PDT) Received: from localhost ([::1]:42680 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e6v44-0004Cq-O7 for importer@patchew.org; Tue, 24 Oct 2017 05:00:00 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53188) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e6v39-0003sY-Bs for qemu-devel@nongnu.org; Tue, 24 Oct 2017 04:59:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e6v35-0003Z5-GE for qemu-devel@nongnu.org; Tue, 24 Oct 2017 04:59:03 -0400 Received: from ozlabs.ru ([107.173.13.209]:59970) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e6v35-0003Ya-AN for qemu-devel@nongnu.org; Tue, 24 Oct 2017 04:58:59 -0400 Received: from vpl1.ozlabs.ibm.com (localhost [IPv6:::1]) by ozlabs.ru (Postfix) with ESMTP id 38DE03A600A6; Tue, 24 Oct 2017 04:57:49 -0400 (EDT) From: Alexey Kardashevskiy To: qemu-devel@nongnu.org Date: Tue, 24 Oct 2017 19:58:53 +1100 Message-Id: <20171024085853.32615-1-aik@ozlabs.ru> X-Mailer: git-send-email 2.11.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 107.173.13.209 Subject: [Qemu-devel] [RFC PATCH qemu] git-submodule.sh: Do not try writing to source directory if not necessary X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexey Kardashevskiy Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The new git-submodule.sh script writes .git-submodule-status to the source directory every time no matter what. This makes it conditional. Signed-off-by: Alexey Kardashevskiy --- I compile out of tree on a remote guest system where I mount the source directory as "readonly" and build directory as "rw" and scripts/git-submodule.sh tries writing to the source directory even when I manually update modules on a host machine which is quite annoying. Is this something acceptable? Or I am missing something here? --- scripts/git-submodule.sh | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/scripts/git-submodule.sh b/scripts/git-submodule.sh index d8fbc7e47e..b642994a67 100755 --- a/scripts/git-submodule.sh +++ b/scripts/git-submodule.sh @@ -33,6 +33,8 @@ status) ;; update) git submodule update --init $modules 1>/dev/null 2>&1 - git submodule status $modules > "${substat}" + substat_tmp=3D$(mktemp) + git submodule status $modules > "$substat_tmp" + diff "${substat_tmp}" "${substat}" || mv "${substat_tmp}" "${substat}" ;; esac --=20 2.11.0