From nobody Tue Feb 10 23:52:50 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 150840759881112.293210478100036; Thu, 19 Oct 2017 03:06:38 -0700 (PDT) Received: from localhost ([::1]:48458 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e57if-0003x6-6y for importer@patchew.org; Thu, 19 Oct 2017 06:06:29 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43526) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e57go-0002nN-Ly for qemu-devel@nongnu.org; Thu, 19 Oct 2017 06:04:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e57gk-0007wA-Mf for qemu-devel@nongnu.org; Thu, 19 Oct 2017 06:04:34 -0400 Received: from 17.mo5.mail-out.ovh.net ([46.105.56.132]:43800) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e57gk-0007v6-GW for qemu-devel@nongnu.org; Thu, 19 Oct 2017 06:04:30 -0400 Received: from player786.ha.ovh.net (b6.ovh.net [213.186.33.56]) by mo5.mail-out.ovh.net (Postfix) with ESMTP id 103A7145A18 for ; Thu, 19 Oct 2017 12:04:29 +0200 (CEST) Received: from zorba.kaod.org (LFbn-1-2231-173.w90-76.abo.wanadoo.fr [90.76.52.173]) (Authenticated sender: clg@kaod.org) by player786.ha.ovh.net (Postfix) with ESMTPSA id 4B2F280079; Thu, 19 Oct 2017 12:04:21 +0200 (CEST) From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: Peter Maydell Date: Thu, 19 Oct 2017 12:04:03 +0200 Message-Id: <20171019100410.26239-2-clg@kaod.org> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20171019100410.26239-1-clg@kaod.org> References: <20171019100410.26239-1-clg@kaod.org> MIME-Version: 1.0 X-Ovh-Tracer-Id: 8695324982241430289 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedttddrudekgddvgecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 46.105.56.132 Subject: [Qemu-devel] [PATCH v4 1/8] aspeed: introduce a dummy ROM device to catch invalid writes X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Jeffery , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org, qemu-arm@nongnu.org, =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Joel Stanley Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Some legacy firmwares access unimplemented addresses on the Aspeed SoC (old U-Boot code using variables in the bss when it shouldn't do). Let's add a dummy ROM device to catch the invalid writes and support new board without using the 'ignore_memory_transaction_failures' flags. Signed-off-by: C=C3=A9dric Le Goater --- hw/arm/aspeed.c | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c index ab895ad490af..e44733153819 100644 --- a/hw/arm/aspeed.c +++ b/hw/arm/aspeed.c @@ -166,6 +166,19 @@ static void aspeed_board_init_flashes(AspeedSMCState *= s, const char *flashtype, } } =20 +static void boot_rom_rw_flash_write(void *opaque, hwaddr offset, uint64_t = value, + unsigned size) +{ + qemu_log_mask(LOG_GUEST_ERROR, + "%s: 0x%" HWADDR_PRIx " <- 0x%" PRIx64 " [%u]\n", + __func__, offset, value, size); +} + +static const MemoryRegionOps boot_rom_rw_flash_ops =3D { + .write =3D boot_rom_rw_flash_write, + .endianness =3D DEVICE_NATIVE_ENDIAN, +}; + static void aspeed_board_init(MachineState *machine, const AspeedBoardConfig *cfg) { @@ -209,6 +222,7 @@ static void aspeed_board_init(MachineState *machine, if (drive0) { AspeedSMCFlash *fl =3D &bmc->soc.fmc.flashes[0]; MemoryRegion *boot_rom =3D g_new(MemoryRegion, 1); + MemoryRegion *boot_rom_rw =3D g_new(MemoryRegion, 1); =20 /* * create a ROM region using the default mapping window size of @@ -221,6 +235,16 @@ static void aspeed_board_init(MachineState *machine, memory_region_add_subregion(get_system_memory(), FIRMWARE_ADDR, boot_rom); write_boot_rom(drive0, FIRMWARE_ADDR, fl->size, &error_abort); + + /* + * Create a fake ROM region to track invalid writes done by + * some legacy firmwares + */ + memory_region_init_rom_device(boot_rom_rw, NULL, &boot_rom_rw_flas= h_ops, + NULL, "aspeed.boot_rom_rw", fl->size, + &error_abort); + memory_region_add_subregion_overlap(get_system_memory(), FIRMWARE_= ADDR, + boot_rom_rw, 0); } =20 aspeed_board_binfo.kernel_filename =3D machine->kernel_filename; --=20 2.13.6