From nobody Tue Feb 10 22:17:37 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1507913599661558.5537931385002; Fri, 13 Oct 2017 09:53:19 -0700 (PDT) Received: from localhost ([::1]:51181 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e33Cr-0000Ie-LG for importer@patchew.org; Fri, 13 Oct 2017 12:53:05 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44248) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e32si-0000iy-Dc for qemu-devel@nongnu.org; Fri, 13 Oct 2017 12:32:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e32sh-0002Sk-Ej for qemu-devel@nongnu.org; Fri, 13 Oct 2017 12:32:16 -0400 Received: from mail-wm0-x22c.google.com ([2a00:1450:400c:c09::22c]:50731) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e32sh-0002Rb-9C for qemu-devel@nongnu.org; Fri, 13 Oct 2017 12:32:15 -0400 Received: by mail-wm0-x22c.google.com with SMTP id u138so22539413wmu.5 for ; Fri, 13 Oct 2017 09:32:15 -0700 (PDT) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id 17sm2914846wru.32.2017.10.13.09.32.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Oct 2017 09:32:12 -0700 (PDT) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id C553C3E0FA1; Fri, 13 Oct 2017 17:24:39 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0pF7DYMlN5Y+H34UPoxCs3esXfc4X++Fqy9m50EgBrY=; b=fQeiw62pegsEImdEgJj5t+w+q85wRPCpdvt3w5RsepMURBXT75HQUC9gP0RMQWEi/d fE12PQgx9aVoUA2cB2FmBeVNyjF8ByHtPuCQGzueSjVpbhzpkCsoXzY4XCR1E+JRBJY4 hj5lQmIQrTmDPlYCb12g69T8a68qZE5KNgmFk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0pF7DYMlN5Y+H34UPoxCs3esXfc4X++Fqy9m50EgBrY=; b=nVWiJKLWRyjAV+EYUvgLGAJVIW3TZnTXKLWXsGF0ByjZXENqLcp/J7OAZQ7Q3uxKrM mPZQQG3uf12nSFyEt3lotU2sS0gmwT7zF3U2s9ookUSdvrgAQl8zgQ4rQcuX+4uYguYa Sl/JB/lYs7g+2ymWueavoTsDnp7Q3xhiajk0iVniXoqL9tcMG68UK3aSqSciG0Nfdeyf qXucakeYXyan5geQyyYvjrUOT/sspetXSyvMe7e9saXFL9K9dT3BJqsUZ4X2SYqumB8r cM5qaFxFX+jmceqhj3qGEmBjmjY4XFCFqlPBAyOzLHr8eyYyAtTcWabiyPZfOaVc2fdM inmQ== X-Gm-Message-State: AMCzsaVjBOPBLbXUgPkhqWhDjhliDsa++Z2FO+ceR0Nl03OJhgLM24Ei ZfIXL6kqU8V/uUmJnnntv7Lz4g== X-Google-Smtp-Source: ABhQp+SfhfqljUX/VdpwNjEj42DcziyCByVLtWWAQ0avnUBBo20UTYkeFlo5hw65ArlHJgq0o5leRg== X-Received: by 10.28.28.138 with SMTP id c132mr1856009wmc.48.1507912334149; Fri, 13 Oct 2017 09:32:14 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: richard.henderson@linaro.org Date: Fri, 13 Oct 2017 17:24:27 +0100 Message-Id: <20171013162438.32458-20-alex.bennee@linaro.org> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20171013162438.32458-1-alex.bennee@linaro.org> References: <20171013162438.32458-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::22c Subject: [Qemu-devel] [RFC PATCH 19/30] Fix mask for AdvancedSIMD 2 reg misc X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 While the group encoding declares bit 28 a zero it is set for FCMGT (zero) Signed-off-by: Alex Benn=C3=A9e --- target/arm/translate-a64.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 11990daff4..7792cea9f5 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -10571,10 +10571,10 @@ static void disas_simd_two_reg_misc(DisasContext = *s, uint32_t insn) /* AdvSIMD two reg misc FP16 * 31 30 29 28 24 23 22 21 17 16 12 11 10 9 5 4 0 * +---+---+---+-----------+---+-------------+--------+-----+------+------+ - * | 0 | 1 | U | 1 1 1 1 0 | a | 1 1 1 1 0 0 | opcode | 1 0 | Rn | Rd | + * | 0 | Q | U | 1 1 1 1 0 | a | 1 1 1 1 0 0 | opcode | 1 0 | Rn | Rd | * +---+---+---+-----------+---+-------------+--------+-----+------+------+ - * mask: 1101 1111 0111 1110 0000 1100 0000 0000 0xdf7e 0c00 - * val: 0101 1110 0111 1000 0000 1000 0000 0000 0x5e78 0800 + * mask: 1001 1111 0111 1110 0000 1100 0000 0000 0x9f7e 0c00 + * val: 0001 1110 0111 1000 0000 1000 0000 0000 0x1e78 0800 * Half-precision variants of two-reg misc. */ static void disas_simd_two_reg_misc_fp16(DisasContext *s, uint32_t insn) @@ -11304,7 +11304,7 @@ static const AArch64DecodeTable data_proc_simd[] = =3D { { 0x5e000000, 0xff208c00, disas_crypto_three_reg_sha }, { 0x5e280800, 0xff3e0c00, disas_crypto_two_reg_sha }, { 0x0e400400, 0x9f60c400, disas_simd_three_reg_same_fp16 }, - { 0x5e780800, 0xdf7e0c00, disas_simd_two_reg_misc_fp16 }, + { 0x0e780800, 0x8f7e0c00, disas_simd_two_reg_misc_fp16 }, { 0x00000000, 0x00000000, NULL } }; =20 @@ -11318,6 +11318,8 @@ static void disas_data_proc_simd(DisasContext *s, u= int32_t insn) if (fn) { fn(s, insn); } else { + fprintf(stderr, "%s: failed to find %#4x @ %#" PRIx64 "\n", + __func__, insn, s->pc); unallocated_encoding(s); } } --=20 2.14.1